Version 0.93.4 of gtk-gnutella is now available, and the attached patch should properly update the port's Makefile, etc. (If the patch gets mangled, just write me a quick note and I'll happily email the patch file.) This patch also integrates ICU and NLS support, I believe, appropriately. The patch also creates a patch-aa.udiff file, which should be in the files directory, and disables an ICU 2.6 specific check. I also removed an option and decided to use a different definable knob for it's purpose. The option was to use the Configure script interactively in case the user had problems with the way the port manages it. An option to do this seems overkill, as the user isn't likely to want this to persist across versions. (Preferably, they've already contacted me to let me know it needs fixing anyways.) If I've done anything wrong, please let me know and I'll submit a fixed patch. Fix: Apply the following patch and assure that patch-aa.udiff is in files: How-To-Repeat: n/a
The WITHOUT_NLS-logic doesn't seem to work -- I don't think you're supposed to set USE_GETTEXT to anything else than "yes" or leave it undefined, but don't ask me about the whys... Volker
State Changed From-To: open->closed Committed, with modifications. First, your WITHOUT_NLS haven't worked at all, so I removed it for now. You need to do more than this, at least pass a configure argument and conditionally remove .mo files from pkg-plist. Anyway, I think WITHOUT_NLS is not worthy here because gtk will always ever bring gettext in. Second, your handling of OPTIONS in ICU case was wrong. When an option is default on, you must check for WITHOUT_option. There are code paths when WITH[OUT]_* variables are not defined at all, and your port should behave in conformity with defaults.