Bug 68598 - portupgrade-20040701_1 dosen't upgrade ports from packages
Summary: portupgrade-20040701_1 dosen't upgrade ports from packages
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Akinori MUSHA
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-02 10:40 UTC by Victor Prylipko
Modified: 2004-07-06 21:00 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Prylipko 2004-07-02 10:40:16 UTC 
On one of my boxes I just cvsuped ports tree, than updated all ports using portupgrade -prvi

than mounted on another box /usr/ports and try to upgrade ports using previously builded pakages.

portupgrade -PPrvi.

portupgrade stoped with error:

(undefined method `>' for #<Array:0x8433b20>)

How-To-Repeat: root@des-free#portversion -v 'portu*'
portupgrade-20040701_1      =  up-to-date with port
root@des-free#


root@des-free#portversion -v 'pop*'
popt-1.6.4_2                <  needs updating (port has 1.7)
root@des-free#portupgrade -PPrvi popt-1.6.4_2
--->  Session started at: Fri, 02 Jul 2004 13:29:24 +0400
--->  Checking for the latest package of 'devel/popt'
--->  Skipping 'sysutils/portdowngrade' (portdowngrade-0.4) because a requisite package 'popt-1.6.4_2' (devel/popt) failed (specify -k to force)
--->  Listing the results (+:done / -:ignored / *:skipped / !:failed)
        ! devel/popt (popt-1.6.4_2)     (undefined method `>' for #<Array:0x8433b20>)
        * sysutils/portdowngrade (portdowngrade-0.4)
--->  Packages processed: 0 done, 0 ignored, 1 skipped and 1 failed
--->  Session ended at: Fri, 02 Jul 2004 13:29:31 +0400 (consumed 00:00:07)
root@des-free#
Comment 1 Kirill Ponomarev freebsd_committer freebsd_triage 2004-07-02 13:06:41 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->knu

Over to maintainer.
Comment 2 andrew 2004-07-06 17:40:13 UTC 
Hi,

Problem in /usr/local/sbin/portupgrade line 1693:

latest_pkg, pkgfile = *pkglist.max { |pkg, file| pkg }

It's possible to portupgrade after cleaning old packages in PACKAGES directory...
Comment 3 Akinori MUSHA 2004-07-06 20:21:27 UTC 
At Tue, 6 Jul 2004 16:40:32 GMT,
Andrew Bliznak wrote:
> The following reply was made to PR ports/68598; it has been noted by GNATS.
> 
> From: Andrew Bliznak <andrew@ort.lviv.net>
> To: freebsd-gnats-submit@FreeBSD.org, vic@liniya.ru
> Cc:  
> Subject: Re: ports/68598: portupgrade-20040701_1 dosen't upgrade ports from
>  packages
> Date: Tue, 06 Jul 2004 19:40:13 +0300
> 
>  Hi,
>  
>  Problem in /usr/local/sbin/portupgrade line 1693:
>  
>  latest_pkg, pkgfile = *pkglist.max { |pkg, file| pkg }

Thanks!  The following patch should fix it.

Index: bin/portupgrade
===================================================================
RCS file: /home/cvs/pkgtools/bin/portupgrade,v
retrieving revision 1.226
diff -u -2 -r1.226 portupgrade
--- bin/portupgrade	30 Jun 2004 16:51:46 -0000	1.226
+++ bin/portupgrade	6 Jul 2004 19:18:10 -0000
@@ -1691,5 +1691,7 @@
   end
 
-  latest_pkg, pkgfile = *pkglist.max { |pkg, file| pkg }
+  latest_pkg, pkgfile = *pkglist.max { |(pkg1, file1), (pkg2, file2)|
+    pkg1 <=> pkg2
+  }
 
   if latest_pkg


-- 
                     /
                    /__  __            Akinori.org / MUSHA.org
                   / )  )  ) )  /     FreeBSD.org / Ruby-lang.org
Akinori MUSHA aka / (_ /  ( (__(  @ iDaemons.org / and.or.jp

"It seems to me as we make our own few circles 'round the sun
          We get it backwards and our seven years go by like one"
Comment 4 Akinori MUSHA freebsd_committer freebsd_triage 2004-07-06 20:59:45 UTC 
State Changed
From-To: open->closed

Fixed, thanks!