Bug 68770 - [PATCH] mail/qmail-scanner: Add an option to select language
Summary: [PATCH] mail/qmail-scanner: Add an option to select language
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-07 15:50 UTC by Renato Botelho
Modified: 2004-08-29 11:10 UTC (History)
1 user (show)

See Also:


Attachments
qmail-scanner-1.22.patch (1.48 KB, patch)
2004-07-07 15:50 UTC, Renato Botelho
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Renato Botelho 2004-07-07 15:50:23 UTC
Add an option (QMAILSCAN_LANG) to select language of notifies.

Port maintainer (freebsd@simplerezo.com) is cc'd.

Generated with FreeBSD Port Tools 0.50
Comment 1 Volker Stolz freebsd_committer freebsd_triage 2004-07-09 14:10:39 UTC
Dear maintainer, please review the proposed patch!

Volker
Comment 2 Volker Stolz freebsd_committer freebsd_triage 2004-07-09 14:20:52 UTC
State Changed
From-To: open->feedback

Forwarded PR to  maintainer
Comment 3 Clément Moulin 2004-07-11 15:46:11 UTC
=20

Hi,

This patch is useless.
Qmail-Scanner use LANG variable from your environnement to "detect" the
appropriate language.

Obviously, you can specify it on command line:
  #LANG=3Djp_JP make

So no needs to define new configuration option like QMAILSCAN_LANG.

Regards,
Clement=20

-----Message d'origine-----
De : Volker Stolz [mailto:vs@freebsd.org] Envoy=E9 : vendredi 9 juillet =
2004
15:11 =C0 : freebsd-gnats-submit@freebsd.org; renato@galle.com.br;
freebsd@simplerezo.com Objet : Re: ports/68770: [PATCH] =
mail/qmail-scanner:
Add an option to select language

Dear maintainer, please review the proposed patch!

Volker
Comment 4 Volker Stolz freebsd_committer freebsd_triage 2004-07-12 10:14:15 UTC
On Sun, Jul 11, 2004 at 04:46:11PM +0200, Clément MOULIN wrote:
> This patch is useless.
> Qmail-Scanner use LANG variable from your environnement to "detect" the
> appropriate language.
> 
> Obviously, you can specify it on command line:
>   #LANG=jp_JP make

Hm, I'm not sure that this is a good idea either -- this would mean that
the environment influences the build when using 'sudo'. I just checked,
export LANG=de; sudo bash -c set | grep LANG reveals that LANG remains
set. I can't nail you down to specific instructions, but I think this
should be considered rather a bug than a feature.

Volker
-- 
http://www-i2.informatik.rwth-aachen.de/stolz/ *** PGP *** S/MIME
Neu! Ändern Sie den Anfangstag Ihrer Woche
Comment 5 Pav Lucistnik freebsd_committer freebsd_triage 2004-08-29 10:50:05 UTC
State Changed
From-To: feedback->closed

Maintainer rejected the patch.
Comment 6 Oliver Eikemeier 2004-08-29 11:04:17 UTC
Volker Stolz wrote:

>  On Sun, Jul 11, 2004 at 04:46:11PM +0200, Cl=E9ment MOULIN wrote:
>> This patch is useless.
>> Qmail-Scanner use LANG variable from your environnement to "detect" =
the
>> appropriate language.
>>
>> Obviously, you can specify it on command line:
>>   #LANG=3Djp_JP make
>
>  Hm, I'm not sure that this is a good idea either -- this would mean=20=

> that
>  the environment influences the build when using 'sudo'. I just =
checked,
>  export LANG=3Dde; sudo bash -c set | grep LANG reveals that LANG =
remains
>  set. I can't nail you down to specific instructions, but I think this
>  should be considered rather a bug than a feature.

You my two cents: since LANG influences sed, grep and other text=20
processing utilities I'm not sure whether it is a good idea to build=20
ports with LANG set. We might decide to sanitize the environment when=20
building ports should this turn out to cause problems, so I would=20
suggest to either make clear that other languages are unsupported or to=20=

make the configuration explicit. Implicit configuration inherited by the=20=

build environment is always fragile and should be made explicit.

-Oliver