Bug 69484 - Mk/bsd.gnome.mk - adds wxtgk/wxgtk2 components
Summary: Mk/bsd.gnome.mk - adds wxtgk/wxgtk2 components
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-23 14:40 UTC by Florent Thoumie
Modified: 2004-07-30 01:30 UTC (History)
0 users

See Also:


Attachments
wxgtk.diff (2.36 KB, patch)
2004-07-23 14:40 UTC, Florent Thoumie
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florent Thoumie 2004-07-23 14:40:21 UTC
This patch adds support for wxgtk and wxgtk2 components.
I didn't add wxgtk2-devel.

I introduced a (non-sexy) way to set/modify variables using ${component}_SET_VARS.

This has been done because I had to set WX_CONFIG according to the
version of wxgtk specified in USE_GNOME.

Please note the following thing :

innercity# cd /usr/ports/devel/py-orbit2    
innercity# make -V ORBIT_CONFIG
/usr/local/bin/orbit-config

I may be wrong but that's not what I am expecting..

This can be corrected using orbit2_SET_VARS= ORBIT_CONFIG=${LOCALBASE}/bin/orbit2-config

How-To-Repeat: 
N/A
Comment 1 Volker Stolz freebsd_committer freebsd_triage 2004-07-23 15:02:00 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to GNOME-team
Comment 2 Adam Weinberger freebsd_committer freebsd_triage 2004-07-23 15:48:58 UTC
>> (07.23.2004 @ 0933 PST): Florent Thoumie said, in 3.9K: <<
> This patch adds support for wxgtk and wxgtk2 components.
> I didn't add wxgtk2-devel.
>> end of "ports/69484: Mk/bsd.gnome.mk - adds wxtgk/wxgtk2 components" from Florent Thoumie <<

I do not think that wxgtk/wxgtk2 belongs in bsd.gnome.mk. It's not a
GNOME creation, and not enough ports use them to warrant inclusion in a
bsd.*.mk anyway.

It's a good suggestion, but I do not believe that it is appropriate to
add to bsd.gnome.mk. I'm inclined to close out this PR, but I'm going to
leave it open for comments from others.

# Adam


--
Adam Weinberger
adamw@magnesium.net || adamw@FreeBSD.org
adamw@vectors.cx    ||   adamw@gnome.org
http://www.vectors.cx
Comment 3 Florent Thoumie 2004-07-23 16:00:19 UTC
Adam Weinberger wrote:

> I do not think that wxgtk/wxgtk2 belongs in bsd.gnome.mk. It's not a
> GNOME creation, and not enough ports use them to warrant inclusion in a
> bsd.*.mk anyway.

	I think GTK is not part of the Gnome Project neither, but you're
	right, this is not the best place for wxgtk stuff, but like you
	said, I didn't want to create bsd.wxgtk.mk since there are not
	so much ports using it.

> It's a good suggestion, but I do not believe that it is appropriate to
> add to bsd.gnome.mk. I'm inclined to close out this PR, but I'm going to
> leave it open for comments from others.

	Ok, what about the ORBit notice ?
Comment 4 Adam Weinberger freebsd_committer freebsd_triage 2004-07-23 16:08:32 UTC
>> (07.23.2004 @ 1100 PST): Florent Thoumie said, in 0.6K: <<
> Adam Weinberger wrote:
> 
> >I do not think that wxgtk/wxgtk2 belongs in bsd.gnome.mk. It's not a
> >GNOME creation, and not enough ports use them to warrant inclusion in a
> >bsd.*.mk anyway.
> 
> 	I think GTK is not part of the Gnome Project neither
>> end of "Re: ports/69484: Mk/bsd.gnome.mk - adds wxtgk/wxgtk2 components" from Florent Thoumie <<

Actually, Gtk is very much a part of the GNOME project. It's
probably the most GNOME projecty part of the GNOME project. ::)

# Adam


--
Adam Weinberger
adamw@magnesium.net || adamw@FreeBSD.org
adamw@vectors.cx    ||   adamw@gnome.org
http://www.vectors.cx
Comment 5 Florent Thoumie 2004-07-23 16:11:28 UTC
Adam Weinberger wrote:

> Actually, Gtk is very much a part of the GNOME project. It's
> probably the most GNOME projecty part of the GNOME project. ::)

	Well, this could be a quite good idea to change GIMP ToolKit to
	Gnome ToolKit ;)
Comment 6 Pav Lucistnik freebsd_committer freebsd_triage 2004-07-30 01:30:26 UTC
State Changed
From-To: open->closed

Submitter agreed on closing this without action.