- add option to enable ipv6 Port maintainer (dom@helenmarks.co.uk) is cc'd. Generated with FreeBSD Port Tools 0.50
Dear maintainer, please review the proposed patch. Volker
State Changed From-To: open->feedback Forwarded PR to maintainer
> Dear maintainer, please review the proposed patch. > > Volker > Please commit it. Thank you, Dominic
Looks like IPv6 won't work on 4.X: ===> Building for distcc-2.16 cc -I/usr/local/include -DHAVE_CONFIG_H -D_GNU_SOURCE -I./src -DSYSCONFDIR="\"/usr/local/etc\"" -DPKGDATADIR="\"/usr/local/share/distcc\"" -Isrc -I./lzo -O -pipe -g -W -Wall -Wimplicit -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -o src/backoff.o -c src/backoff.c In file included from src/backoff.c:43: src/distcc.h:157: #error You can't use RFC2553 because you don't have a sockaddr_storage type gmake: *** [src/backoff.o] Error 1 *** Error code 2 Unluckily, there's no way to hide the option since we'd have to include bsd.port.pre.mk before setting the OPTIONS to test OSVERSION. But bsd.port.pre.mk must be included after OPTIONS for them to work. I'll adapt the comment. How about: IPV6 "Enable IPV6 (will fail on 4.X)" off Volker
> Looks like IPv6 won't work on 4.X: > > ===> Building for distcc-2.16 > cc -I/usr/local/include -DHAVE_CONFIG_H -D_GNU_SOURCE -I./src > -DSYSCONFDIR="\"/usr/local/etc\"" > -DPKGDATADIR="\"/usr/local/share/distcc\"" -Isrc -I./lzo -O -pipe -g -W > -Wall -Wimplicit -Wshadow -Wpointer-arith -Wcast-align -Wwrite-strings > -Waggregate-return -Wstrict-prototypes -Wmissing-prototypes > -Wnested-externs -o src/backoff.o -c src/backoff.c > In file included from src/backoff.c:43: > src/distcc.h:157: #error You can't use RFC2553 because you don't have a > sockaddr_storage type > gmake: *** [src/backoff.o] Error 1 > *** Error code 2 > > Unluckily, there's no way to hide the option since we'd have to include > bsd.port.pre.mk before > setting the OPTIONS to test OSVERSION. But bsd.port.pre.mk must be > included after OPTIONS for > them to work. I'll adapt the comment. How about: > > IPV6 "Enable IPV6 (will fail on 4.X)" off > > Volker > Fine by me, it's lucky you have some 4.x machines :-) Thanks, Dominic
I'm just shooting ideas up, but how about maybe something like the following,.. OPTIONS= # leave blank to enable work around bsd.port.pre.mk .include <bsd.port.pre.mk> .if ${OSVERSION} > 500000 OPTIONS= IPV6 "etc etc" off .endif Michael On Aug 12, 2004, at 10:56 AM, Volker Stolz wrote: > Looks like IPv6 won't work on 4.X: > > ===> Building for distcc-2.16 > cc -I/usr/local/include -DHAVE_CONFIG_H -D_GNU_SOURCE -I./src > -DSYSCONFDIR="\"/usr/local/etc\"" > -DPKGDATADIR="\"/usr/local/share/distcc\"" -Isrc -I./lzo -O -pipe -g > -W -Wall -Wimplicit -Wshadow -Wpointer-arith -Wcast-align > -Wwrite-strings -Waggregate-return -Wstrict-prototypes > -Wmissing-prototypes -Wnested-externs -o src/backoff.o -c > src/backoff.c > In file included from src/backoff.c:43: > src/distcc.h:157: #error You can't use RFC2553 because you don't have > a sockaddr_storage type > gmake: *** [src/backoff.o] Error 1 > *** Error code 2 > > Unluckily, there's no way to hide the option since we'd have to > include bsd.port.pre.mk before > setting the OPTIONS to test OSVERSION. But bsd.port.pre.mk must be > included after OPTIONS for > them to work. I'll adapt the comment. How about: > > IPV6 "Enable IPV6 (will fail on 4.X)" off > > Volker >
State Changed From-To: feedback->closed Committed, thanks! I didn't try the OPTIONS-hack, though: Such things tend to blow up in your face sooner or later.