Bug 70177 - [Maintainer update] sysutils/thefish to 0.6
Summary: [Maintainer update] sysutils/thefish to 0.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-08 17:30 UTC by Miguel Mendez
Modified: 2004-08-09 23:40 UTC (History)
0 users

See Also:


Attachments
thefish.diff (1.88 KB, patch)
2004-08-08 17:30 UTC, Miguel Mendez
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Mendez 2004-08-08 17:30:16 UTC

Changelog: 

0.5.1 -> 0.6 

 A new Qt interface was added (can replace the GTK+ one).
 Minor changes in the GTK+ interface.
Comment 1 Kirill Ponomarev freebsd_committer freebsd_triage 2004-08-09 09:31:06 UTC
State Changed
From-To: open->closed

Committed, thanks!
Comment 2 Volker Stolz freebsd_committer freebsd_triage 2004-08-09 09:33:58 UTC
1) WITH_QT does not work on -STABLE:
moc -o qt_ui_priv.moc qt_ui_priv.h
c++  -O -pipe -g  -fmemoize-lookups -fsave-memoized -Wall -DWITH_QT  
-I/usr/X11R6/include -fmemoize-lookups -fsave-memoized -c qt_ui.C
qt_ui.C: In function `int create_qt_ui(RC_NODE *, int, RC_NODE *, int,  
int, char **)':
qt_ui.C:169: implicit declaration of function `int read(...)'
qt_ui.C:170: implicit declaration of function `int close(...)'
qt_ui.C:194: warning: unused variable `class QColor mygray'
qt_ui.C: In method `void MyDialogs::DoSave()':
qt_ui.C:521: implicit declaration of function `int time(...)'
qt_ui.C:522: implicit declaration of function `int ctime_r(...)'
*** Error code 1

Stop in /usr/ports/sysutils/thefish/work/thefish-0.6.

2) You're (ab)using pkg-message, remember that this also gets displayed  
when installing the package.
3) You should probably make WITH_QT/GTK+ change pkg-suffix

Apologies to krion@ who was 30 secs faster :) Kirill, would you mind  
reopening it?

Volker
Comment 3 Kirill Ponomarev freebsd_committer freebsd_triage 2004-08-09 09:35:50 UTC
State Changed
From-To: closed->open

Reopen due to problems with build on 4.x, using WITH_QT knob.
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2004-08-09 18:54:50 UTC
State Changed
From-To: open->feedback

Set to feedback state, submitter was asked for a patch
Comment 5 Pav Lucistnik freebsd_committer freebsd_triage 2004-08-09 23:39:30 UTC
State Changed
From-To: feedback->closed

Issues mentioned by vs were addressed by author/maintainer 
and the updated port was committed.