Bug 70459 - Update port: games/ssc fix build on 5.x
Summary: Update port: games/ssc fix build on 5.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-14 19:20 UTC by Igor Pokrovsky
Modified: 2004-08-17 10:32 UTC (History)
0 users

See Also:

Attachments
ssc.diff (549 bytes, patch)
2004-08-14 19:20 UTC, Igor Pokrovsky 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Igor Pokrovsky 2004-08-14 19:20:18 UTC 
Doesn't compile with GCC > 3.3.
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2004-08-16 10:44:42 UTC 
This is not a proper fix. First, it's desirable to fix bad C code
instead of forcing older version of compiler. Second, the OSVERSION for
gcc-3.4 import is different.

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

"Well, she turned me into a newt!" "A newt?" "I got better."
Comment 2 Igor Pokrovsky 2004-08-16 18:08:14 UTC 
Pav,

I have no idea how to fix old C++ code of the game,
that's why I forced build system to use GCC 3.3.
I think this approach is suitable, and once me or somebody else
will come with the correct code fix it won't be hard to modify the port.
I fixed OSVERSION number, the updated patch follows.

diff -ru /usr/ports/games/ssc/Makefile ssc/Makefile
--- /usr/ports/games/ssc/Makefile	Sun Aug  1 21:22:28 2004
+++ ssc/Makefile	Sat Aug 14 22:11:14 2004
@@ -29,6 +29,12 @@
 		LDFLAGS=-L${X11BASE}/lib
 ONLY_FOR_ARCHS=	i386
 
+.include <bsd.port.pre.mk>
+
+.if ${OSVERSION} >= 502126
+USE_GCC=	3.3
+.endif
+
 post-patch:
 	@${REINPLACE_CMD} -e "s|SDL\/||g; s|/usr/local|${PREFIX}|g" \
 		${WRKSRC}/src/*.h ${WRKSRC}/src/*.cc
@@ -39,4 +45,4 @@
 	${INSTALL_DATA} ${WRKSRC}/README ${DOCSDIR}
 .endif
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>

-ip

-- 
Real programmers do not apply DP terminology to non-DP
situations.
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2004-08-16 18:11:01 UTC 
V po, 16. 08. 2004 v 19:08, Igor Pokrovsky pí¹e:

> I have no idea how to fix old C++ code of the game,
> that's why I forced build system to use GCC 3.3.
> I think this approach is suitable, and once me or somebody else
> will come with the correct code fix it won't be hard to modify the port.
> I fixed OSVERSION number, the updated patch follows.

 
> +.include <bsd.port.pre.mk>
> +
> +.if ${OSVERSION} >= 502126
> +USE_GCC=	3.3
> +.endif


Won't work. USE_GCC=3.3 tells use 3.3 *or newer* if available, so on
post-502126 systems it will use 3.4 from base anyway.

options are:

1) fix breakage in source
2) mark BROKEN for >= 502126

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

A two-eyed cyclops would be a bicyclops.
Comment 4 Igor Pokrovsky 2004-08-16 18:27:45 UTC 
Ok, I hope this one is fine:

diff -ru /usr/ports/games/ssc/Makefile ssc/Makefile
--- /usr/ports/games/ssc/Makefile	Sun Aug  1 21:22:28 2004
+++ ssc/Makefile	Sat Aug 14 22:11:14 2004
@@ -29,6 +29,12 @@
 		LDFLAGS=-L${X11BASE}/lib
 ONLY_FOR_ARCHS=	i386
 
+.include <bsd.port.pre.mk>
+
+.if ${OSVERSION} >= 502126
+BROKEN=	Doesn't compile on GCC > 3.3
+.endif
+
 post-patch:
 	@${REINPLACE_CMD} -e "s|SDL\/||g; s|/usr/local|${PREFIX}|g" \
 		${WRKSRC}/src/*.h ${WRKSRC}/src/*.cc
@@ -39,4 +45,4 @@
 	${INSTALL_DATA} ${WRKSRC}/README ${DOCSDIR}
 .endif
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>

-ip

-- 
Real programmers do not apply DP terminology to non-DP
situations.
Comment 5 Pav Lucistnik freebsd_committer freebsd_triage 2004-08-17 10:31:49 UTC 
State Changed
From-To: open->closed

Latest patch committed, thank you!