Bug 70613 - mplayer port in 5.2-CURRENT is broken
Summary: mplayer port in 5.2-CURRENT is broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Volker Stolz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-18 12:30 UTC by Eygene A. Ryabinkin
Modified: 2004-08-26 08:31 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eygene A. Ryabinkin 2004-08-18 12:30:20 UTC 
 MPlayer port does not compile. The compilation hangs on libmpcodecs/vf_qp.c

Fix: 

The problem lies in the file libavcodec/dsputil.h: on the line 557 and below
it says
-------
#ifndef HAVE_LPRINTF
/* XXX: add ISOC specific test to avoid specific BSD testing. */
/* better than nothing implementation. */
/* btw, rintf() is existing on fbsd too -- alex */
static inline long int lrintf(float x)
-------
 The things is that in file libmpcodecs/vf_qp.c we already have the knob for
FreeBSD: it #define's lrintf(x) as rintf(x). So we got an obvious compile error.
My fix was to replace string
 #ifndef HAVE_LPRINTF
by
 #if !defined(HAVE_LRINTF) && !defined(__FreeBSD__)
How-To-Repeat:  Download the port with Makefile version 1.101 and try to compile it.
Comment 1 Oliver Eikemeier freebsd_committer freebsd_triage 2004-08-18 13:03:25 UTC 
State Changed
From-To: open->feedback

Asked maintainer for feedback.
Comment 2 Oliver Eikemeier 2004-08-18 13:04:30 UTC 
Eygene A. Ryabinkin wrote:

>> Number:         70613
>> Category:       ports
>> Synopsis:       mplayer port in 5.2-CURRENT is broken

Dear maintainer,

could you please have a look into PR 70613:
   <http://www.freebsd.org/cgi/query-pr.cgi?pr=70613>

Thanks
-Oliver
Comment 3 Eygene A. Ryabinkin 2004-08-20 07:17:54 UTC 
On Thu, Aug 19, 2004 at 11:41:34PM +0200, Thomas E. Zander wrote:
> Could you please verify and (if successful) commit the attached updated
> version of extra-patch-gcc34 to the port?
> 
> It just encapsulates Eygene's workaround from pr 70613 into the gcc-metapatch,
> no big deal.
 Works fine for me. Thanks.
	rea
Comment 4 Eygene A. Ryabinkin 2004-08-20 07:23:25 UTC 
On Thu, Aug 19, 2004 at 11:41:34PM +0200, Thomas E. Zander wrote:
> Could you please verify and (if successful) commit the attached updated
> version of extra-patch-gcc34 to the port?
> 
> It just encapsulates Eygene's workaround from pr 70613 into the gcc-metapatch,
> no big deal.
 Works fine for me. Thanks.
	rea
Comment 5 Volker Stolz freebsd_committer freebsd_triage 2004-08-20 16:52:12 UTC 
State Changed
From-To: feedback->patched

Keep visible for a bit in case more people decide to report this.
Comment 6 Volker Stolz freebsd_committer freebsd_triage 2004-08-20 16:52:12 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->vs

I'll track this.
Comment 7 Volker Stolz freebsd_committer freebsd_triage 2004-08-26 08:30:51 UTC 
State Changed
From-To: patched->closed

Everything okay.