Bug 70906 - net/mldonkey-core 2.5.21 port does not compile
Summary: net/mldonkey-core 2.5.21 port does not compile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-24 18:30 UTC by Nicolas Blais
Modified: 2004-09-19 18:32 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Blais 2004-08-24 18:30:09 UTC
When compiling mldonkey-core, with all its dependencies installed such as ocaml-3.08.1, it stops during the build of tools/zoggy.

===>  Building for mldonkey-core-2.5.21
/usr/local/bin/ocamlc.opt -I tools/zoggy -I +camlp4 -pp "camlp4 pa_o.cmo pr_dump
.cmo" -a -o pa_zog.cma  tools/zoggy/zog_types.ml tools/zoggy/zog_messages.ml too
ls/zoggy/zog_misc.ml tools/zoggy/pa_zog.ml
File "tools/zoggy/pa_zog.ml", line 502, characters -72--44:
use of antiquotation syntax deprecated since version 3.05
File "tools/zoggy/pa_zog.ml", line 42, characters 40-41:
This expression has type int but is here used with type Lexing.position
gmake: *** [pa_zog.cma] Error 2
*** Error code 2

Stop in /usr/ports/net/mldonkey-core.

Fix: 

no fix known.
How-To-Repeat: 	/usr/ports/net/mldonkey-core# make install
Comment 1 Nick B 2004-08-25 02:02:18 UTC
My email is nb_root@videotron.ca, not what is shown in the originator.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2004-08-31 05:49:30 UTC
State Changed
From-To: open->feedback

Does the maintainer see this same problem?
Comment 3 Nicolas Blais 2004-09-05 15:55:12 UTC
The problem is that this version of mldonkey doesn't compile with ocaml 3.08.  

A patch has been applied to the source as seen on :
http://savannah.nongnu.org/cgi-bin/viewcvs/*checkout*/mldonkey/mldonkey/distrib/ChangeLog?rev=HEAD&content-type=text/plain
to make it compile with ocaml 3.08.

Then when the newest version of mldonkey (currently  2.5.28 = 2.6pre10) makes 
it to the ports, it will compile.

Nicolas.
Comment 4 Holger Lamm 2004-09-08 21:13:43 UTC
 > Then when the newest version of mldonkey (currently  2.5.28 = 2.6pre10) makes
 > it to the ports, it will compile.

It there a reasonable way for that? Unfortunately, there is no source package
to download anywhere, only CVS.

A diff between 2.5.22 and 2.5.28 is 260kB zipped;
I'm actually trying to make 2.5.28 compile.

Regards,
Holger
Comment 5 Holger Lamm 2004-09-08 23:12:42 UTC
Okay, I've got 2.5.28 running here.

Is there a possibility to host the 260kB patch somewhere? On freebsd.org maybe? I can't.
It's under GNU, so no legal problems.

The Changelog says it should work with ocaml 3.08 starting revision 2.5.23, I can
try to reduce the diff by that...

Thanks,
Holger
Comment 6 Holger Lamm 2004-09-13 22:21:59 UTC
Okay, I'm done with that with 2.5.23; the patch is 88kB and I'll put that
on my own website hoping it won't blast it off.

Regards,
Holger
--------------------------------- snip ----------------------------------
diff -Nur mldonkey.orig/Makefile mldonkey/Makefile
--- mldonkey.orig/Makefile	Mon Sep 13 23:14:58 2004
+++ mldonkey/Makefile	Mon Sep 13 23:16:10 2004
@@ -6,11 +6,14 @@
 #
 
 PORTNAME=	mldonkey
-PORTVERSION=	2.5.21
+PORTVERSION=	2.5.23
+DOWNLOADVERSION=2.5.22
 CATEGORIES+=	net
 MASTER_SITES=	${MASTER_SITE_SAVANNAH}
+PATCH_SITES=	http://www.schraegerpunkt.de/
 MASTER_SITE_SUBDIR=	${PORTNAME}
-DISTNAME=	${PORTNAME}-${PORTVERSION}
+DISTNAME=	${PORTNAME}-${DOWNLOADVERSION}
+PATCHFILES=	mldonkey-${DOWNLOADVERSION}-${PORTVERSION:C/.+\.//}.patch.gz
 
 MAINTAINER?=	holger@e-gitt.net
 COMMENT?=	A OCAML client for multiple peer-to-peer networks
@@ -19,7 +22,7 @@
 
 GNU_CONFIGURE=	yes
 CONFIGURE_ARGS=	--enable-pthread --enable-ocamlver=3
-WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
+WRKSRC=		${WRKDIR}/${PORTNAME}-${DOWNLOADVERSION}
 USE_GMAKE=	yes
 ALL_TARGET=	depend opt
 
@@ -34,6 +37,7 @@
 .else
 PLIST_SUB+=	GUI=""
 BUILD_DEPENDS+=	lablgtk:${PORTSDIR}/x11-toolkits/ocaml-lablgtk \
+		autoconf213:${PORTSDIR}/devel/autoconf213 \
 		${LOCALBASE}/lib/ocaml/jabbr.cma:${PORTSDIR}/net/ocaml-jabbr
 # we don't need lablgtk as RUN dependency, but we need gtk+glib
 USE_GNOME=	gtk12
@@ -53,6 +57,9 @@
 	@${ECHO_MSG} "You can disable the GUI by defining WITHOUT_GUI."
 	@${ECHO_MSG} "You can disable the CORE by defining WITHOUT_CORE."
 .endif
+
+pre-configure:
+	@cd ${WRKSRC}/config && ${AUTOCONF}
 
 post-patch:
 	@${SED} -e "s|%%PREFIX%%|${PREFIX}|" ${FILESDIR}/wrapper.sh > \
diff -Nur mldonkey.orig/distinfo mldonkey/distinfo
--- mldonkey.orig/distinfo	Mon Sep 13 23:14:58 2004
+++ mldonkey/distinfo	Mon Sep 13 22:47:40 2004
@@ -1,2 +1,4 @@
-MD5 (mldonkey-2.5.21.tar.gz) = 8a96738990f8ffc36eeb2c1f2f655826
-SIZE (mldonkey-2.5.21.tar.gz) = 3234137
+MD5 (mldonkey-2.5.22.tar.gz) = 958ffb63dbcfcb0f6e48788774dfbb42
+SIZE (mldonkey-2.5.22.tar.gz) = 3474104
+MD5 (mldonkey-2.5.22-23.patch.gz) = 091c77f0dd29be7443ac62e99cc41dc0
+SIZE (mldonkey-2.5.22-23.patch.gz) = 88210
diff -Nur mldonkey.orig/files/patch-Makefile mldonkey/files/patch-Makefile
--- mldonkey.orig/files/patch-Makefile	Thu Jan  1 01:00:00 1970
+++ mldonkey/files/patch-Makefile	Wed Sep  8 22:55:10 2004
@@ -0,0 +1,11 @@
+--- Makefile.orig	Wed Sep  8 22:54:44 2004
++++ Makefile	Wed Sep  8 22:54:54 2004
+@@ -258,7 +258,7 @@
+ all: Makefile config/Makefile.config $(TARGET_TYPE)
+ 
+ config/configure: config/configure.in
+-	cd config; autoconf
++	cd config; autoconf213
+ 
+ ifeq ("$(MYCONFIG_ARGS_DEFINED)" , "yes")
+
Comment 7 Pav Lucistnik freebsd_committer freebsd_triage 2004-09-19 12:09:24 UTC
State Changed
From-To: feedback->open

Feedback received. 


Comment 8 Pav Lucistnik freebsd_committer freebsd_triage 2004-09-19 12:09:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pav

Poke.
Comment 9 Pav Lucistnik freebsd_committer freebsd_triage 2004-09-19 18:32:30 UTC
State Changed
From-To: open->closed

Fix committed.