Bug 71010 - port k3b: detection of TEAC-R56S fails due to error in patchfile
Summary: port k3b: detection of TEAC-R56S fails due to error in patchfile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-27 01:10 UTC by Reinhard Lenninger
Modified: 2004-09-02 16:27 UTC (History)
1 user (show)

See Also:

Attachments
patch (1.23 KB, patch)
2004-08-29 09:36 UTC, Heiner 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Reinhard Lenninger 2004-08-27 01:10:23 UTC 

port k3b fails to correctly detect the device TEAC R56S as cd recorder. To solve this 
problem there exists patch-src-device-k3bdevice.cpp in /usr/ports/sysutils/k3b/files. 
Unfortunately the patch needs a little change to detect the drive correctly.

Fix: 

change the following section in patch-src-device-k3bdevice.cpp from

@@ -769,6 +779,14 @@
       m_bufferSize = 1024;
       d->burnfree = false;
     }
+    else if( description().startsWith("CD-R56S") ) {
+      m_writeModes |= TAO;
+      d->deviceType |= CDROM|CDR;
+      m_maxWriteSpeed = 6;
+      m_maxReadSpeed = 24;
+      m_bufferSize = 1302;
+      d->burnfree = false;
+    }
   }
   else if( vendor().startsWith("HP") ) {
     if( description().startsWith("CD-Writer 6020") ) {

to

@@ -769,6 +779,14 @@
       m_bufferSize = 1024;
       d->burnfree = false;
     }
+  }
+  else if( description().startsWith("CD-R56S") ) {
+    m_writeModes |= TAO;
+    d->deviceType |= CDROM|CDR;
+    m_maxWriteSpeed = 6;
+    m_maxReadSpeed = 24;
+    m_bufferSize = 1302;
+    d->burnfree = false;
   }
   else if( vendor().startsWith("HP") ) {
     if( description().startsWith("CD-Writer 6020") ) {
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2004-08-28 06:02:15 UTC 
State Changed
From-To: open->feedback

To maintainer: do you approve of this patch? 

(To submitter: don't forget to Cc: the maintainer when submitting PRs.)
Comment 2 Heiner 2004-08-29 09:36:55 UTC 
Thanks for the report. A problem with the suggested patch is, that all drives 
named CD-R56Sxxxxx are affected, not only those by TAEC. The attached patch 
should fix this. The reporter should test it, as I do not have a TEAC drive. 
If it works it can be committed.


Heiner
Comment 3 Tilman Keskinoz freebsd_committer freebsd_triage 2004-09-02 16:26:42 UTC 
State Changed
From-To: feedback->closed

Committed Heiner's patch. Thanks for reporting