Bug 71789 - net/gtk-gnutella: WITHOUT_ICU knob doesn't work
Summary: net/gtk-gnutella: WITHOUT_ICU knob doesn't work
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-16 11:20 UTC by Andriy Gapon
Modified: 2004-12-20 12:21 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Gapon 2004-09-16 11:20:18 UTC
No matter if you select or unselect ICU support in `make config`, gtk-gnutella is built with ICU:
Feature Summary (Version 0.94):

-------------------------------------------------
GUI front-end                      : GTK2
Persistent filters                 : yes
Gnutella traffic compression       : yes
IP TOS (Type of Service)           : yes
NLS (Native Language Support)      : yes
Extended non-roman charset support : yes
Experimental remote control        : yes
-------------------------------------------------

Fix: 

sorry.
How-To-Repeat: 1. build gtk-gnutella "wihout ICU"
2. set your CHARSET environment variable to charset unsupported by ICM e.g. KOI8-U
3. start the program and enter any search query you'd like (in ASCII)
4. see that no search results appear no matter how long you wait (this is because gtk-gnutella silently "converts" search string to void, probably a bug on their part)
Comment 1 Clayton Rollins 2004-11-06 02:01:21 UTC
Hi again Andriy,

For committers, I am the port [MAINTAINER] and this does contain a [PATCH]. 
:)

Just noticed the PR thanks to the script that checks these things. If you 
had CC'ed, you would have gotten it fixed faster.

Thanks for reporting, at any rate.

The following patch should disable ICU checking. As for whether it fixes 
your specific problem will have to be tested by you as I have to go out the 
door this second.

--- ./Makefile.orig	Mon Jul 12 02:55:46 2004
+++ ./Makefile	Fri Nov  5 18:30:26 2004
@@ -80,6 +80,8 @@

# Add threading to the ld flags; icuuc requires these by default
CONFIGURE_ARGS+=	-Dldflags=${PTHREAD_LIBS}
+.else
+CONFIGURE_ARGS+=	-Dd_icu=false
.endif

.if defined(WITH_PORTABILITY)

_________________________________________________________________
Dont just search. Find. Check out the new MSN Search! 
http://search.msn.click-url.com/go/onm00200636ave/direct/01/
Comment 2 Volker Stolz freebsd_committer freebsd_triage 2004-12-20 12:21:30 UTC
State Changed
From-To: open->closed

Committed with ports/75232. Thanks for your submission!