Bug 71790 - devel/icu2: add koi8-u converter to standard data library
Summary: devel/icu2: add koi8-u converter to standard data library
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Mikhail Teterin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-16 11:40 UTC by Andriy Gapon
Modified: 2005-06-06 01:00 UTC (History)
0 users

See Also:


Attachments
patch-koi8-u (12.53 KB, text/plain)
2004-09-16 11:40 UTC, Andriy Gapon
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Gapon 2004-09-16 11:40:24 UTC
FreeBSD supports locales with KOI8-U charset, but it is not
supported by ICU standard data library, thus some applications using
ICU do not work properly out-of-box in environments with KOI8-U charset.

Fix: the patch below adds KOI8-U converter to ICU standard data library.
.ucm file is borrowed from perl.
How-To-Repeat: E.g.:
1. build gtk-gnutella "with ICU" (I think it is default and the package is built so)
2. set your CHARSET environment variable KOI8-U
3. start the program and enter any search query you'd like (in ASCII)
4. see that no search results appear no matter how long you wait
(this is because conversion from KOI8-U to unicode silently fails and gtk-gnutella
simply ignores query)
Comment 1 Volker Stolz freebsd_committer freebsd_triage 2004-11-08 12:19:46 UTC
Dear maintainer, please look into this issue!
Note to submitter: Please contact teh maintainer before submitting a PR.

Cheers,
   Volker
Comment 2 Volker Stolz freebsd_committer freebsd_triage 2004-11-08 12:22:04 UTC
State Changed
From-To: open->feedback

Forwarded PR to maintainer
Comment 3 Mikhail Teterin 2004-11-15 19:57:19 UTC
I went into this port and came up with the

 http://virtual-estates.net/port-stuff/icu.diff

The diff does the following things:
 . adds the original koi8-u.ucm submitted by Andriy to files/;
 . makes it easier to add new encodings -- just drop the .ucm-file into files/
   and add another hunk to files/patch-convrtrs;
 . increases the chances of the port working on other BSDs
   (s/FreeBSD/${OPSYS}/);
 . fixes the port to use the correct CC, CXX, CFLAGS (files/patch-cc-flags);
 . enables the vendor's tests and runs them after the build (with LANG=C);
 . fixes the Ukrainian-locale descpription, so that the spell-out rules (%V);
   generate proper words for negative and fractional numbers (files/patch-uk);
 . updates the port to the version 3.0 -- released this summer.

Andriy, can you, please, test the diff again gnutella et al?

The port's maintainer is yet to respond Volker's e-mail a week ago, so we can 
presume, he is too busy right now.

However, the new version is 3.0 and to keep calling it icu2 seems wrong. Can 
portmgr@, please, cast the neccessary spells (viz. UPDATING, MOVED, 
repo-copy) to migrate devel/icu2 over to devel/icu (obsolete and unused by 
anything)?

Thanks! Yours,

 -mi
Comment 4 krion 2004-11-15 20:06:42 UTC
Hi,

On Mon, Nov 15, 2004 at 02:57:19PM -0500, Mikhail Teterin wrote:
> However, the new version is 3.0 and to keep calling it icu2 seems wrong. Can 
> portmgr@, please, cast the neccessary spells (viz. UPDATING, MOVED, 
> repo-copy) to migrate devel/icu2 over to devel/icu (obsolete and unused by 
> anything)?


Please read more carefully:

http://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html#Q12.2.3.

As committer you're allowed to commit UPDATING and MOVED, no special
approvements from portmgr are required.

-Kirill
Comment 5 Mikhail Teterin 2004-11-15 20:24:18 UTC
[Addresses trimmed]

=D0=CF=CE=C5=C4=A6=CC=CF=CB 15 =CC=C9=D3=D4=CF=D0=C1=C4 2004 15:06, Kirill =
Ponomarew =F7=C9 =CE=C1=D0=C9=D3=C1=CC=C9:
> Hi,
>
> On Mon, Nov 15, 2004 at 02:57:19PM -0500, Mikhail Teterin wrote:
> > However, the new version is 3.0 and to keep calling it icu2 seems wrong.
> > Can portmgr@, please, cast the neccessary spells (viz. UPDATING, MOVED,
> > repo-copy) to migrate devel/icu2 over to devel/icu (obsolete and unused
> > by anything)?
>
> Please read more carefully:
>
>=20
http://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.=
html#Q12.2.3.
>
> As committer you're allowed to commit UPDATING and MOVED, no special
> approvements from portmgr are required.

But I can not do repo-copies -- and I seem to remember the repo-meisters=20
either expecting the portmgr to do the repo-copying themselves or to reques=
t=20
port-related cvs-manipulations directly. No?

 -mi
Comment 6 Mikhail Teterin freebsd_committer freebsd_triage 2004-11-15 20:28:52 UTC
State Changed
From-To: feedback->repocopy

The icu2 needs to be copied over to icu -- the latter is obsolete. Then the upgrade to icu-3.0, 
the Ukrainian related bits, and the other things can be committed.
Comment 7 Mikhail Teterin freebsd_committer freebsd_triage 2004-11-15 20:30:36 UTC
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

Needs repo-copy.
Comment 8 Bjoern A. Zeeb 2004-11-15 20:31:54 UTC
On Mon, 15 Nov 2004, Mikhail Teterin wrote:

> I went into this port and came up with the
>
>  http://virtual-estates.net/port-stuff/icu.diff

no plist updates needed ?

> The diff does the following things:
>  . adds the original koi8-u.ucm submitted by Andriy to files/;
>  . makes it easier to add new encodings -- just drop the .ucm-file into files/
>    and add another hunk to files/patch-convrtrs;
>  . increases the chances of the port working on other BSDs
>    (s/FreeBSD/${OPSYS}/);
>  . fixes the port to use the correct CC, CXX, CFLAGS (files/patch-cc-flags);
>  . enables the vendor's tests and runs them after the build (with LANG=C);
>  . fixes the Ukrainian-locale descpription, so that the spell-out rules (%V);
>    generate proper words for negative and fractional numbers (files/patch-uk);
>  . updates the port to the version 3.0 -- released this summer.

they have release 3.2sth last week.


> However, the new version is 3.0 and to keep calling it icu2 seems wrong. Can
> portmgr@, please, cast the neccessary spells (viz. UPDATING, MOVED,
> repo-copy) to migrate devel/icu2 over to devel/icu (obsolete and unused by
> anything)?

please do not move icu2 to icu. have a repocopy for icu2 to icu3 or
icu2 to icu and make icu ver. 3 port name icu again. One of the two
would be the best choice I guess just in case someone wants to update
icu2 to lastest version. I don't know the differences (icu2 to icu3).

Further do you (Andriy) consider sending the update of koi8-u.ucm
to IBM OSS for inclusion in next version ?


Apart from that I am more than happy that you actively maintain the
ICU port(s) :)

-- 
Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT
Comment 9 krion 2004-11-15 20:55:08 UTC
Hi,

On Mon, Nov 15, 2004 at 03:24:18PM -0500, Mikhail Teterin wrote:
> But I can not do repo-copies -- and I seem to remember the repo-meisters 
> either expecting the portmgr to do the repo-copying themselves or to request 
> port-related cvs-manipulations directly. No?


Yes, but you need to assign it to portmgr and set "state" to
repocopy, it's everything documented.

-Kirill
Comment 10 Volker Stolz freebsd_committer freebsd_triage 2004-11-15 20:55:20 UTC
On 15.11.2004, at 21:31, Bjoern A. Zeeb wrote:
> On Mon, 15 Nov 2004, Mikhail Teterin wrote:
>
>> However, the new version is 3.0 and to keep calling it icu2 seems 
>> wrong. Can
>> portmgr@, please, cast the neccessary spells (viz. UPDATING, MOVED,
>> repo-copy) to migrate devel/icu2 over to devel/icu (obsolete and 
>> unused by
>> anything)?
>
> please do not move icu2 to icu. have a repocopy for icu2 to icu3 or
> icu2 to icu and make icu ver. 3 port name icu again. One of the two
> would be the best choice I guess just in case someone wants to update
> icu2 to lastest version. I don't know the differences (icu2 to icu3).
>
Regarding the repocopy, please note that you can't repocopy over 
existing or former stuff.

However, if no other port requires icu-1, we can update devel/icu to 
icu3 *and* make everybody happy since dir/foo should always be the 
current version while the dir/fooN should be only for older version 
we'd like to keep. Or is icu3 still a development version?
-- 
http://lambda.foldr.org/~vs/
Comment 11 Mikhail Teterin 2004-11-15 21:28:30 UTC
=D0=CF=CE=C5=C4=A6=CC=CF=CB 15 =CC=C9=D3=D4=CF=D0=C1=C4 2004 15:31, Bjoern =
A. Zeeb =F7=C9 =CE=C1=D0=C9=D3=C1=CC=C9:
> On Mon, 15 Nov 2004, Mikhail Teterin wrote:
> > I went into this port and came up with the
> >
> >  http://virtual-estates.net/port-stuff/icu.diff
>
> no plist updates needed ?

No -- the only added file is koi8-u.ucm and it seems to be compiled into th=
e=20
library(ies).

> they have release 3.2sth last week.

That's cruel... But the home page still lists 3.0 as the last release. Is 3=
=2E2=20
in BETA or some such?

> please do not move icu2 to icu. have a repocopy for icu2 to icu3 or
> icu2 to icu and make icu ver. 3 port name icu again. One of the two
> would be the best choice I guess just in case someone wants to update
> icu2 to lastest version. I don't know the differences (icu2 to icu3).

Why (other than the no-repo-copies-over-old-stuff)? Nothing uses the old=20
icu...

> Further do you (Andriy) consider sending the update of koi8-u.ucm
> to IBM OSS for inclusion in next version ?

Yes -- once the files and patches are committed and I can send their URLs t=
o=20
IBM.

 -mi
Comment 12 Bjoern A. Zeeb 2004-11-15 21:47:02 UTC
On Mon, 15 Nov 2004, Mikhail Teterin wrote:

> ????????? 15 ???????? 2004 15:31, Bjoern A. Zeeb ?? ????????:
>
> Why (other than the no-repo-copies-over-old-stuff)? Nothing uses the old
> icu...

what I meant and Volker already said is:

just let devel/icu2 untouched and make devel/icu version 3.x.


btw: anyone interested in updating icu2 to latest version or aren't
there any big changes to icu3 ?

If the gnome stuff will be updated to use icu3 so will I for
xerces-c2 and then icu2 can be deleted ?


> > Further do you (Andriy) consider sending the update of koi8-u.ucm
> > to IBM OSS for inclusion in next version ?
>
> Yes -- once the files and patches are committed and I can send their URLs to
> IBM.

great.

-- 
Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT
Comment 13 Volker Stolz freebsd_committer freebsd_triage 2004-11-16 08:35:24 UTC
Portmgr, please hold fire wrt the repocopy. The correct solution will be  
to update existing devel/icu!

Volker
Comment 14 Joe Marcus Clarke freebsd_committer freebsd_triage 2004-11-17 05:02:43 UTC
State Changed
From-To: repocopy->open

Moving to vs since he is requestiing the repo-copy to hold. 


Comment 15 Joe Marcus Clarke freebsd_committer freebsd_triage 2004-11-17 05:02:43 UTC
Responsible Changed
From-To: portmgr->vs

Moving to vs since he is requestiing the repo-copy to hold.
Comment 16 stolz 2004-11-17 15:34:02 UTC
Am 15. Nov 2004 um 20:57 CET schrieb Mikhail Teterin:
> I went into this port and came up with the
> 
>  http://virtual-estates.net/port-stuff/icu.diff

Mikhail, can you come up with a patch relative to devel/icu?
You mustn't simply copy over those files since this would spam the
$FreeBSD$ cvs tags unluckily...

Volker
-- 
http://www-i2.informatik.rwth-aachen.de/stolz/ *** PGP *** S/MIME
Comment 17 Mikhail Teterin 2004-11-17 18:03:42 UTC
=D3=C5=D2=C5=C4=C1 17 =CC=C9=D3=D4=CF=D0=C1=C4 2004 10:34, Volker Stolz =F7=
=C9 =CE=C1=D0=C9=D3=C1=CC=C9:
> Am 15. Nov 2004 um 20:57 CET schrieb Mikhail Teterin:
> > I went into this port and came up with the
> >
> >  http://virtual-estates.net/port-stuff/icu.diff
>
> Mikhail, can you come up with a patch relative to devel/icu?
> You mustn't simply copy over those files since this would spam the
> $FreeBSD$ cvs tags unluckily...

Ok, how about the

	http://virtual-estates.net/port-stuff/icu-1-32.diff

This uses the 3.2-d2 (beta). I'm going to commit this soon, because devel/i=
cu=20
is unused and unmaintained. I'm seeing a strange problem with it, though,=20
which may be due to quirks in my own system -- sometimes ThreadsMutex test=
=20
will hang :-( If this is repeatable on other systems, we'll need to patch t=
he=20
test out and ask the thread-people to investigate it.

	-mi
Comment 18 Volker Stolz freebsd_committer freebsd_triage 2004-11-17 18:21:52 UTC
Responsible Changed
From-To: vs->mi

mi's got a patch
Comment 19 Bjoern A. Zeeb 2004-11-23 06:10:37 UTC
On Wed, 17 Nov 2004, Mikhail Teterin wrote:

Hi,

> Ok, how about the
>
> 	http://virtual-estates.net/port-stuff/icu-1-32.diff
>
> This uses the 3.2-d2 (beta). I'm going to commit this soon, because devel/icu

seems 3.2 final got released the last 12 hours or so.

 @see http://oss.software.ibm.com/icu/download/
 ->   http://oss.software.ibm.com/icu/download/3.2/index.html

-- 
Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT
Comment 20 Mikhail.Teterin 2004-11-23 16:03:47 UTC
=D7=A6=D7=D4=CF=D2=CF=CB 23 =CC=C9=D3=D4=CF=D0=C1=C4 2004 01:20, Bjoern A. =
Zeeb =F7=C9 =CE=C1=D0=C9=D3=C1=CC=C9:
>  seems 3.2 final got released the last 12 hours or so.
[...]
>  Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT

Khmm... Following things closely, aren't we? Why shouldn't you be the port'=
s=20
maintainer?

	-mi

P.S. I submitted the Ukrainian patches to ICU/IBM.
Comment 21 Bjoern A. Zeeb 2004-11-23 16:41:07 UTC
On Tue, 23 Nov 2004, Mikhail Teterin wrote:

> ???????? 23 ???????? 2004 01:20, Bjoern A. Zeeb ?? ????????:
> >  seems 3.2 final got released the last 12 hours or so.
> [...]
> >  Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT
>
> Khmm... Following things closely, aren't we? Why shouldn't you be the port's
> maintainer?

I did it mostly for icu2 because xerces-c2 optionally depends on
icu and still had a script running monitoring these sites twice
a day to check for updates ;) removed icu this morning and waitin for
xalan to be released ...

I am not using icu and I will not so it's better that someone
maintains it who actually uses it ? All I need is to get the
dependency right once or twice a year ;)


> P.S. I submitted the Ukrainian patches to ICU/IBM.

great.

-- 
Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT
Comment 22 Andriy Gapon 2005-03-23 17:45:12 UTC
Guys,

a lot of thanks to everybody who did the work on icu (and koi8-u part of
it), but I think you missed one final bit - to close this PR :-)
Everything works great with devel/icu (icu-3.2_1).
Thank you again.

-- 
Andriy Gapon
Comment 23 Florent Thoumie freebsd_committer freebsd_triage 2005-06-06 01:00:04 UTC
State Changed
From-To: open->closed

This has already been taken care of some time ago.