BSD and GNU diff have different semantics for the -b switch. Using --suffix is the same on both. The patch at http://ftp.fortunaty.net/DragonFly/inofficial/patches/Mk::bsd.port.mk-patch-suffix.patch does that and thus make bsd patch work for ports. Fix: http://ftp.fortunaty.net/DragonFly/inofficial/patches/Mk::bsd.port.mk-patch-suffix.patch How-To-Repeat: do make in a port that has patches in files/ with BSD patch as patch programm
Responsible Changed From-To: freebsd-ports-bugs->portmgr bsd.*.mk-related.
Hi, On Wed, Sep 29, 2004 at 07:07:26PM +0000, Andreas Hauser wrote: > BSD and GNU diff have different semantics for the -b switch. > Using --suffix is the same on both. > The patch at > http://ftp.fortunaty.net/DragonFly/inofficial/patches/Mk::bsd.port.mk-patch-suffix.patch > does that and thus make bsd patch work for ports. Huh ? FreeBSD has GNU patch(1), we don't have BSD patch(1). AFAIR OpenBSD has BSD patch or ? If yes, I doubt it supports long options like --suffix, could you please provide more information ? -Kirill
State Changed From-To: open->feedback Asked for more information.
krion wrote @ Fri, 5 Nov 2004 16:56:18 +0100: > Hi, Hoi, > On Wed, Sep 29, 2004 at 07:07:26PM +0000, Andreas Hauser wrote: > > BSD and GNU diff have different semantics for the -b switch. > > Using --suffix is the same on both. > > The patch at > > http://ftp.fortunaty.net/DragonFly/inofficial/patches/Mk::bsd.port.mk-patch-suffix.patch > > does that and thus make bsd patch work for ports. > > Huh ? FreeBSD has GNU patch(1), we don't have BSD patch(1). AFAIR > OpenBSD has BSD patch or ? If yes, I doubt it supports long options > like --suffix, could you please provide more information ? Well, some of us try to avoid GNU software. OpenBSD patch does support --suffix, see http://www.freebsd.org/cgi/man.cgi?query=patch&apropos=0&sektion=0&manpath=OpenBSD+3.4&format=html And for explanation why -b is brocken beyond repair, see the RATIONALE part of: http://www.opengroup.org/onlinepubs/009695399/utilities/patch.html Also consider that FreeBSD might change to BSD patch at some point. Thx, Andy
Hi, On Fri, Nov 05, 2004 at 08:44:54PM -0000, Andreas Hauser wrote: > > Huh ? FreeBSD has GNU patch(1), we don't have BSD patch(1). AFAIR > > OpenBSD has BSD patch or ? If yes, I doubt it supports long options > > like --suffix, could you please provide more information ? > > Well, some of us try to avoid GNU software. > > OpenBSD patch does support --suffix, see > http://www.freebsd.org/cgi/man.cgi?query=patch&apropos=0&sektion=0&manpath=OpenBSD+3.4&format=html > > And for explanation why -b is brocken beyond repair, see the RATIONALE part of: > http://www.opengroup.org/onlinepubs/009695399/utilities/patch.html > > Also consider that FreeBSD might change to BSD patch at some point. Well, IMHO as long as BSD patch(1) does not exist in HEAD, this patch is quite meaningless for us. -Kirill
krion wrote @ Sat, 6 Nov 2004 17:46:10 +0100: > -----BEGIN PGP SIGNED MESSAGE----- > > Hi, > > On Fri, Nov 05, 2004 at 08:44:54PM -0000, Andreas Hauser wrote: > > > Huh ? FreeBSD has GNU patch(1), we don't have BSD patch(1). AFAIR > > > OpenBSD has BSD patch or ? If yes, I doubt it supports long options > > > like --suffix, could you please provide more information ? > > > > Well, some of us try to avoid GNU software. > > > > OpenBSD patch does support --suffix, see > > http://www.freebsd.org/cgi/man.cgi?query=patch&apropos=0&sektion=0&manpath=OpenBSD+3.4&format=html > > > > And for explanation why -b is brocken beyond repair, see the RATIONALE part of: > > http://www.opengroup.org/onlinepubs/009695399/utilities/patch.html > > > > Also consider that FreeBSD might change to BSD patch at some point. > > Well, IMHO as long as BSD patch(1) does not exist in HEAD, this > patch is quite meaningless for us. It does not hurt you either and makes ports more portable. Why not just apply it and help those who need it ? And why assume, we are not part of "us"? Andy
State Changed From-To: feedback->closed Committed, thanks!