Bug 73154 - [Maintainer] www/squid: integrate two vendor patches
Summary: [Maintainer] www/squid: integrate two vendor patches
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sergei Kolobov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-26 09:40 UTC by Thomas-Martin Seck
Modified: 2004-10-27 09:52 UTC (History)
0 users

See Also:


Attachments
file.diff (1.73 KB, patch)
2004-10-26 09:40 UTC, Thomas-Martin Seck
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas-Martin Seck 2004-10-26 09:40:28 UTC
Integrate the following vendor patches:
- document the LDAP helpers' -v option
- correct the implementation of the req_header and resp_header acls
  (the original implementation submitted in squid bug #961 was faulty)
See <http://www.squid-cache.org/Versions/v2/2.5/bugs/> for further details.

Use PREFIX instead of LOCALBASE to include OpenLDAP's headers and libraries.

Bump PORTREVISION.

Fix: Apply this patch:
Comment 1 Thomas-Martin Seck 2004-10-26 14:57:59 UTC
* Thomas-Martin Seck (tmseck@netcologne.de):

> Use PREFIX instead of LOCALBASE to include OpenLDAP's headers and libraries.

I admit I do not know what The Right Thing[tm] is here -- the OpenLDAP
port obeys PREFIX so the port (now) breaks when OpenLDAP is pulled in
as a dependency at build time and PREFIX != LOCALBASE.

I leave it to the committer to decide which variant should be used.
Comment 2 Sergei Kolobov freebsd_committer freebsd_triage 2004-10-27 07:50:24 UTC
On 2004-10-26 at 14:00 +0000, Thomas-Martin Seck wrote:
>  * Thomas-Martin Seck (tmseck@netcologne.de):
>  
>  > Use PREFIX instead of LOCALBASE to include OpenLDAP's headers and libraries.
>  
>  I admit I do not know what The Right Thing[tm] is here -- the OpenLDAP
>  port obeys PREFIX so the port (now) breaks when OpenLDAP is pulled in
>  as a dependency at build time and PREFIX != LOCALBASE.

Using LOCALBASE in this case is The Right Thing.
Please see Porter's Handbook for details.

Sergei
Comment 3 Sergei Kolobov freebsd_committer freebsd_triage 2004-10-27 07:52:33 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sergei

Take.
Comment 4 Thomas-Martin Seck 2004-10-27 08:36:23 UTC
* Sergei Kolobov (sergei@FreeBSD.org):

> Using LOCALBASE in this case is The Right Thing.
> Please see Porter's Handbook for details.

Ok. Could you omit this particular change and commit the update? Thanks!
Comment 5 Sergei Kolobov freebsd_committer freebsd_triage 2004-10-27 09:52:35 UTC
State Changed
From-To: open->closed

Committed, thanks!