under 6.x logjam fails to compile, the attached diff fixes it, but may not work on 4.x
On Wed, 10 Nov 2004 03:54:47 GMT Alfred Perlstein <alfred@FreeBSD.org> wrote: Hi, > Index: Makefile > =================================================================== > RCS file: /home/ncvs/ports/deskutils/logjam/Makefile,v > retrieving revision 1.12 > diff -u -r1.12 Makefile > --- Makefile 7 Nov 2004 22:36:10 -0000 1.12 > +++ Makefile 10 Nov 2004 02:27:52 -0000 > @@ -32,7 +32,7 @@ > USE_GNOME= gnomehack gnomeprefix gtk20 libxml2 intlhack > CONFIGURE_ARGS= --program-transform-name="s/$$//" > CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \ > - LIBS="-L${LOCALBASE}/lib" > + LIBS="-L${LOCALBASE}/lib -lpthread" > Wouldn't it be preferable to use ${PTHREAD_LIBS} instead of hardcoding -lpthread? Cheers, -- Miguel Mendez <flynn@energyhq.es.eu.org> | Extreme ways are back again http://www.energyhq.es.eu.org | Extreme places I didn't know PGP Key: 0xDC8514F1 | I broke everything new again Note: All HTML mail goes to /dev/null | Everything that I'd owned
* Miguel Mendez <flynn@energyhq.es.eu.org> [041110 07:03] wrote: > On Wed, 10 Nov 2004 03:54:47 GMT > Alfred Perlstein <alfred@FreeBSD.org> wrote: > > Hi, > > > Index: Makefile > > =================================================================== > > RCS file: /home/ncvs/ports/deskutils/logjam/Makefile,v > > retrieving revision 1.12 > > diff -u -r1.12 Makefile > > --- Makefile 7 Nov 2004 22:36:10 -0000 1.12 > > +++ Makefile 10 Nov 2004 02:27:52 -0000 > > @@ -32,7 +32,7 @@ > > USE_GNOME= gnomehack gnomeprefix gtk20 libxml2 intlhack > > CONFIGURE_ARGS= --program-transform-name="s/$$//" > > CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \ > > - LIBS="-L${LOCALBASE}/lib" > > + LIBS="-L${LOCALBASE}/lib -lpthread" > > > > Wouldn't it be preferable to use ${PTHREAD_LIBS} instead of hardcoding > -lpthread? I dunno, I'm not so great with ports. ;) -- - Alfred Perlstein
How current is your -CURRENT? I just built logjam port on 4-STABLE and 5-STABLE and at neither environment it needed threading at all. This application just don't have any use of threading. Just an idea - what's content of your /var/db/ports/libxml2/options file? Especially WITHOUT_THREADS knob, true or false? -- Pav Lucistnik <pav@oook.cz> <pav@FreeBSD.org> A two-eyed cyclops would be a bicyclops.
* Pav Lucistnik <pav@FreeBSD.org> [041111 05:02] wrote: > How current is your -CURRENT? I just built logjam port on 4-STABLE and > 5-STABLE and at neither environment it needed threading at all. This > application just don't have any use of threading. > > Just an idea - what's content of your /var/db/ports/libxml2/options > file? Especially WITHOUT_THREADS knob, true or false? ~ % less /var/db/ports/libxml2/options /var/db/ports/libxml2/options: No such file or directory My /var/db/ports is empty. FreeBSD big.endian.org 6.0-CURRENT FreeBSD 6.0-CURRENT #0: Sat Oct 30 19:02:30 PDT 2004 root@big.endian.org:/vol/share/obj/vol/share/src/sys/smpng i386 -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684
Alfred Perlstein pí¹e v èt 11. 11. 2004 v 09:44 -0800: > * Pav Lucistnik <pav@FreeBSD.org> [041111 05:02] wrote: > > How current is your -CURRENT? I just built logjam port on 4-STABLE and > > 5-STABLE and at neither environment it needed threading at all. This > > application just don't have any use of threading. > > > > Just an idea - what's content of your /var/db/ports/libxml2/options > > file? Especially WITHOUT_THREADS knob, true or false? > > ~ % less /var/db/ports/libxml2/options > /var/db/ports/libxml2/options: No such file or directory > > My /var/db/ports is empty. And any chance you defined WITH_THREADS somewhere? make.conf or environment or something? -- Pav Lucistnik <pav@oook.cz> <pav@FreeBSD.org> Mischief managed.
* Pav Lucistnik <pav@FreeBSD.org> [041111 09:48] wrote: > Alfred Perlstein p??e v ?t 11. 11. 2004 v 09:44 -0800: > > > > ~ % less /var/db/ports/libxml2/options > > /var/db/ports/libxml2/options: No such file or directory > > > > My /var/db/ports is empty. > > And any chance you defined WITH_THREADS somewhere? make.conf or > environment or something? not afaik... -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684
Is that PR still actual? -Roman Bogorodskiy
State Changed From-To: open->closed Doesn't seem to be actual anmore.
State Changed From-To: closed->open This is still broken for me: cc -DLOCALEDIR="/usr/X11R6/share/locale" -DPIXMAPDIR="/usr/X11R6/share/gnome/ pixmaps" -I/usr/X11R6/include -I/usr/X11R6/include/xmms -I/usr/X11R6/include/gt k12 -I/usr/local/include/glib12 -I/usr/local/include -I/usr/X11R6/include -O2 -f no-strict-aliasing -pipe -o logjam-xmms-client logjam-xmms-client.o -Wl,-E -L/u sr/X11R6/lib -lgtk12 -lgdk12 -L/usr/local/lib -lgmodule12 -lglib12 -lintl -lXi - lXext -lX11 -lm -lxmms /usr/local/lib/libgthread12.so.3: undefined reference to `pthread_cond_timedwait ' collect2: ld returned 1 exit status gmake[3]: *** [logjam-xmms-client] Error 1 gmake[3]: Leaving directory `/vol/share/ports/deskutils/logjam/work/logjam-4.4.0 /util/xmmsclient' gmake[2]: *** [all-recursive] Error 1 gmake[2]: Leaving directory `/vol/share/ports/deskutils/logjam/work/logjam-4.4.0 /util' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/vol/share/ports/deskutils/logjam/work/logjam-4.4.0 ' gmake: *** [all] Error 2 *** Error code 2 Stop in /vol/share/ports/deskutils/logjam. ** Command failed [exit code 1]: /usr/bin/script -qa /tmp/portupgrade13601.8 mak e ** Fix the problem and try again. This seems to fix it: Index: Makefile =================================================================== RCS file: /home/ncvs/ports/deskutils/logjam/Makefile,v retrieving revision 1.14 diff -u -r1.14 Makefile --- Makefile 12 Mar 2005 10:52:35 -0000 1.14 +++ Makefile 27 Mar 2005 12:07:01 -0000 @@ -33,7 +33,7 @@ USE_GNOME= gnomehack gnomeprefix gtk20 libxml2 intlhack CONFIGURE_ARGS= --program-transform-name="s/$$//" CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" - LIBS="-L${LOCALBASE}/lib" + LIBS="-L${LOCALBASE}/lib ${PTHREAD_LIBS}" .ifndef(WITHOUT_GTKSPELL) LIB_DEPENDS+= gtkspell.0:${PORTSDIR}/textproc/gtkspell2
The port's configure script should get '-pthread' as a link argument from pkg-config: sam@dirk sam> pkg-config --libs gthread-2.0 -pthread -L/usr/local/lib -lgthread-2.0 -lglib-2.0 -liconv That is sourced from /usr/local/libdata/pkgconfig/gthread-2.0.pc. What does that command show for you, Alfred? Could you try force upgrading glib-2.0 to see if that helps?
Responsible Changed From-To: freebsd-ports-bugs->novel I'll take it.
State Changed From-To: open->feedback Are you building it with WITH_XMMS defined?
State Changed From-To: feedback->closed I've committed your fix, thanks! Sorry for the delay.