Bug 75119 - [MAINTAINER] graphics/cal3d: fix plist
Summary: [MAINTAINER] graphics/cal3d: fix plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-15 16:00 UTC by Stefan Walter
Modified: 2004-12-15 19:05 UTC (History)
0 users

See Also:


Attachments
cal3d-0.9.1.patch (339 bytes, patch)
2004-12-15 16:00 UTC, Stefan Walter
no flags Details | Diff
cal3d-pkgconfig.patch (334 bytes, patch)
2004-12-15 18:45 UTC, Stefan Walter
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Walter 2004-12-15 16:00:46 UTC
Add missing directory entry to plist.

Generated with FreeBSD Port Tools 0.63
Comment 1 Greg Lewis freebsd_committer freebsd_triage 2004-12-15 17:30:58 UTC
State Changed
From-To: open->feedback

This patch appears to be incorrect.  The libdata/pkgconfig directory is 
used by a lot of ports, so assuming you can unequivocally remove it is 
incorrect and yields an error such as: 

pkg_delete: unable to completely remove directory '/usr/local/libdata/pkgconfig' 
pkg_delete: couldn't entirely delete package (perhaps the packing list is incorrectly specified?) 

when applied. 

A better patch would be to rely on pkgconfig which creates and deletes 
this directory.  E.g. add 

USE_GNOME=	pkgconfig 

to the Makefile.  What do you think?
Comment 2 Stefan Walter 2004-12-15 18:45:01 UTC
Hi,

Greg Lewis, 15.12.04, 18:35h CET:

> This patch appears to be incorrect.  The libdata/pkgconfig directory is
> used by a lot of ports, so assuming you can unequivocally remove it is
> incorrect and yields an error such as:
> 
> pkg_delete: unable to completely remove directory '/usr/local/libdata/pkgconfig'
> pkg_delete: couldn't entirely delete package (perhaps the packing list is incorrectly specified?)
> 
> when applied.

Yes, I was aware of that, but it seemed like the best thing to do to me.

> A better patch would be to rely on pkgconfig which creates and deletes
> this directory.  E.g. add
> 
> USE_GNOME=	pkgconfig
> 
> to the Makefile.  What do you think?

I didn't know about this option at all, and I cannot currently test its
functionality here because I do not want to deinstall pkgconfig and all
the packages that depend on it. ;) Nevertheless it looks reasonable and I
assume that you're right, so I've attached a corrected patch.

Thanks,
Stefan, who needs a larger hard drive to set up a jail and more time for
testing ports stuff...
Comment 3 Greg Lewis freebsd_committer freebsd_triage 2004-12-15 19:04:42 UTC
State Changed
From-To: feedback->closed

Thanks for the feedback!  I committed the USE_GNOME change.