Bug 75451 - Update port: databases/freetds change to 0.62.4
Summary: Update port: databases/freetds change to 0.62.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Volker Stolz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-12-24 02:50 UTC by Marcus Grando
Modified: 2005-02-14 12:06 UTC (History)
1 user (show)

See Also:


Attachments
freetds.patch (1.36 KB, patch)
2004-12-24 02:50 UTC, Marcus Grando
no flags Details | Diff
freetds.patch (1.84 KB, patch)
2005-01-11 18:34 UTC, Marcus Grando
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Grando 2004-12-24 02:50:17 UTC
Update port: databases/freetds change to 0.62.4

- rm files/patch-aclocal-m4
- rm files/patch-configure
- rmdir files
Comment 1 Volker Stolz freebsd_committer freebsd_triage 2004-12-27 11:17:42 UTC
Dear maintainer, please review the proposed patch!

Volker
Comment 2 Volker Stolz freebsd_committer freebsd_triage 2004-12-27 11:18:01 UTC
State Changed
From-To: open->feedback

Forwarded PR to maintainer
Comment 3 Alex Kiesel 2004-12-27 12:09:36 UTC
On Mon, 2004-12-27 at 12:17 +0100, Volker Stolz wrote:
> Dear maintainer, please review the proposed patch!

Hi Marcus,

thank you for your effort patching the Makefile for FreeTDS. The
FreeTDS-Team is currently about to release the next version 0.63 for
which I have already created a patch. Therefore, I don't think it's
still neccessary now to upgrade this minor version.

Furthermore, the patch you submitted leaves the port with a broken
plist.

Regards,
-Alex
Comment 4 Marcus Grando 2004-12-27 13:30:44 UTC
Ok, this new patch correct this.

Memory leak and other problems i believe that they are important to 
apply patch.  But maintainer that it decides.

Regards

--begin patch--
diff -ruN freetds.old/Makefile freetds/Makefile
--- freetds.old/Makefile	Thu Jul 29 07:42:56 2004
+++ freetds/Makefile	Mon Dec 27 11:09:36 2004
@@ -5,7 +5,7 @@
  # $FreeBSD: ports/databases/freetds/Makefile,v 1.40 2004/07/29 
10:42:56 pav Exp $

  PORTNAME=	freetds
-PORTVERSION=	0.62.3
+PORTVERSION=	0.62.4
  CATEGORIES=	databases
  MASTER_SITES=	${MASTER_SITE_SUNSITE}
  MASTER_SITE_SUBDIR=	ALPHA/freetds/stable
diff -ruN freetds.old/distinfo freetds/distinfo
--- freetds.old/distinfo	Mon Apr 12 02:55:13 2004
+++ freetds/distinfo	Mon Dec 27 11:09:36 2004
@@ -1,2 +1,2 @@
-MD5 (freetds-0.62.3.tar.gz) = 6091902314a9317f0de2bb156151bc3a
-SIZE (freetds-0.62.3.tar.gz) = 1186704
+MD5 (freetds-0.62.4.tar.gz) = 09695686e7aa2eaf963c2ebe30c7ae74
+SIZE (freetds-0.62.4.tar.gz) = 1302666
diff -ruN freetds.old/files/patch-configure freetds/files/patch-configure
--- freetds.old/files/patch-configure	Thu Sep 19 17:33:32 2002
+++ freetds/files/patch-configure	Wed Dec 31 21:00:00 1969
@@ -1,12 +0,0 @@
---- configure.orig	Thu Sep 12 01:35:52 2002
-+++ configure	Fri Sep 13 20:20:20 2002
-@@ -2241,7 +2241,8 @@
-
-
- # This can be used to rebuild libtool when needed
--LIBTOOL_DEPS="$ac_aux_dir/ltconfig $ac_aux_dir/ltmain.sh 
$ac_aux_dir/ltcf-c.sh"
-+LIBTOOL_DEPS="$ac_aux_dir/ltmain.sh"
-+$ac_aux_dir/ltconfig $LIBTOOL_DEPS
-
- # Always use our own libtool.
- LIBTOOL='$(SHELL) $(top_builddir)/libtool'
diff -ruN freetds.old/pkg-plist freetds/pkg-plist
--- freetds.old/pkg-plist	Mon Apr 12 02:55:13 2004
+++ freetds/pkg-plist	Mon Dec 27 11:17:53 2004
@@ -22,15 +22,19 @@
  include/tdssrv.h
  include/tdsver.h
  lib/libct.a
+lib/libct.la
  lib/libct.so
  lib/libct.so.2
  lib/libsybdb.a
+lib/libsybdb.la
  lib/libsybdb.so
  lib/libsybdb.so.4
  lib/libtds.a
+lib/libtds.la
  lib/libtds.so
  lib/libtds.so.3
  lib/libtdssrv.a
+lib/libtdssrv.la
  lib/libtdssrv.so
  lib/libtdssrv.so.1
  %%ODBC%%lib/libtdsodbc.so.0
--end patch--

Alex Kiesel wrote:
> On Mon, 2004-12-27 at 12:17 +0100, Volker Stolz wrote:
> 
>>Dear maintainer, please review the proposed patch!
> 
> 
> Hi Marcus,
> 
> thank you for your effort patching the Makefile for FreeTDS. The
> FreeTDS-Team is currently about to release the next version 0.63 for
> which I have already created a patch. Therefore, I don't think it's
> still neccessary now to upgrade this minor version.
> 
> Furthermore, the patch you submitted leaves the port with a broken
> plist.
> 
> Regards,
> -Alex

-- 
Marcus Grando
Grupos Internet S/A
marcus(at)corp.grupos.com.br
Comment 5 Alex Kiesel 2004-12-28 10:23:53 UTC
On Mon, 2004-12-27 at 11:30 -0200, Marcus Grando wrote:
> Ok, this new patch correct this.
> 
> Memory leak and other problems i believe that they are important to 
> apply patch.  But maintainer that it decides.

Last patch has my approval. Thanks for your patience.

Regards,
-Alex
Comment 6 Sergey Matveychuk freebsd_committer freebsd_triage 2004-12-30 19:33:10 UTC
State Changed
From-To: feedback->open

approvement has gotten
Comment 7 Volker Stolz freebsd_committer freebsd_triage 2005-01-11 15:58:55 UTC
Am 27. Dec 2004 um 14:30 CET schrieb Marcus Grando:
> Ok, this new patch correct this.
> 
> Memory leak and other problems i believe that they are important to 
> apply patch.  But maintainer that it decides.
> 
> Regards
> 
> --begin patch--
> diff -ruN freetds.old/Makefile freetds/Makefile
> --- freetds.old/Makefile	Thu Jul 29 07:42:56 2004
> +++ freetds/Makefile	Mon Dec 27 11:09:36 2004
> @@ -5,7 +5,7 @@
>  # $FreeBSD: ports/databases/freetds/Makefile,v 1.40 2004/07/29 
> 10:42:56 pav Exp $

The patch contains wrapped lines. Could you please submit the patch
as an attachment in a way that it doesn't get broken?

Cheers,
  Volker
-- 
http://www-i2.informatik.rwth-aachen.de/stolz/ *** PGP *** S/MIME
Comment 8 Marcus Grando 2005-01-11 18:34:52 UTC
Attached...

Regards

Volker Stolz wrote:
> Am 27. Dec 2004 um 14:30 CET schrieb Marcus Grando:
> 
>>Ok, this new patch correct this.
>>
>>Memory leak and other problems i believe that they are important to 
>>apply patch.  But maintainer that it decides.
>>
>>Regards
>>
>>--begin patch--
>>diff -ruN freetds.old/Makefile freetds/Makefile
>>--- freetds.old/Makefile	Thu Jul 29 07:42:56 2004
>>+++ freetds/Makefile	Mon Dec 27 11:09:36 2004
>>@@ -5,7 +5,7 @@
>> # $FreeBSD: ports/databases/freetds/Makefile,v 1.40 2004/07/29 
>>10:42:56 pav Exp $
> 
> 
> The patch contains wrapped lines. Could you please submit the patch
> as an attachment in a way that it doesn't get broken?
> 
> Cheers,
>   Volker

-- 
Marcus Grando
Grupos Internet S/A
marcus(at)corp.grupos.com.br
Comment 9 Volker Stolz freebsd_committer freebsd_triage 2005-01-18 13:39:30 UTC
Hm, to me the included libtool version looks like 1.5. Should I simply
raise this appropriately?
-- 
http://www-i2.informatik.rwth-aachen.de/stolz/ *** PGP *** S/MIME
Comment 10 Marcus Grando 2005-01-18 14:00:58 UTC
Please, change-it.

I test, and work correctly.

Regards

Volker Stolz wrote:
> Hm, to me the included libtool version looks like 1.5. Should I simply
> raise this appropriately?

-- 
Marcus Grando
Grupos Internet S/A
marcus(at)corp.grupos.com.br
Comment 11 Volker Stolz freebsd_committer freebsd_triage 2005-02-14 10:44:07 UTC
Is there any reason for installing the .la-files? otherwise, this could be  
avoided by a simple
USE_LIBTOOL instead of USE_INC_LIBTOOL.

Volker
Comment 12 Volker Stolz freebsd_committer freebsd_triage 2005-02-14 10:45:45 UTC
State Changed
From-To: open->feedback

Inquire about .la-files 


Comment 13 Volker Stolz freebsd_committer freebsd_triage 2005-02-14 10:45:45 UTC
Responsible Changed
From-To: freebsd-ports-bugs->vs

I'm working on this
Comment 14 Alex Kiesel 2005-02-14 11:35:37 UTC
On Mon, 2005-02-14 at 11:44 +0100, Volker Stolz wrote:
> Is there any reason for installing the .la-files? otherwise, this could be  
> avoided by a simple
> USE_LIBTOOL instead of USE_INC_LIBTOOL.

No, there's no reason. In fact, I wondered why they were installed. I
came to a point in the documentation where this is explained and changed
it for the (upcoming) version. 

Please change it.

Alex
Comment 15 Volker Stolz freebsd_committer freebsd_triage 2005-02-14 12:06:27 UTC
State Changed
From-To: feedback->closed

Committed with modifications as discussed. Thanks for your 
submission!