PINE requires ispell as a runtime pre-requisite per RUN_DEPEND. This should be optional, as some of us don't like ispell (prefer aspell, or don't use spell checkers). Fix: Add WITH_ISPELL tweak. Patch included below. How-To-Repeat: n/a
Responsible Changed From-To: freebsd-ports-bugs->dougb Over to maintainer.
State Changed From-To: open->suspended
State Changed From-To: suspended->analyzed Slip of the fingers there, sorry. Simply saying, "it should be optional" is not sufficient. The way that PINE builds its menus is dependent on either having a speller present, or extensive patching of the sources to remove the menu options. After careful deliberation, I chose to require a speller both because it's a useful feature and because it makes maintaining the port dramatically easier. If you can come up with patches that either give the user a choice of which speller to install, I'll gladly consider them as I think this would be a useful addition. Otherwise, I'll close this PR in 30 days. Doug
The patch I provided we have been running with here for weeks now, without any complaints. We have quite a few users who rely heavily on pine and are more familiar with it than I am (I am a mutt user), and I have heard no complaints of any kind. Testing the patch + PINE myself, I find that ^T during the Composition stage does in fact fail with "Alternate speller terminated abnormally (255)", but this can be fixed via the "speller" configuration option. aspell does provide compatibility for ispell emulation (by checking argv[0] to see if it's ispell; a hardlink would work), but testing this results in a different error (Alternate speller terminated abnormally (1)). This is something I could research. Other than that, I see no other place where PINE would _require_ ispell to "build a menuing system". I see places where the spell checker simply _does not function_, and rightfully so. This does not look to impact PINE as an Email client in any way, from what I can tell. Can you provide me some examples of where PINE does not work as expected, such as building menus, when ispell is missing? -- | Jeremy Chadwick jdc at parodius.com | | Parodius Networking http://www.parodius.com/ | | UNIX Systems Administrator Mountain View, CA, USA | | Making life hard for others since 1977. | On Wed, Jan 19, 2005 at 07:51:14PM +0000, Doug Barton wrote: > Synopsis: pine4 dependant upon ispell (should be optional) > > State-Changed-From-To: suspended->analyzed > State-Changed-By: dougb > State-Changed-When: Wed Jan 19 19:47:46 GMT 2005 > State-Changed-Why: > > Slip of the fingers there, sorry. > > Simply saying, "it should be optional" is not sufficient. The way that > PINE builds its menus is dependent on either having a speller present, > or extensive patching of the sources to remove the menu options. After > careful deliberation, I chose to require a speller both because it's > a useful feature and because it makes maintaining the port dramatically > easier. > > If you can come up with patches that either give the user a choice > of which speller to install, I'll gladly consider them as I think this > would be a useful addition. Otherwise, I'll close this PR in 30 days. > > Doug > > http://www.freebsd.org/cgi/query-pr.cgi?pr=75569
State Changed From-To: analyzed->closed I added a knob for this, on by default instead of off by default.