Upgrade port graphics/lcms from revision 1.13 to 1.14, it's the first version upgrade diff I submit, please read carefully! Added files: none, but I added one in the diff: NOTES_update_to_1.14, this file should NOT go into cvs of course. I summarized my thoughts and open questions there, please look at it, but don't commit that one to cvs. Removed files: files/patch-src::cmscgats.c files/patch-src::cmsio1.c I looked through the patches to see which ones were submitted to the lcms sourcecode itself, these two patches are now not needed anymore. Please take a look at the configure args in the Makefile, IMHO --without-jpeg and --without-tiff are not required anymore, please verfiy!! The updated port downloads/patches/configures/installs fine for me. Find the patch at: ftp://ftp.g-system.at/people/raphael/tmp/lcms_port_update.diff
Mikhail, could you enlighten us about the --without-tiff/jpeg? I couldn't find anything on why it's disabled... Volker
> Mikhail, could you enlighten us about the --without-tiff/jpeg? > I couldn't find anything on why it's disabled... As far as I remember, the tiff and jpeg were only needed for the simple samples/tools, that come with the lcms library. The port never built nor installed those bits anyway. The upgrade should remove PORTREVISION and, Raphael is right, list the man-pages in the Makefile. -mi To: freebsd-gnats-submit@freebsd.org, raphael-langerhorst@gmx.at, mi@freebsd.org Subject: Re: ports/76116: PORT UPDATE: graphics/lcms (with PATCH) From: "Volker Stolz" <vs@freebsd.org> Date: Wed, 12 Jan 2005 09:54:26 +0100 Mikhail, could you enlighten us about the --without-tiff/jpeg? I couldn't find anything on why it's disabled... Volker
On Wednesday 12 January 2005 17:38, Mikhail Teterin wrote: > > Mikhail, could you enlighten us about the --without-tiff/jpeg? > > I couldn't find anything on why it's disabled... > > As far as I remember, the tiff and jpeg were only needed for the > simple samples/tools, that come with the lcms library. The port > never built nor installed those bits anyway. > > The upgrade should remove PORTREVISION and, Raphael is right, > list the man-pages in the Makefile. > > -mi > > To: freebsd-gnats-submit@freebsd.org, raphael-langerhorst@gmx.at, > mi@freebsd.org > Subject: Re: ports/76116: PORT UPDATE: graphics/lcms (with PATCH) > From: "Volker Stolz" <vs@freebsd.org> > Date: Wed, 12 Jan 2005 09:54:26 +0100 > > Mikhail, could you enlighten us about the --without-tiff/jpeg? > I couldn't find anything on why it's disabled... > > Volker Hi all, how is the lcms update going, do you need any more input from me? Regards, -- Raphael Langerhorst, JID: raphael@jabber.pilgerer.de G System, The Evolving Universe - http://www.g-system.at
On Sat, Jan 15, 2005 at 05:00:53PM +0100, Raphael Langerhorst wrote: > On Wednesday 12 January 2005 17:38, Mikhail Teterin wrote: > > > Mikhail, could you enlighten us about the --without-tiff/jpeg? > > > I couldn't find anything on why it's disabled... > > > > As far as I remember, the tiff and jpeg were only needed for the > > simple samples/tools, that come with the lcms library. The port > > never built nor installed those bits anyway. > > > > The upgrade should remove PORTREVISION and, Raphael is right, > > list the man-pages in the Makefile. It looks like the man-pages is part of the jpeg/tiff-issue, so they don't get build/installed, thus no need to list them. Is this right, Raphael? Volker -- http://www-i2.informatik.rwth-aachen.de/stolz/ *** PGP *** S/MIME
On Monday 17 January 2005 10:30, Volker Stolz wrote: > On Sat, Jan 15, 2005 at 05:00:53PM +0100, Raphael Langerhorst wrote: > > On Wednesday 12 January 2005 17:38, Mikhail Teterin wrote: > > > > Mikhail, could you enlighten us about the > > > > --without-tiff/jpeg? I couldn't find anything on why it's > > > > disabled... > > > > > > As far as I remember, the tiff and jpeg were only needed for > > > the simple samples/tools, that come with the lcms library. The > > > port never built nor installed those bits anyway. > > > > > > The upgrade should remove PORTREVISION and, Raphael is right, > > > list the man-pages in the Makefile. > > It looks like the man-pages is part of the jpeg/tiff-issue, so they > don't get build/installed, thus no need to list them. Is this > right, Raphael? > > Volker I have now configured --without-jpeg --without-tiff and have the following installed files: [eagle] ~/tmp/lcms/lcms-1.14> find ../install/ ../install/ ../install/lib ../install/lib/liblcms.so.1 ../install/lib/liblcms.so ../install/lib/liblcms.la ../install/lib/liblcms.a ../install/lib/pkgconfig ../install/lib/pkgconfig/lcms.pc ../install/bin ../install/bin/icctrans ../install/bin/wtpt ../install/bin/icc2ps ../install/bin/icclink ../install/man ../install/man/man1 ../install/man/man1/jpegicc.1 ../install/man/man1/tifficc.1 ../install/man/man1/wtpt.1 ../install/man/man1/icc2ps.1 ../install/man/man1/icclink.1 ../install/include ../install/include/icc34.h ../install/include/lcms.h [eagle] ~/tmp/lcms/lcms-1.14> So the MAN pages DO get installed (and should be listed in the Makefile). Please adapt the Makefile, pkg-list, ... as needed, I'm not very used to port modifications (yet). And it would take another few days until I find the time to do it cleanly. Thanks!! -- Raphael Langerhorst, JID: raphael@jabber.pilgerer.de G System, The Evolving Universe - http://www.g-system.at
On Thu, Jan 20, 2005 at 09:52:59AM +0100, Raphael Langerhorst wrote: > > > > The upgrade should remove PORTREVISION and, Raphael is right, > > > > list the man-pages in the Makefile. > > > > It looks like the man-pages is part of the jpeg/tiff-issue, so they > > don't get build/installed, thus no need to list them. Is this > > right, Raphael? > > > > Volker > > I have now configured --without-jpeg --without-tiff and have the > following installed files: > > [eagle] ~/tmp/lcms/lcms-1.14> find ../install/ > ../install/ > ../install/lib > ../install/lib/liblcms.so.1 > ../install/lib/liblcms.so > ../install/lib/liblcms.la > ../install/lib/liblcms.a > ../install/lib/pkgconfig > ../install/lib/pkgconfig/lcms.pc > ../install/bin > ../install/bin/icctrans > ../install/bin/wtpt > ../install/bin/icc2ps > ../install/bin/icclink > ../install/man > ../install/man/man1 > ../install/man/man1/jpegicc.1 > ../install/man/man1/tifficc.1 > ../install/man/man1/wtpt.1 > ../install/man/man1/icc2ps.1 > ../install/man/man1/icclink.1 > ../install/include > ../install/include/icc34.h > ../install/include/lcms.h > [eagle] ~/tmp/lcms/lcms-1.14> > > So the MAN pages DO get installed (and should be listed in the > Makefile). Please adapt the Makefile, pkg-list, ... as needed, I'm > not very used to port modifications (yet). And it would take another > few days until I find the time to do it cleanly. Are you sure that those were newly installed and are not left-overs from your previous attemp with --with-jpeg/tiff? Please deinstall the port, remove the man pages by hand and install the port again. -- http://www-i2.informatik.rwth-aachen.de/stolz/ *** PGP *** S/MIME
On Thursday 20 January 2005 11:59, Volker Stolz wrote: > On Thu, Jan 20, 2005 at 09:52:59AM +0100, Raphael Langerhorst wrote: > > > > > The upgrade should remove PORTREVISION and, Raphael is > > > > > right, list the man-pages in the Makefile. > > > > > > It looks like the man-pages is part of the jpeg/tiff-issue, so > > > they don't get build/installed, thus no need to list them. Is > > > this right, Raphael? > > > > > > Volker > > > > I have now configured --without-jpeg --without-tiff and have the > > following installed files: > > > > [eagle] ~/tmp/lcms/lcms-1.14> find ../install/ > > ../install/ > > ../install/lib > > ../install/lib/liblcms.so.1 > > ../install/lib/liblcms.so > > ../install/lib/liblcms.la > > ../install/lib/liblcms.a > > ../install/lib/pkgconfig > > ../install/lib/pkgconfig/lcms.pc > > ../install/bin > > ../install/bin/icctrans > > ../install/bin/wtpt > > ../install/bin/icc2ps > > ../install/bin/icclink > > ../install/man > > ../install/man/man1 > > ../install/man/man1/jpegicc.1 > > ../install/man/man1/tifficc.1 > > ../install/man/man1/wtpt.1 > > ../install/man/man1/icc2ps.1 > > ../install/man/man1/icclink.1 > > ../install/include > > ../install/include/icc34.h > > ../install/include/lcms.h > > [eagle] ~/tmp/lcms/lcms-1.14> > > > > So the MAN pages DO get installed (and should be listed in the > > Makefile). Please adapt the Makefile, pkg-list, ... as needed, > > I'm not very used to port modifications (yet). And it would take > > another few days until I find the time to do it cleanly. > > Are you sure that those were newly installed and are not left-overs > from your previous attemp with --with-jpeg/tiff? Please deinstall > the port, remove the man pages by hand and install the port again. I used a custom/temporary install dir. I just removed it all again, started from scratch (so no leftover obj files or install files or Makefiles, ...). Configured without-jpeg and withoug-tiff and installed into /home/raphael/tmp/lcms/install. Find still gives the same list of files. I used: tar -xzf lcms... cd lcms... ./configure --prefix=/home/raphael/tmp/lcms/install --without-jpeg --without-tiff gmake gmake install find ../install (so I didn't use the ports configuration). As far as I can see the man pages got install (again). I hope this info is useful for you. Let me know if you need another tests, -- Raphael Langerhorst, JID: raphael@jabber.pilgerer.de G System, The Evolving Universe - http://www.g-system.at
Am 20. Jan 2005 um 14:55 CET schrieb Raphael Langerhorst: > > (so I didn't use the ports configuration). As far as I can see the man > pages got install (again). I hope this info is useful for you. Let me > know if you need another tests, Please try again *with* the port-infrastructure :) find /usr/local/man -name "*icc*" shows no relevant match, neither do I see any installation in the output. Volker -- http://www-i2.informatik.rwth-aachen.de/stolz/ *** PGP *** S/MIME
ÞÅÔ×ÅÒ 20 Ó¦ÞÅÎØ 2005 09:02, Volker Stolz ÷É ÎÁÐÉÓÁÌÉ: > Am 20. Jan 2005 um 14:55 CET schrieb Raphael Langerhorst: > > (so I didn't use the ports configuration). As far as I can see the man > > pages got install (again). I hope this info is useful for you. Let me > > know if you need another tests, > > Please try again *with* the port-infrastructure :) > find /usr/local/man -name "*icc*" shows no relevant match, neither do > I see any installation in the output. At any rate, the right way would be to patch the software to not install the man-pages for the non-installed utilities, instead of adding these 'phantom' man-pages to the plist :-) That said, maybe, these utilities are actually useful and worth adding to the standard install of the port (complete with the LIB_DEPENDS on jpeg and tiff)? -mi
Am 20. Jan 2005 um 16:54 CET schrieb Mikhail Teterin: > At any rate, the right way would be to patch the software to not install the > man-pages for the non-installed utilities, instead of adding these 'phantom' > man-pages to the plist :-) I think this is a non-issue, since it doesn't look like any manpages are installed nor listed. > That said, maybe, these utilities are actually useful and worth adding to the > standard install of the port (complete with the LIB_DEPENDS on jpeg and > tiff)? The conclusion was that these are sample applications which are not useful utilities per se and thus not provided as binaries but only as .c-files in $EXAMPLESDIR. Volker -- http://www-i2.informatik.rwth-aachen.de/stolz/ *** PGP *** S/MIME
ÞÅÔ×ÅÒ 20 Ó¦ÞÅÎØ 2005 11:41, Volker Stolz ÷É ÎÁÐÉÓÁÌÉ: > The conclusion was that these are sample applications which are not useful > utilities per se and thus not provided as binaries but only as .c-files > in $EXAMPLESDIR. Yes, this was my opinion too, but I am not a "graphics person", so I am not sure... Maybe, if the author bothered with the man-pages, these utilities are, actually, worth something to those, who know, what they do? -mi
On Thursday 20 January 2005 15:02, Volker Stolz wrote: > Am 20. Jan 2005 um 14:55 CET schrieb Raphael Langerhorst: > > (so I didn't use the ports configuration). As far as I can see > > the man pages got install (again). I hope this info is useful for > > you. Let me know if you need another tests, > > Please try again *with* the port-infrastructure :) > find /usr/local/man -name "*icc*" shows no relevant match, neither > do I see any installation in the output. > > Volker Hi, just took the time to check on this issue. I now patched the graphics/lcms port with my own patch and installed it (WITHOUT the additional configure arguments, I took the patch AS IS, this means that --without-jpeg and --without-tiff were not added to the configure args). Even though I used the patch the way it was, I didn't get any man pages installed either (??) although I have no idea why. But they are obviously not there. This means that they probably don't need to be listed. The question would be of course: if the man pages get installed when building & installing lcms manually, why are they NOT installed with the port? Or do they get installed into a different location? I didn't see them installing in the install output either... (in principle this shows that the upgrade is ok, the man-page / no-manpage question probably doesn't have to do with the version change as such) -- Raphael Langerhorst, JID: raphael@jabber.pilgerer.de G System, The Evolving Universe - http://www.g-system.at
ÞÅÔ×ÅÒ 20 Ó¦ÞÅÎØ 2005 15:36, Raphael Langerhorst ÷É ÎÁÐÉÓÁÌÉ: > just took the time to check on this issue. I now patched the > graphics/lcms port with my own patch and installed it (WITHOUT the > additional configure arguments, I took the patch AS IS, this means > that --without-jpeg and --without-tiff were not added to the > configure args). > > Even though I used the patch the way it was, I didn't get any man > pages installed either (??) although I have no idea why. But they are > obviously not there. This means that they probably don't need to be > listed. > > The question would be of course: if the man pages get installed when > building & installing lcms manually, why are they NOT installed with > the port? Or do they get installed into a different location? I > didn't see them installing in the install output either... > > (in principle this shows that the upgrade is ok, the man-page / > no-manpage question probably doesn't have to do with the version > change as such) Check out the post-patch target in the port's Makefile -- and what it does to the list of SUBDIRS in the vendor's Makefile.in -mi
State Changed From-To: open->patched I just committed the trivial update to 1.14. We'll close this one entirely once we sorted out the tiff/jpeg-ponderations.
Responsible Changed From-To: freebsd-ports-bugs->stas Maintainer is a committer.
stas 2006-10-08 17:07:23 UTC FreeBSD ports repository Modified files: graphics/lcms Makefile pkg-plist Log: - Add KNOBS to build supplimentary utilities - Change my email PR: ports/76116 (based on) Suggested by: Raphael Langerhorst <raphael-langerhorst@gmx.at> Approved by: sem (mentor) Revision Changes Path 1.24 +37 -3 ports/graphics/lcms/Makefile 1.11 +3 -0 ports/graphics/lcms/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: patched->closed Committed. Thanks!