Bug 76358 - xlockmore PAM support
Summary: xlockmore PAM support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Volker Stolz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-17 17:00 UTC by Yuri Bushmelev
Modified: 2005-11-29 18:25 UTC (History)
1 user (show)

See Also:


Attachments
xlockmore-pam.diff (2.38 KB, patch)
2005-01-17 17:00 UTC, Yuri Bushmelev
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Bushmelev 2005-01-17 17:00:40 UTC
	xlockmore-5.14.1 port don't have option to enable PAM support with
	make args (e.g. make WITH_PAM=yes). Here is patch to add it.
	Also added option for low CPU usage modes (WITH_NICE_ONLY).

How-To-Repeat: 	N/A
Comment 1 Volker Stolz freebsd_committer freebsd_triage 2005-02-01 09:29:48 UTC
Responsible Changed
From-To: freebsd-ports-bugs->vs

I'll handle this
Comment 2 Yuri Bushmelev 2005-02-01 14:12:12 UTC
On Tue, 1 Feb 2005 10:33:30 +0100
Volker Stolz <vs@FreeBSD.org> wrote:

> The BAD_PAM-wibble no longer seems to be necessary. Can you please
> confirm that the following works as expected?

Here is the same trouble. Look at xlock/xlock.c:3288

               (void) setuid(ruid);

After commenting out this string all works fine.
I use BAD_PAM to lock out it. If it is deprecated, then we needed to
find better way to do it :)
Simple way - replace setuid with seteuid. But it's not right way (imho).

Xlock must use this setuid only if root rights not more needed.
In case of USE_PAM, root rights needed in passwd.c for PAM.

I think that we need talk with developer. But my english is not so good :)

BTW, you can send me letter in german. It was my first foreign language :)

-- 
Yuri Y. Bushmelev                  Phone/Fax:  +7 (8422) 414559
System Manager                        WWW: http://www.simcom.ru
ISP "Simbirsk Communications"            E-mail: info@simcom.ru
Comment 3 Volker Stolz freebsd_committer freebsd_triage 2005-10-28 15:42:47 UTC
State Changed
From-To: open->feedback

Any progress or recommendation for action on this one?
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2005-11-01 18:15:51 UTC
Can you update patches in ports/76358 to work on latest xlockmore
(5.20.1)? They don't apply anymore.

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

And now something completely different.
Comment 5 Florent Thoumie freebsd_committer freebsd_triage 2005-11-29 18:25:03 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!