Bug 76522 - print/cups-base removes etc/cups/certs directory
Summary: print/cups-base removes etc/cups/certs directory
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Volker Stolz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-01-21 05:10 UTC by TsurutaniNaoki
Modified: 2005-01-28 10:44 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description TsurutaniNaoki 2005-01-21 05:10:32 UTC
	print/cups-base always remove etc/cups/certs directory when it is
	not empty.

Fix: 

remove "rm -rf" line from pkg-plist if it does not bring any other trouble.
	
	--- /usr/ports/print/cups-base/pkg-plist.orig        Fri Dec 31 04:32:51 2004
	+++ /usr/ports/print/cups-base/pkg-plist  Fri Jan 21 13:56:54 2005
	@@ -1,6 +1,5 @@
	 @exec /bin/echo "===>" Stopping cupsd ...
	 @exec /usr/bin/killall cupsd || true
	-@exec /bin/rm -fr %D/etc/cups/certs/* 2>/dev/null || true
	 bin/cups-config
	 @unexec if cmp -s %D/etc/cups/classes.conf.N %D/etc/cups/classes.conf; then rm -f %D/etc/cups/classes.conf; fi
	 etc/cups/classes.conf.N
How-To-Repeat: 	everytime when portupgrade print/cups-base.
Comment 1 Volker Stolz freebsd_committer freebsd_triage 2005-01-21 10:49:43 UTC
Dear maintainer, please look into this issue!

Volker
Comment 2 Volker Stolz freebsd_committer freebsd_triage 2005-01-21 10:52:21 UTC
State Changed
From-To: open->feedback

Forwarded PR to maintainer. 
Indeed, removing all certs surely looks like a bad idea.
Comment 3 TsurutaniNaoki 2005-01-28 04:06:26 UTC
It seemes to be fixed by Maintainer with the fix about PR ports/76337.
Thanks!
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2005-01-28 05:35:57 UTC
State Changed
From-To: feedback->closed

A fix from the maintainer is available in ports/76337.
Comment 5 Volker Stolz freebsd_committer freebsd_triage 2005-01-28 07:52:24 UTC
On Fri, Jan 28, 2005 at 01:06:26PM +0900, Tsurutani Naoki wrote:
> It seemes to be fixed by Maintainer with the fix about PR ports/76337.

Hm, I don't think so. The "rm -rf" is still there.

Volker
-- 
http://www-i2.informatik.rwth-aachen.de/stolz/ *** PGP *** S/MIME
Comment 6 TsurutaniNaoki 2005-01-28 08:11:44 UTC
Volker Stolz <vs@freebsd.org> wrote:

> On Fri, Jan 28, 2005 at 01:06:26PM +0900, Tsurutani Naoki wrote:
> > It seemes to be fixed by Maintainer with the fix about PR ports/76337.
> 
> Hm, I don't think so. The "rm -rf" is still there.

That's right. Entry still remains in Makefile.
Please fix Makefile, please.

--- /usr/ports/print/cups-base/Makefile.orig    Fri Jan 28 04:32:58 2005
+++ /usr/ports/print/cups-base/Makefile Fri Jan 28 17:07:12 2005
@@ -37,7 +37,7 @@
 pre-install:
	@${ECHO_MSG} "===>" Stopping cupsd ...
	-killall cupsd || ${TRUE}
-	${RM} -fr ${PREFIX}/etc/cups/certs/* || ${TRUE}
+	${RMDIR} ${PREFIX}/etc/cups/certs/* || ${TRUE}

 post-install:
	${MKDIR} ${CUPS_ETCDIR}
Comment 7 Volker Stolz freebsd_committer freebsd_triage 2005-01-28 08:22:11 UTC
State Changed
From-To: closed->open

It ain't fixed yet. 


Comment 8 Volker Stolz freebsd_committer freebsd_triage 2005-01-28 08:22:11 UTC
Responsible Changed
From-To: freebsd-ports-bugs->vs

I'll see this through.
Comment 9 Sergey Akifyev 2005-01-28 08:42:29 UTC
On ÐÔ, 2005-01-28 at 17:11 +0900, Tsurutani Naoki wrote:
> Volker Stolz <vs@freebsd.org> wrote:
> 
> > On Fri, Jan 28, 2005 at 01:06:26PM +0900, Tsurutani Naoki wrote:
> > > It seemes to be fixed by Maintainer with the fix about PR ports/76337.
> > 
> > Hm, I don't think so. The "rm -rf" is still there.
> 
> That's right. Entry still remains in Makefile.
> Please fix Makefile, please.


Stuff happens... Did you commit this already? If not, please do so...

> --- /usr/ports/print/cups-base/Makefile.orig    Fri Jan 28 04:32:58 2005
> +++ /usr/ports/print/cups-base/Makefile Fri Jan 28 17:07:12 2005
> @@ -37,7 +37,7 @@
>  pre-install:
> 	@${ECHO_MSG} "===>" Stopping cupsd ...
> 	-killall cupsd || ${TRUE}
> -	${RM} -fr ${PREFIX}/etc/cups/certs/* || ${TRUE}
> +	${RMDIR} ${PREFIX}/etc/cups/certs/* || ${TRUE}
> 
>  post-install:
> 	${MKDIR} ${CUPS_ETCDIR}

-- 
regards,
Sergey Akifyev <http://asa.gascom.ru>
AGAVA Software Company <http://www.agava.com>
PGP key available from:
ftp://ftp.gascom.ru/pub/PGP-keys/asa.txt
Comment 10 Volker Stolz freebsd_committer freebsd_triage 2005-01-28 10:43:49 UTC
State Changed
From-To: open->closed

Fixed, thanks for your submission!