Bug 77162 - Tomcat5 regression with jdk15-p1
Summary: Tomcat5 regression with jdk15-p1
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: java (show other bugs)
Version: 5.3-STABLE
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-java (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-06 10:10 UTC by Anthony Ginepro
Modified: 2005-03-21 05:50 UTC (History)
0 users

See Also:


Attachments
file.diff (3.89 KB, patch)
2005-02-06 10:10 UTC, Anthony Ginepro
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Ginepro 2005-02-06 10:10:18 UTC
	Tomcat 5.x becomes much slower with jdk15-p1 than jdk15-exp 
	as reported in :
	http://marc.theaimsgroup.com/?l=freebsd-java&m=110633266311615&w=2

	After some experiments, I get back normal operations when reverting
	hotspot/src/os/bsd/vm/os_bsd.cpp (which is what the patch joined does).

How-To-Repeat: 	Start Tomcat 5.x and check logs/catalina.out for startup time.
	Try JSP pages which are also slow the first time.
Comment 1 Anthony Ginepro 2005-02-06 10:50:40 UTC
forgive me for the typo, my real email is of course :
anthony.ginepro@laposte.net
Comment 2 phantom 2005-02-09 08:46:15 UTC
On Sun, Feb 06, 2005 at 11:06:48AM +0100, Anthony Ginepro wrote:
> 
> >Number:         77162
> >Category:       java
> >Synopsis:       Tomcat5 regression with jdk15-p1
> >Confidential:   no

> 	Tomcat 5.x becomes much slower with jdk15-p1 than jdk15-exp 
> 	as reported in :
> 	http://marc.theaimsgroup.com/?l=freebsd-java&m=110633266311615&w=2
> 
> 	After some experiments, I get back normal operations when reverting
> 	hotspot/src/os/bsd/vm/os_bsd.cpp (which is what the patch joined does).

Can you try following patch (on stock jdk1.5.0-p1), and notice me if it's
fixes your problem?  Thanks!

Index: os_bsd.cpp
===================================================================
RCS file: /home/cvs/javacvs/jdk150/hotspot/src/os/bsd/vm/os_bsd.cpp,v
retrieving revision 1.16
diff -u -r1.16 os_bsd.cpp
--- os_bsd.cpp	16 Jan 2005 10:16:25 -0000	1.16
+++ os_bsd.cpp	9 Feb 2005 08:40:04 -0000
@@ -1898,7 +1898,7 @@
     } while ((res == OS_ERR) && (errno == EINTR));
   } else {
     assert(Thread::current()->is_Java_thread(), "must be java thread");
-    INTERRUPTIBLE_NORESTART(nanosleep(&t, &t), res, os::Bsd::clear_interrupted);
+    INTERRUPTIBLE_NORESTART_VM(nanosleep(&t, &t), res, os::Bsd::clear_interrupted);
   }
   // INTERRUPTIBLE_NORESTART_VM returns res == OS_INTRPT for thread.Interrupt
Comment 3 Anthony Ginepro 2005-02-11 18:34:00 UTC
Hi Alexey,

Thanks for your patch it perfectly corrected my problem, now tomcat
under jdk15-p1 performance is on par with jdk15-exp ! I looked at both
startup time and jsp execution times.

Anthony.
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2005-03-16 23:00:54 UTC
I can confirm this fixed Tomcat for me. Any chance to get this into the
port soon?

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

May the Valar protect you on your path under the sky.
Comment 5 Anthony Ginepro 2005-03-17 18:57:28 UTC
Le Jeudi 17 mars 2005 =C3=A0 00:00 +0100, Pav Lucistnik a =C3=A9crit :
> I can confirm this fixed Tomcat for me. Any chance to get this into the
> port soon?

I don't have any news from Alexey Zelkin, I suppose he's too much busy
working on patchset2.
Could we have small patches along with patchset1 in ports while Alexey
works on the bigger scheme ?

Anthony.
Comment 6 Greg Lewis freebsd_committer freebsd_triage 2005-03-21 05:50:25 UTC
State Changed
From-To: open->closed

Committed Alexey's patch.