Bug 77394 - [patch] security/op enables an annoying amount of debugging on stderr.
Summary: [patch] security/op enables an annoying amount of debugging on stderr.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-02-11 17:50 UTC by Christopher Sean Hilton
Modified: 2005-03-03 19:52 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Sean Hilton 2005-02-11 17:50:18 UTC
      As built the op port generates a bunch of noisy output on stderr as it parses it's config file. I think this is debugging output for the op programmer. It makes the port less useful especially if the data on your tty was important before you ran op.

Fix: Substitute this patch-lex.l for the on that ships with the port:

# cat files/patch-lex.l


#include <stdio.h>
-#include <varargs.h>
+#include <stdarg.h>
 #include <ctype.h>
 #include "defs.h"

+static int     addarg();
 static cmd_t   *newcmd();
 char   *savestr();

@@ -47,15 +48,12 @@
 #include <sys/stat.h>
 #include <syslog.h>

-msg(va_alist)
- va_dcl
+msg(char *s,...)
 {
 #if 0
        va_list ap;
-       char    *s;

-       va_start(ap);
-       s = va_arg(ap, char *);
+       va_start(ap,s);
        fprintf(stderr,"line %d: ",yyline);
        vfprintf(stderr, s, ap);
        fputc('\n', stderr);--ouXtyuzNmw3wfAklh0O5cGpziiwv2hrTWvjZKkX2GKmMCwJd
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- lex.l.orig  Sun Jan 16 11:36:55 2005
+++ lex.l       Sun Jan 16 13:09:52 2005
@@ -10,10 +10,11 @@
 /* +-------------------------------------------------------------------+ */
How-To-Repeat:       Build the op port. Configure it and run it.
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2005-02-12 22:49:48 UTC
Dear maintainer of FreeBSD port security/op, please take a look at

http://www.freebsd.org/cgi/query-pr.cgi?q=77394

Do you approve this change?

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

In fact, the GAH is a very powerful and secretive organization whose
single weakness is its lack of existance.
  - rec.games.roguelike.angband
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2005-02-12 22:49:50 UTC
State Changed
From-To: open->feedback

Asked maintainer for approval. 


Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2005-02-12 22:49:50 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pav

Handle.
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2005-03-03 19:52:37 UTC
State Changed
From-To: feedback->closed

Committed, thanks!