Update port: ftp/vsftpd to 2.0.3 - Update to 2.0.3 - Add rcNG script - Removing REINPLACE_CMD noise Add files: files/vsftpd.sh NOTE: Add on ports/UPDATING: -- AFFECTS: users of ftp/vsftpd AUTHOR: marcus@corp.grupos.com.br Vsftpd now installs an rcNG script for starting the vsftpd daemon. To enable vsftpd to start at boot time, add the following to /etc/rc.conf: vsftpd_enable="YES" You can also pass flags to vsftpd by setting the rc.conf variable vsftpd_flags. Per default vsftpd use ${PREFIX}/etc/vsftpd.conf. * To vsftpd rcNG work, config file need "listen=YES" and "background=YES". --
Responsible Changed From-To: freebsd-ports-bugs->dinoex Over to maintainer.
State Changed From-To: open->feedback - Your patches apply, but results in a broken port. 1. Your use of OPTIONS breaks SSL support. "USE_OPENSSL=yes" must be set before "include <bsd.port.pre.mk>" 2. Your use of OPTIONS violates POLA, vsftp supoports SSL by default. 3. You hide the lib -lwrap in REINPLACE_CMD. Such options should be visible in LDFLAGS or LIBS. 4. Please avoid to alter files at post-build stage. This breaks rebuilds. Please do this in post-configure. 5. Noise is discussable, but there should be visible that an option is activated or not. -> Rejected in this form. 6. Add rcNG script breaks inetd support. vsftpd is a replacement to the base ftp, so it is started via inetd by default. Forcing the use of vsftpd.sh is another violation of POLA. If you want to add support for a standalone run, You have to make this an tunable option. I commited an update and fixed the lwrap issuse. If you want the other changes, please rework you patch, and test it more throughly. Especially OPTIONS are tricky.
Dirk, New patch attached. I think now its correct. Regards Dirk Meyer wrote: > Synopsis: Update port: ftp/vsftpd to 2.0.3 > > State-Changed-From-To: open->feedback > State-Changed-By: dinoex > State-Changed-When: Sun Apr 10 06:38:16 CEST 2005 > State-Changed-Why: > - Your patches apply, but results in a broken port. > > 1. Your use of OPTIONS breaks SSL support. > > "USE_OPENSSL=yes" must be set before "include <bsd.port.pre.mk>" > > 2. Your use of OPTIONS violates POLA, > > vsftp supoports SSL by default. > > 3. You hide the lib -lwrap in REINPLACE_CMD. > > Such options should be visible in LDFLAGS or LIBS. > > 4. Please avoid to alter files at post-build stage. > > This breaks rebuilds. Please do this in post-configure. > > 5. Noise is discussable, but there should be visible that > an option is activated or not. -> Rejected in this form. > > 6. Add rcNG script breaks inetd support. > > vsftpd is a replacement to the base ftp, > so it is started via inetd by default. > > Forcing the use of vsftpd.sh is another violation of POLA. > > If you want to add support for a standalone run, > You have to make this an tunable option. > > > I commited an update and fixed the lwrap issuse. > > If you want the other changes, please rework you patch, > and test it more throughly. Especially OPTIONS are tricky. > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=79687 -- Marcus Grando Grupos Internet S/A marcus(at)corp.grupos.com.br
State Changed From-To: feedback->closed committed, thanks.