Bug 80971 - fvwm2 overrides PKGNAMESUFFIX set by fvwm2-i18n
Summary: fvwm2 overrides PKGNAMESUFFIX set by fvwm2-i18n
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-13 12:10 UTC by Vasil Dimov
Modified: 2005-06-05 22:12 UTC (History)
0 users

See Also:

Attachments
Makefile.patch (337 bytes, patch)
2005-05-13 12:10 UTC, Vasil Dimov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vasil Dimov 2005-05-13 12:10:02 UTC 
If imlib is installed on the system (${HAVE_GNOME:Mimlib}!="") then
x11-wm/fvwm2's Makefile sets PKGNAMESUFFIX regardless of its old
value which may have been previously set by x11-wm/fvwm2-i18n.
As a result we get two ports with identical PKGNAME which leads
to incorrect make search results and warnings while INDEX builds.

% make index
...
Warning: Duplicate INDEX entry: fvwm-imlib-2.4.19

Fix: I think the following patch should be applied to x11-wm/fvwm2/Makefile
It makes fvwm2-i18n's PKGNAME fvwm2-i18n-imlib-2.4.19
(or fvwm2-i18n-2.4.19 if no imlib is installed)
How-To-Repeat: 
Make sure graphics/imlib is installed: ${HAVE_GNOME:Mimlib}!=""
needs to be true.

% cd /usr/ports/x11-wm/fvwm2 && make -V PKGNAME
fvwm-imlib-2.4.19

% cd /usr/ports/x11-wm/fvwm2-i18n && make -V PKGNAME
fvwm-imlib-2.4.19

% cd /usr/ports && make index

% cd /usr/ports && make search name=fvwm
(notice the missing port)
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2005-05-13 21:26:04 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->cy


Assign to maintainer.
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2005-06-05 22:12:28 UTC 
State Changed
From-To: open->closed

Committed, thanks!