Update of editors/slime to 1.2.1.
Dear maintainer of FreeBSD port editors/slime, please take a look at http://www.freebsd.org/cgi/query-pr.cgi?q=81253 Do you approve this update? -- Pav Lucistnik <pav@oook.cz> <pav@FreeBSD.org> "Ragtime" contained about forty-five seconds of Elizabeth McGovern completely topless, but it got a "PG" in 1980. I have no idea why that did, or "Titanic" got PG-13, yet "Merchant of Venice" gets tagged with an "R". The MPAA is an intellectual and aesthetic embarassment. -- comment from IMDb board on US movie rating system
State Changed From-To: open->feedback Asked maintainer for approval
Responsible Changed From-To: freebsd-ports-bugs->pav Track
On Fri, May 20, 2005 at 01:21:31PM +0200, Pav Lucistnik wrote: > Dear maintainer of FreeBSD port editors/slime, please take a look at > > http://www.freebsd.org/cgi/query-pr.cgi?q=81253 > > Do you approve this update? It needs an additional patch in order to work correctly with SBCL. Please commit the update with this patch included as "files/patch-swank-sbcl.lisp". A corrected version of this patch should really be folded into slime upstream... Thanks, -Dom --- swank-sbcl.lisp.orig Sun May 22 11:05:56 2005 +++ swank-sbcl.lisp Sun May 22 11:06:30 2005 @@ -42,10 +42,7 @@ ;;; TCP Server (defimplementation preferred-communication-style () - (if (and (member :sb-thread *features*) - (not (sb-alien:extern-alien "linux_no_threads_p" sb-alien:boolean))) - :spawn - :fd-handler)) + :fd-handler) (defun resolve-hostname (name) (car (sb-bsd-sockets:host-ent-addresses
Dominic Mitchell wrote: > It needs an additional patch in order to work correctly with SBCL. I'm sorry I tested my PR only with SBCL 0.9.0. I confirmed your patch is required for SBCL 0.8.17. > A corrected version of this patch should really be folded into slime > upstream... How about the following patch? -- NIIMI Satoshi --- swank-sbcl.lisp.orig Thu Apr 28 04:16:21 2005 +++ swank-sbcl.lisp Mon May 23 21:35:07 2005 @@ -43,6 +43,7 @@ (defimplementation preferred-communication-style () (if (and (member :sb-thread *features*) + #+linux (not (sb-alien:extern-alien "linux_no_threads_p" sb-alien:boolean))) :spawn :fd-handler))
On Mon, May 23, 2005 13:55, NIIMI Satoshi said: > Dominic Mitchell wrote: >> It needs an additional patch in order to work correctly with SBCL. > > I'm sorry I tested my PR only with SBCL 0.9.0. I confirmed your > patch is required for SBCL 0.8.17. I just installed the latest version from ports. Took me a wihle ot figure ou what was happening though. :) >> A corrected version of this patch should really be folded into slime >> upstream... > > How about the following patch? I am unable to test this patch at present, but it looks correct to me. If it works for you, please go ahead and commit it. It´s far less intrusive than mine. Thanks, -Dom > -- > NIIMI Satoshi > > --- swank-sbcl.lisp.orig Thu Apr 28 04:16:21 2005 > +++ swank-sbcl.lisp Mon May 23 21:35:07 2005 > @@ -43,6 +43,7 @@ > > (defimplementation preferred-communication-style () > (if (and (member :sb-thread *features*) > + #+linux > (not (sb-alien:extern-alien "linux_no_threads_p" > sb-alien:boolean))) > :spawn > :fd-handler)) > > >
State Changed From-To: feedback->closed Committed, thanks!