Bug 81440 - Major improvements to x11-wm/fvwm2-devel port
Summary: Major improvements to x11-wm/fvwm2-devel port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-24 16:10 UTC by Alexey Dokuchaev
Modified: 2006-02-19 20:50 UTC (History)
0 users

See Also:

Attachments
foo (42.12 KB, text/plain)
2005-05-24 16:10 UTC, Alexey Dokuchaev 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Dokuchaev freebsd_committer freebsd_triage 2005-05-24 16:10:02 UTC 

- Convert to OPTIONS
- Switch from rarely used biconv.2 to standard iconv.3
- Add WITH_RPLAY knob, kill WITHOUT_XINERAMA since it was of little use
- Fix WITH_BIDI case (missing fribidi.0 dependency)
- Remove evil `-imlib' PKGNAMESUFFIX
- Do not forget FvwmGtk.1 in MAN1
- Fix NLS detection (and handle WITHOUT_NLS knob)
- Adjust PLIST accordingly
- Utilize DATADIR in pkg-plist
- Pacify portlint

How-To-Repeat: 

N/A
Comment 1 Alexey Dokuchaev freebsd_committer freebsd_triage 2005-05-24 16:11:37 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->cy

Over to maintainer.
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2005-05-24 16:26:03 UTC 
One more thing: files/patch-confighure now includes possible RCS tag 
"$LINENO$", so I guess it's better to use binary mode (-ko) on 
commit/import.  That's what portlint -A suggests.
Comment 3 Alexey Dokuchaev freebsd_committer freebsd_triage 2005-05-25 05:51:24 UTC 
Yet another "one more" thing: in patch-configure, there's a typo in 
providing wrong CFLAGS ($intl_LIBS instead of $intl_CFLAGS, and 
$iconv_LIBS instead of $iconv_CFLAGS), and I only patch $intl case.  
$iconv one should be changed too.  Since it seems like pretty trivial 
case, I'm not
sending another huge diff.
Comment 4 Cy Schubert freebsd_committer freebsd_triage 2005-09-13 21:16:31 UTC 
State Changed
From-To: open->analyzed

I have given danfe@ approval to commit the patch and will consider retrofitting 
the patch back to the x11/fvwm2 port as well.
Comment 5 Alexey Dokuchaev freebsd_committer freebsd_triage 2005-09-14 07:59:34 UTC 
State Changed
From-To: analyzed->patched

Thanks cy@!  I've committed to x11/fvwm2-devel.  Will work on getting 
this into x11/fvwm2 as well shortly.
Comment 6 Cy Schubert freebsd_committer freebsd_triage 2006-02-19 20:49:47 UTC 
State Changed
From-To: patched->closed

As this has been pathed and committed, this PR should be closed.