Tomcat version 5.5 has been released, and can run with either J2SE 1.4 (with XML compatiblity JARs) or 1.5. Since FreeBSD has both, especially java/jdk15 now, there is no barrier to having Tomcat 5.5 in Ports that I know of.
State Changed From-To: open->feedback We need a patch...
Responsible Changed From-To: freebsd-ports-bugs->freebsd-java Over to the Java community.
Hi Kang, On Sun, Jun 05, 2005 at 11:17:49PM +0800, Kang Liu wrote: > I think we'd better make tomcat55 as a new port, since it is not stable > enough for production server. I believe it would be better to repocopy tomcat5 -> tomcat55. Do you agree with that? BTW, I don't think DEPRECATED is the right keyword for a new, devel port. Speaking of devel ports, do you think "jakarta-tomcat5-devel" would fit better than 'jakarta-tomcat55"? The same goes for jakarta-tomcat4-devel. IMHO, looking at the descriptions of these ports, it seems to me like each branch has its own set of features that don't seem to be merged back. This would mean that they are not "-devel" branches. But I let the choice up to you, as I don't know very much about the distinction between versions. Herve
Hi Herve & Kang, <quote who="Herve Quiroz"> > Speaking of devel ports, do you think "jakarta-tomcat5-devel" would > fit better than 'jakarta-tomcat55"? The same goes for > jakarta-tomcat4-devel. IMHO, looking at the descriptions of these > ports, it seems to me like each branch has its own set of features that > don't seem to be merged back. This would mean that they are not "-devel" > branches. But I let the choice up to you, as I don't know very much > about the distinction between versions. > > Herve > Tossing in my two cents as an end-user/developer. I think it's more appropriate it be named tomcat55. tomcat[4|5]-devel, to me, would be the current developments on those brances, like betas/RCs of 5.0.x & 4.0.x. But 5.5.x is a completely separate branch. And I don't think DEPRECATED should be used, either. Quite honestly, I don't think any keyword should be used. I can't think of any immediate example of any other non-devel port that uses some keyword in order to scream "don't use this in production!" to users. I think people (at least I am. :D) are apt to know what software is good enough to be used in what situation. If I can make a suggestion... I don't know how this is handled in a ports Makefile, but the JAVA_VERSION=1.5+ isn't quite right. JVM 1.5 is the most recommended, of course. But 1.4.x+ can be used if the two XML compatibility JARs are downloaded and installed also. Maybe this is the job of a post-install script or a patchfile or something? Not sure, but just suggesting. Thanks! --Scott
Hi Scott, On Mon, Jun 06, 2005 at 12:57:53PM -0400, Scott Balmos wrote: > Tossing in my two cents as an end-user/developer. I think it's more > appropriate it be named tomcat55. tomcat[4|5]-devel, to me, would be the > current developments on those brances, like betas/RCs of 5.0.x & 4.0.x. > But 5.5.x is a completely separate branch. Yes, that is what I was trying to suggest in my message actually. > And I don't think DEPRECATED should be used, either. Quite honestly, I > don't think any keyword should be used. I can't think of any immediate > example of any other non-devel port that uses some keyword in order to > scream "don't use this in production!" to users. I think people (at least > I am. :D) are apt to know what software is good enough to be used in what > situation. I agree with you. Now, the best would be that someone(tm) update "Java and Jakarta Tomcat on FreeBSD" [1] to reflect the latest tomcat ports additions and changes. > If I can make a suggestion... I don't know how this is handled in a ports > Makefile, but the JAVA_VERSION=1.5+ isn't quite right. JVM 1.5 is the most > recommended, of course. But 1.4.x+ can be used if the two XML > compatibility JARs are downloaded and installed also. Maybe this is the > job of a post-install script or a patchfile or something? Not sure, but > just suggesting. Ah, there's another port (textproc/xalan-j) that has some trouble with JDK 1.5. If you could tell me more about those XML compatibility JARs, I think I could solve this one as well. And no need for a post-install script. Just need to test which JDK is used in the port and add the dependency or not. Indeed, I think this compatibility kit should be part of a whole separate port. Thanks for your feedback. Herve [1] http://www.freebsd.org/doc/en_US.ISO8859-1/articles/java-tomcat/
Hi Herve, <quote who="Herve Quiroz"> > Hi Scott, > > I agree with you. Now, the best would be that someone(tm) update "Java > and Jakarta Tomcat on FreeBSD" [1] to reflect the latest tomcat ports > additions and changes. > I'll page through it later on this afternoon. I might take a stab at updating it after I get 5.5 running through the new Port. > Ah, there's another port (textproc/xalan-j) that has some trouble with > JDK 1.5. If you could tell me more about those XML compatibility JARs, I > think I could solve this one as well. > http://apache.mirrormax.net/jakarta/tomcat-5/v5.5.9/bin/jakarta-tomcat-5.5.9-compat.tar.gz ...or for the Makefile... ${MASTER_SITE_SUBDIR}/jakarta-tomcat-5.5.9-compat.tar.gz I know it should really be ${SOMETHING}-compat.tar.gz , but I can't find the appropriate variables. Haven't done much Porting myself. It includes JARs for JMX backports, and the Xerces XML stuff. Hrm... Just noticed Hibernate isn't in Ports. Maybe that'll be my next task. LOL --Scott
Hi Scott and Kang, I'll ask for a repocopy of the 5 branch. Who wants to become maintainer of the 5.5 branch? Herve
State Changed From-To: feedback->open Patch received
Responsible Changed From-To: freebsd-java->hq I'll handle this
State Changed From-To: open->repocopy Dear portmgr, Could you please repocopy www/jakarta-tomcat5 to www/jakarta-tomcat55 ?
Responsible Changed From-To: hq->portmgr Dear portmgr, Could you please repocopy www/jakarta-tomcat5 to www/jakarta-tomcat55 ?
State Changed From-To: repocopy->open Repocopy completed.
Responsible Changed From-To: portmgr->hq Repocopy completed.
Hi Kang, I just commited your changes and set you as the maintainer. Still to be improved is the JDK 1.4 compatibility fix, based on the distfile pointed out by Scott. I'll give it a shot probably by tomorrow. Herve
Herve, this PR can be closed now? -- Pav Lucistnik <pav@oook.cz> <pav@FreeBSD.org> Is this a dagger which I see before me, its handle towards my hand? Come, let me clutch thee! I have thee not, and yet I see thee still.
On Mon, Jun 06, 2005 at 01:56:28PM -0400, Scott Balmos wrote: > http://apache.mirrormax.net/jakarta/tomcat-5/v5.5.9/bin/jakarta-tomcat-5.5.9-compat.tar.gz > > ...or for the Makefile... > > ${MASTER_SITE_SUBDIR}/jakarta-tomcat-5.5.9-compat.tar.gz > > I know it should really be ${SOMETHING}-compat.tar.gz , but I can't find > the appropriate variables. Haven't done much Porting myself. It includes > JARs for JMX backports, and the Xerces XML stuff. Thanks to Pav, I found out that the patch I made has been roting on my drive for more than a month now. So here it is. The port installs/deinstalls fine but I need some feedback regarding Tomcat 5.5 actually working with Java 1.4. You may test it using: $ make install JAVA_VERSION=1.4 or $ make install JAVA_VERSION=1.5 Sorry for the delay... Herve Index: Makefile =================================================================== RCS file: /home/ncvs/ports/www/jakarta-tomcat55/Makefile,v retrieving revision 1.25 diff -u -r1.25 Makefile --- Makefile 13 Jun 2005 14:08:34 -0000 1.25 +++ Makefile 15 Jul 2005 16:38:11 -0000 @@ -10,12 +10,13 @@ CATEGORIES= www java MASTER_SITES= ${MASTER_SITE_APACHE_JAKARTA} MASTER_SITE_SUBDIR= tomcat-5/v${PORTVERSION}/bin +DISTFILES= ${PORTNAME}-${PORTVERSION}.tar.gz MAINTAINER= liukang@bjut.edu.cn COMMENT= Open-source Java web server by Apache, 5.5.x branch USE_JAVA= yes -JAVA_VERSION= 1.5+ +JAVA_VERSION= 1.4+ NO_BUILD= YES .if !defined(NOPORTDOCS) @@ -56,7 +57,16 @@ LATEST_LINK= ${APP_SHORTNAME} CONF_EXT= sample PLIST_SUB+= CONF_EXT=${CONF_EXT} + .include <bsd.port.pre.mk> + +.if ${JAVA_PORT_VERSION:C/^([0-9])\.([0-9])(.*)$/\1.\2/} == "1.4" +DISTFILES+= ${PORTNAME}-${PORTVERSION}-compat.tar.gz +PLIST_SUB+= JAVA14="" +.else +PLIST_SUB+= JAVA14="@comment " +.endif + pre-patch: @${ECHO_MSG} "Installation settings:" Index: distinfo =================================================================== RCS file: /home/ncvs/ports/www/jakarta-tomcat55/distinfo,v retrieving revision 1.14 diff -u -r1.14 distinfo --- distinfo 13 Jun 2005 14:08:34 -0000 1.14 +++ distinfo 15 Jul 2005 16:38:11 -0000 @@ -1,2 +1,4 @@ MD5 (jakarta-tomcat-5.5.9.tar.gz) = 35ea177af353446af1de3c762a4f0f4d SIZE (jakarta-tomcat-5.5.9.tar.gz) = 5210986 +MD5 (jakarta-tomcat-5.5.9-compat.tar.gz) = 33f27b14f0ece9aedccecf7212d73ffc +SIZE (jakarta-tomcat-5.5.9-compat.tar.gz) = 1367217 Index: pkg-plist =================================================================== RCS file: /home/ncvs/ports/www/jakarta-tomcat55/pkg-plist,v retrieving revision 1.15 diff -u -r1.15 pkg-plist --- pkg-plist 13 Jun 2005 14:08:34 -0000 1.15 +++ pkg-plist 15 Jul 2005 16:38:11 -0000 @@ -30,6 +30,7 @@ %%T%%/bin/commons-daemon.jar %%T%%/bin/commons-logging-api.jar %%T%%/bin/digest.sh +%%JAVA14%%%%T%%/bin/jmx.jar %%T%%/bin/jsvc.tar.gz %%T%%/bin/setclasspath.sh %%T%%/bin/shutdown.sh @@ -38,6 +39,8 @@ %%T%%/bin/tool-wrapper.sh %%T%%/bin/version.sh %%T%%/common/classes/logging.properties +%%JAVA14%%%%T%%/common/endorsed/xercesImpl.jar +%%JAVA14%%%%T%%/common/endorsed/xml-apis.jar %%T%%/common/i18n/tomcat-i18n-en.jar %%T%%/common/i18n/tomcat-i18n-es.jar %%T%%/common/i18n/tomcat-i18n-fr.jar
State Changed From-To: open->feedback Maintainer and submitter feedback needed.
I have yet to see anything glaringly wrong, running on a test VPC I have set up. My main box is on Java 1.5, so I'm not touching that. But, like I said, this seems to work without noticable issues. --Scott On Fri, July 15, 2005 12:45 pm, Herve Quiroz wrote: > On Mon, Jun 06, 2005 at 01:56:28PM -0400, Scott Balmos wrote: >> http://apache.mirrormax.net/jakarta/tomcat-5/v5.5.9/bin/jakarta-tomcat-5.5.9-compat.tar.gz >> >> ...or for the Makefile... >> >> ${MASTER_SITE_SUBDIR}/jakarta-tomcat-5.5.9-compat.tar.gz >> >> I know it should really be ${SOMETHING}-compat.tar.gz , but I can't find >> the appropriate variables. Haven't done much Porting myself. It includes >> JARs for JMX backports, and the Xerces XML stuff. > > Thanks to Pav, I found out that the patch I made has been roting on my > drive for more than a month now. So here it is. The port > installs/deinstalls fine but I need some feedback regarding Tomcat 5.5 > actually working with Java 1.4. > > You may test it using: > > $ make install JAVA_VERSION=1.4 > > or > > $ make install JAVA_VERSION=1.5 > > Sorry for the delay... > > Herve > > > Index: Makefile > =================================================================== > RCS file: /home/ncvs/ports/www/jakarta-tomcat55/Makefile,v > retrieving revision 1.25 > diff -u -r1.25 Makefile > --- Makefile 13 Jun 2005 14:08:34 -0000 1.25 > +++ Makefile 15 Jul 2005 16:38:11 -0000 > @@ -10,12 +10,13 @@ > CATEGORIES= www java > MASTER_SITES= ${MASTER_SITE_APACHE_JAKARTA} > MASTER_SITE_SUBDIR= tomcat-5/v${PORTVERSION}/bin > +DISTFILES= ${PORTNAME}-${PORTVERSION}.tar.gz > > MAINTAINER= liukang@bjut.edu.cn > COMMENT= Open-source Java web server by Apache, 5.5.x branch > > USE_JAVA= yes > -JAVA_VERSION= 1.5+ > +JAVA_VERSION= 1.4+ > NO_BUILD= YES > > .if !defined(NOPORTDOCS) > @@ -56,7 +57,16 @@ > LATEST_LINK= ${APP_SHORTNAME} > CONF_EXT= sample > PLIST_SUB+= CONF_EXT=${CONF_EXT} > + > .include <bsd.port.pre.mk> > + > +.if ${JAVA_PORT_VERSION:C/^([0-9])\.([0-9])(.*)$/\1.\2/} == "1.4" > +DISTFILES+= ${PORTNAME}-${PORTVERSION}-compat.tar.gz > +PLIST_SUB+= JAVA14="" > +.else > +PLIST_SUB+= JAVA14="@comment " > +.endif > + > > pre-patch: > @${ECHO_MSG} "Installation settings:" > Index: distinfo > =================================================================== > RCS file: /home/ncvs/ports/www/jakarta-tomcat55/distinfo,v > retrieving revision 1.14 > diff -u -r1.14 distinfo > --- distinfo 13 Jun 2005 14:08:34 -0000 1.14 > +++ distinfo 15 Jul 2005 16:38:11 -0000 > @@ -1,2 +1,4 @@ > MD5 (jakarta-tomcat-5.5.9.tar.gz) = 35ea177af353446af1de3c762a4f0f4d > SIZE (jakarta-tomcat-5.5.9.tar.gz) = 5210986 > +MD5 (jakarta-tomcat-5.5.9-compat.tar.gz) = > 33f27b14f0ece9aedccecf7212d73ffc > +SIZE (jakarta-tomcat-5.5.9-compat.tar.gz) = 1367217 > Index: pkg-plist > =================================================================== > RCS file: /home/ncvs/ports/www/jakarta-tomcat55/pkg-plist,v > retrieving revision 1.15 > diff -u -r1.15 pkg-plist > --- pkg-plist 13 Jun 2005 14:08:34 -0000 1.15 > +++ pkg-plist 15 Jul 2005 16:38:11 -0000 > @@ -30,6 +30,7 @@ > %%T%%/bin/commons-daemon.jar > %%T%%/bin/commons-logging-api.jar > %%T%%/bin/digest.sh > +%%JAVA14%%%%T%%/bin/jmx.jar > %%T%%/bin/jsvc.tar.gz > %%T%%/bin/setclasspath.sh > %%T%%/bin/shutdown.sh > @@ -38,6 +39,8 @@ > %%T%%/bin/tool-wrapper.sh > %%T%%/bin/version.sh > %%T%%/common/classes/logging.properties > +%%JAVA14%%%%T%%/common/endorsed/xercesImpl.jar > +%%JAVA14%%%%T%%/common/endorsed/xml-apis.jar > %%T%%/common/i18n/tomcat-i18n-en.jar > %%T%%/common/i18n/tomcat-i18n-es.jar > %%T%%/common/i18n/tomcat-i18n-fr.jar > --
State Changed From-To: feedback->closed Patch commited. Thanks for your contribution!