Bug 82417 - [audio/juke] Patch to make controls 'hjkl'-conformant
Summary: [audio/juke] Patch to make controls 'hjkl'-conformant
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-19 16:00 UTC by Ed Schouten
Modified: 2005-07-13 17:16 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Schouten 2005-06-19 16:00:40 UTC
'juke' is a small CLI music player which has strange controls ('h' is help and the cursor can be controlled with 'jkil').

I've built a small patch which allows you to build the port with WITH_HJKL_BINDINGS; help is moved to '?' and you can control the app with 'hjkl'

Fix: 

Look at:

http://www.il.fontys.nl/~ed/juke-ports-hjkl.patch
How-To-Repeat: Build juke and see for yourself.
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2005-06-23 16:14:58 UTC
State Changed
From-To: open->feedback

We generally does not accept patches changing functionality. 
Your patch should go to juke author, if it's generally desirable change, 
or remain your local patch. 

Have you contacted author about this? 


Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2005-06-23 16:14:58 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pav

Poke
Comment 3 Ed Schouten 2005-07-03 14:17:27 UTC
Hello,

Please note: this patch has been updated. The option is now called
WITH_VI_BINDINGS because it will add more vi(1)-like bindings like ^F,
^B, g and G. Adding support for the last two bindings was a little
harder, because Juke wasn't capable of home/end-like controls.

Yours,
-- 
 Ed Schouten <ed@fxq.nl>
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2005-07-13 17:16:33 UTC
State Changed
From-To: feedback->closed

Committed, thanks!