Bug 83864 - [maintainer] math/gap: update and bugfix
Summary: [maintainer] math/gap: update and bugfix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-21 15:10 UTC by Johan van Selst
Modified: 2005-08-01 14:08 UTC (History)
0 users

See Also:


Attachments
file.diff (2.20 KB, patch)
2005-07-21 15:10 UTC, Johan van Selst
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johan van Selst 2005-07-21 15:10:07 UTC
	
	Update to use new contrib packages.
	Include bugfix in tty handling (fed back to authors).

Fix: This patch adds files/patch-gap4r4_src_iostream.c
Comment 1 Renato Botelho freebsd_committer freebsd_triage 2005-07-21 16:28:37 UTC
Responsible Changed
From-To: freebsd-ports-bugs->garga

I'll take it
Comment 2 Renato Botelho freebsd_committer freebsd_triage 2005-07-22 13:11:05 UTC
State Changed
From-To: open->feedback

It's not respecting CC/CFLAGS/LDFLAGS. 

Could you take a look on this?
Comment 3 Johan van Selst 2005-07-22 14:04:32 UTC
Renato Botelho wrote:
> It's not respecting CC/CFLAGS/LDFLAGS.

Could you please elaborate on this?
I believe the port does respect CC/CFLAGS/LDFLAGS just fine.


Just ran a  make CC=gcc295 CFLAGS="-g -gdb" LDFLAGS="-lcrypt"
and it seems to build exactly what I would expect...


Greetings,
Johan
Comment 4 Renato Botelho freebsd_committer freebsd_triage 2005-07-22 14:25:14 UTC
On Fri, Jul 22, 2005 at 03:04:32PM +0200, Johan van Selst wrote:
> Renato Botelho wrote:
> > It's not respecting CC/CFLAGS/LDFLAGS.
> 
> Could you please elaborate on this?
> I believe the port does respect CC/CFLAGS/LDFLAGS just fine.
> 
> 
> Just ran a  make CC=gcc295 CFLAGS="-g -gdb" LDFLAGS="-lcrypt"
> and it seems to build exactly what I would expect...

I'm talking about -O2 -g on default compilation, could you remove it?
And, if you want add it as optional features?

Thanks
-- 
Renato Botelho <garga @ FreeBSD.org>
               <freebsd @ galle.com.br>
GnuPG Key: http://people.freebsd.org/~garga/pubkey.asc

"We demand rigidly defined areas of doubt and uncertainty!"
		-- Vroomfondel
Comment 5 Johan van Selst 2005-07-22 15:41:52 UTC
Renato Botelho wrote:
> I'm talking about -O2 -g on default compilation, could you remove it?

This is the default defined by the author, overridable with ${CFLAGS}.

Removing it is simple: add this as files/patch-gap4r4_cnf_configure.out

--- gap4r4/cnf/configure.out.orig       Fri Jul 22 16:39:30 2005
+++ gap4r4/cnf/configure.out    Fri Jul 22 16:39:27 2005
@@ -3708,6 +3708,8 @@ if test "${gp_cv_cflags+set}" = set; the
   echo $ECHO_N "(cached) $ECHO_C" >&6
 else
    case "$host-$CC" in
+    *-freebsd* )
+       gp_cv_cflags="";;
     *-gcc | *-linux*-cc )
        gp_cv_cflags="-Wall -g -O2";;
     i686-*-egcs )

Comment 6 Renato Botelho freebsd_committer freebsd_triage 2005-07-22 19:11:36 UTC
On Fri, Jul 22, 2005 at 04:41:52PM +0200, Johan van Selst wrote:
> Renato Botelho wrote:
> > I'm talking about -O2 -g on default compilation, could you remove it?
> 
> This is the default defined by the author, overridable with ${CFLAGS}.
> 
> Removing it is simple: add this as files/patch-gap4r4_cnf_configure.out
> 
> --- gap4r4/cnf/configure.out.orig       Fri Jul 22 16:39:30 2005
> +++ gap4r4/cnf/configure.out    Fri Jul 22 16:39:27 2005
> @@ -3708,6 +3708,8 @@ if test "${gp_cv_cflags+set}" = set; the
>    echo $ECHO_N "(cached) $ECHO_C" >&6
>  else
>     case "$host-$CC" in
> +    *-freebsd* )
> +       gp_cv_cflags="";;
>      *-gcc | *-linux*-cc )
>         gp_cv_cflags="-Wall -g -O2";;
>      i686-*-egcs )
> 
> 

I tried this patch and add it on post-patch: target

@${REINPLACE_CMD} -e "s|CC=\'.(CC)\' ||g" ${GAP_WRKSRC}/Makefile.in

But it's still using gcc, how you could see here:

http://rafb.net/paste/results/aCkpl572.html

Could you take a look on this please?

Thanks
-- 
Renato Botelho <garga @ FreeBSD.org>
               <freebsd @ galle.com.br>
GnuPG Key: http://people.freebsd.org/~garga/pubkey.asc

A Riverside, California, health ordinance states that two persons may
not kiss each other without first wiping their lips with carbolized
rosewater.
Comment 7 Renato Botelho freebsd_committer freebsd_triage 2005-08-01 14:08:28 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!