Bug 84527 - [PATCH] devel/pear-PHP_Beautifier: mark BROKEN for PHP4
Summary: [PATCH] devel/pear-PHP_Beautifier: mark BROKEN for PHP4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sam Lawrance
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-03 18:20 UTC by Yen-Ming Lee
Modified: 2005-08-08 11:59 UTC (History)
1 user (show)

See Also:

Attachments
pear-PHP_Beautifier-0.1.4.patch (394 bytes, patch)
2005-08-03 18:20 UTC, Yen-Ming Lee 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yen-Ming Lee freebsd_committer freebsd_triage 2005-08-03 18:20:05 UTC 
- mark BROKEN for PHP4
  (pear-PHP_Beautifier uses "try {...} catch {...}", which is only supported in PHP5)

Port maintainer (antonio@php.net) is cc'd.

Generated with FreeBSD Port Tools 0.63

How-To-Repeat: 
(after installed pear-PHP_Beautifier)

# php_beautifier
Parse error: parse error, unexpected '{' in /usr/local/bin/php_beautifier on line 179
Comment 1 Sam Lawrance freebsd_committer freebsd_triage 2005-08-04 06:39:33 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->lawrance

Take
Comment 2 Sam Lawrance freebsd_committer freebsd_triage 2005-08-05 12:57:55 UTC 
Hi maintainer,

It seems that pear-PHP_Beautifier not work with PHP4:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/84527

Also, DEFAULT_PHP_VER does not work correctly (notice that both php4 and
php5 are dependencies):
http://pointyhat.freebsd.org/errorlogs/i386-6-full-logs/pear-PHP_Beautifier-0.1.4.log

We could either set NO_PACKAGE (like pear-PHPUnit2 does to avoid the
same problem), or patch the port to work with PHP4 as default.

What do you think?

Cheers
Sam
Comment 3 Sam Lawrance freebsd_committer freebsd_triage 2005-08-05 12:58:20 UTC 
State Changed
From-To: open->feedback

Maintainer was asked for feedback
Comment 4 Sam Lawrance freebsd_committer freebsd_triage 2005-08-07 12:58:03 UTC 
State Changed
From-To: feedback->open

Maintainer approved (mark NO_PACKAGE)
Comment 5 Sam Lawrance freebsd_committer freebsd_triage 2005-08-08 11:58:21 UTC 
State Changed
From-To: open->closed

Committed, thanks!