Bug 84573 - [PATCH] - security/bdc - fix for missing file in ${DISTDIR}
Summary: [PATCH] - security/bdc - fix for missing file in ${DISTDIR}
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sam Lawrance
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-05 07:40 UTC by Adi Pircalabu
Modified: 2005-08-20 09:41 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adi Pircalabu 2005-08-05 07:40:15 UTC
security/bdc is broken at this time since the distribution file is not automatically fetched and the return code is 1.
For references, see:
http://lists.freebsd.org/pipermail/freebsd-ports/2005-August/025195.html
http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/e.6.2005080108/bdc-7.0.1.log

Fix: 

-do-fetch:
-.if !exists(${DISTDIR}/${DISTNAME}${EXTRACT_SUFX})
-       @${ECHO} ""
-       @${ECHO} "You have to fetch ${DISTNAME}${EXTRACT_SUFX} manually after"
-       @${ECHO} "reading and agreeing to the license at:"
-       @${ECHO} ""
-       @${ECHO} "http://download.bitdefender.com/freebsd/${BDREL}/beta/LICENSE"
-       @${ECHO} ""
-       @${ECHO} "A direct link to the distribution file:"
-       @${ECHO} "http://download.bitdefender.com/freebsd/${BDREL}/beta/${DISTNAME}${EXTRACT_SUFX}"
-       @${ECHO} ""
-       @${ECHO} "Once the file has been downloaded move it to"
-       @${ECHO} "${DISTDIR} and restart the build."
-       @${ECHO} ""
-       @${FALSE}
+.if !exists(${DISTDIR}/${DISTNAME}${EXTRACT_SUFX}) && !defined(PACKAGE_BUILDING)
+ECHO_MSG=/usr/bin/printf
+IGNORE=        :\n\
+You have to fetch ${DISTNAME}${EXTRACT_SUFX} manually after\n\
+reading and agreeing to the license at:\n\
+http://download.bitdefender.com/freebsd/${BDREL}/beta/LICENSE\n\
+A direct link to the distribution file:\n\
+http://download.bitdefender.com/freebsd/${BDREL}/beta/${DISTNAME}${EXTRACT_SUFX}\n\
+Once the file has been downloaded move it to\n\
+${DISTDIR} and restart the build.\n
 .endif

 do-install:--hTklKTW3gRv4Cdm1jjIcjVURiWtcq15JmlohCrJwGhZ76W0s
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile.orig       Fri Aug  5 08:54:53 2005
+++ Makefile    Fri Aug  5 09:13:50 2005
@@ -31,21 +31,16 @@
 ONLY_FOR_ARCHS=        i386
 RESTRICTED=     "License prohibits redistribution"
How-To-Repeat: Delete (if exists) /usr/ports/distfiles/bdc-7.0.1-fbsd5.tar.gz and try to reinstall.
Comment 1 Sam Lawrance freebsd_committer freebsd_triage 2005-08-05 09:24:12 UTC
Responsible Changed
From-To: freebsd-ports-bugs->lawrance

Take
Comment 2 Sam Lawrance freebsd_committer freebsd_triage 2005-08-05 15:37:57 UTC
State Changed
From-To: open->feedback

Can you please confirm that it is OK for the build cluster to automatically 
fetch the bdc distfile?  We need to be sure that there are no legal 
concerns when doing so. 

If not, the best thing to do is to comment out MASTER_SITES and apply the 
patch in the PR.  The build cluster people will then fetch it by hand. 

(eg. see java/jdk14 for a similar example)
Comment 3 Sam Lawrance freebsd_committer freebsd_triage 2005-08-20 09:41:17 UTC
State Changed
From-To: feedback->closed

Committed, thanks!