Bug 84814 - Fix ports/print/psutils to use the correct PERL interpreter
Summary: Fix ports/print/psutils to use the correct PERL interpreter
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: jmz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-11 19:50 UTC by Carlos A M dos Santos
Modified: 2005-08-28 12:34 UTC (History)
0 users

See Also:

Attachments
ports::print::psutils-letter.patch (421 bytes, patch)
2005-08-11 19:50 UTC, Carlos A M dos Santos 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos A M dos Santos 2005-08-11 19:50:05 UTC 
	The "configure" script of the print/psutils-letter port assumes that
	the PERL interpreter is /usr/bin/perl. That is true for FreeBSD 4.X
	but not for 5.X. The attached patch modifies the script to find the
	interpreter at build time.

Fix: Apply the attached patch.
How-To-Repeat: 	Try to build ports/print/psutils-letter or ports/print/psutils-a4 in
	FreeBSD 5.4.
Comment 1 Anton Berezin freebsd_committer freebsd_triage 2005-08-11 20:41:28 UTC 
On Thu, Aug 11, 2005 at 03:42:30PM -0300, Carlos A M dos Santos wrote:

> 	The "configure" script of the print/psutils-letter port assumes that
> 	the PERL interpreter is /usr/bin/perl. That is true for FreeBSD 4.X
> 	but not for 5.X. The attached patch modifies the script to find the
> 	interpreter at build time. 

> --- ports::print::psutils-letter.patch begins here ---
> diff -durP ports.orig/print/psutils-letter/scripts/configure ports/print/psutils-letter/scripts/configure
> --- ports.orig/print/psutils-letter/scripts/configure	Thu Aug  1 21:13:49 1996
> +++ ports/print/psutils-letter/scripts/configure	Thu Aug 11 15:26:04 2005
> @@ -5,7 +5,7 @@
>  BINDIR = $PREFIX/bin
>  INCLUDEDIR = $PREFIX/share/psutils
>  MANDIR =$PREFIX/man/man1
> -PERL = /usr/bin/perl
> +PERL = `which perl`
>  CC=cc
>  END
>  exit 0
> --- ports::print::psutils-letter.patch ends here ---

Make I suggest a better patch instead?

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/print/psutils-letter/Makefile,v
retrieving revision 1.27
diff -u -r1.27 Makefile
--- Makefile	7 Mar 2003 06:09:06 -0000	1.27
+++ Makefile	11 Aug 2005 19:39:53 -0000
@@ -24,6 +24,8 @@
 		fixpspps.1 fixtpps.1 fixwfwps.1 fixwpps.1 fixwwps.1 \
 		extractres.1 includeres.1 fixscribeps.1 psmerge.1
 
+SCRIPTS_ENV+=	PERL=${PERL}
+
 .if !defined(PAPERSIZE)
 PAPERSIZE=letter
 PAPERSIZE_UNSPECIFIED=	yes
Index: scripts/configure
===================================================================
RCS file: /home/ncvs/ports/print/psutils-letter/scripts/configure,v
retrieving revision 1.3
diff -u -r1.3 configure
--- scripts/configure	2 Aug 1996 00:13:49 -0000	1.3
+++ scripts/configure	11 Aug 2005 19:39:57 -0000
@@ -5,7 +5,7 @@
 BINDIR = $PREFIX/bin
 INCLUDEDIR = $PREFIX/share/psutils
 MANDIR =$PREFIX/man/man1
-PERL = /usr/bin/perl
+PERL = $PERL
 CC=cc
 END
 exit 0

Cheers,
\Anton.
-- 
The moronity of the universe is a monotonically increasing function. --
Jarkko Hietaniemi
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2005-08-11 22:08:00 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->jmz

Over to maintainer.
Comment 3 jmz freebsd_committer freebsd_triage 2005-08-28 12:34:02 UTC 
State Changed
From-To: open->closed

Fixed.