The fetch-list target in bsd.port.mk is described as: # fetch-list - Show list of files that would be retrieved by fetch. But when running it, it returns: [/usr/ports/www/squid] root@tim>DISTDIR=/tmp/foo make fetch-list /usr/bin/env /usr/bin/fetch -ARr -S 1069922 ftp://ftp.squid-cache.org/pub/squid-2/STABLE/squid-2.5.STABLE10.tar.bz2 || /usr/bin/env /usr/bin/fetch -ARr -S 1069922 ftp://ftp.unimelb.edu.au/pub/cwis/servers/unix/squid/squid-2/STABLE/squid-2.5.STABLE10.tar.bz2 || /usr/bin/env /usr/bin/fetch -ARr -S 1069922 ftp://sunsite.auc.dk/pub/infosystems/squid/squid [...] That is not how the description describes it, and it neither returns a usable list for users. With the patch applied, it gives a real list: [/usr/ports/www/squid] root@tim>DISTDIR=/tmp/foo make fetch-list http://distfiles.barnet.com.au/distfiles/squid2.5/squid-2.5.STABLE10.tar.bz2 ftp://ftp.squid-cache.org/pub/squid-2/STABLE/squid-2.5.STABLE10.tar.bz2 ftp://ftp.unimelb.edu.au/pub/cwis/servers/unix/squid/squid-2/STABLE/squid-2.5.STABLE10.tar.bz2 ftp://sunsite.auc.dk/pub/infosystems/squid/squid-2/STABLE/squid-2.5.STABLE10.tar.bz2 ftp://ftp.mirrorservice.org/sites/ftp.squid-cache.org/pub/squid-2/STABLE/squid-2.5.STABLE10.tar.bz2 ftp://www.t.ring.gr.jp/pub/net/www/squid/squid-2/STABLE/squid-2.5.STABLE10.tar.bz2 http://www.t.ring.gr.jp/archives/net/www/squid/squid-2/STABLE/squid-2.5.STABLE10.tar.bz2 ftp://ftp.FreeBSD.org/pub/FreeBSD/ports/distfiles/squid2.5/squid-2.5.STABLE10.tar.bz2 And it introduces a new target: fetch-all-list: # fetch-all-list - Show all files which could be fetched. Which does the same as fetch-list but does not ignore the already fetched files.
Responsible Changed From-To: freebsd-ports-bugs->portmgr portmgr tarritory!
State Changed From-To: open->feedback I agree with the intention of your change, but I suspect that the fetch-list target is used by some people with the present behaviour. Can you revise the patch to keep the existing behaviour, fix the docs to note correctly what it does and add a new target that uses your new behaviour?
On Sun, Nov 13, 2005 at 08:12:40PM +0000, Kris Kennaway wrote: > Synopsis: [patch] bsd.port.mk - fetch-list doesn't do as described > > State-Changed-From-To: open->feedback > State-Changed-By: kris > State-Changed-When: Sun Nov 13 20:10:25 GMT 2005 > State-Changed-Why: > I agree with the intention of your change, but I suspect that the > fetch-list target is used by some people with the present behaviour. > Can you revise the patch to keep the existing behaviour, fix the docs > to note correctly what it does and add a new target that uses your new > behaviour? Attached is a patch which - Updates the comments about fetch- targets (still haven't figured out the differences between fetch-recursive and fetch-required). - Adds the fetch-url-list-int target, which is the main target for fetch-url-list and fetch-urlall-target. -- Edwin Groothuis | Personal website: http://www.mavetju.org edwin@mavetju.org | Weblog: http://weblog.barnet.com.au/edwin/
Hi Edwin, What is the situation with this PR?
On Wed, Oct 25, 2006 at 02:58:55PM +0200, Janos Mohacsi wrote: > Hi Edwin, > What is the situation with this PR? Waiting for portmgr Edwin -- Edwin Groothuis | Personal website: http://www.mavetju.org edwin@mavetju.org | Weblog: http://weblog.barnet.com.au/edwin/
State Changed From-To: feedback->open Feedback received.
State Changed From-To: open->analyzed Accepted for a test build on the cluster.
linimon 2007-05-25 00:09:37 UTC FreeBSD ports repository Modified files: . CHANGES Mk bsd.port.mk bsd.port.subdir.mk Log: * Make 'make-deinstall-all' check for moved ports. [1] * Defined the installation directories PORTEXAMPLES and PORTDATA. [2] * Add USE_MAKESELF knob is added for ports that use the makeself archiver. [3] * Update the description of fetch-list; add targets fetch-required-list, fetch-url-list, and fetch-urlall-list. [4] * Make 'make search' also search in ports/MOVED. [5] * Move several Makevar definitions to the pre-makefile section: DATADIR, DOCSDIR, ETCDIR, EXAMPLESDIR, WWWDIR. [6] * The target 'ignorelist-verbose' was added for portsmon. [7] PR: 69965 [1], 78490 [2], 79398 [3], 86776 [4], 104161 [5], 110781 [6] Submitted by: Dancho Penev <dpenev at mnet dot bg> [1], mnag [2], jylefort [3], edwin [4], Lars Engels <lars dot engels at 0x20 dot net> [5], Alexander Logvinov <ports at logvinov dot com> [6], linimon [7] Revision Changes Path 1.70 +23 -1 ports/CHANGES 1.568 +220 -23 ports/Mk/bsd.port.mk 1.70 +34 -5 ports/Mk/bsd.port.subdir.mk _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: analyzed->closed Committed, thanks.