Bug 86962 - p5-DBI-Shell missing dbish from pkg-plist
Summary: p5-DBI-Shell missing dbish from pkg-plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-06 02:20 UTC by mhjacks
Modified: 2005-10-24 09:34 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mhjacks 2005-10-06 02:20:13 UTC
         databases/p5-DBI-Shell-11.93_1 omits bin/dbish preventing packages built from it from having the dbish file installed

Fix: 

0a1
> bin/dbish


Also, to bump PORTVERSION in Makefile:
10c10
< PORTREVISION= 1
---
> PORTREVISION= 2
How-To-Repeat:               cd /usr/ports/databases/p5-DBI-Shell
make package
pkg_info p5-DBI-Shell-11.93_1
Comment 1 Marcus Alves Grando freebsd_committer freebsd_triage 2005-10-06 21:56:34 UTC
Dear maintainer,

Can you investigate this problem?

http://www.freebsd.org/cgi/query-pr.cgi?pr=86962

Thanks

-- 
Marcus Alves Grando
marcus(at)corp.grupos.com.br  |  Grupos Internet S/A
  mnag(at)FreeBSD.org         |  FreeBSD.org
Comment 2 Marcus Alves Grando freebsd_committer freebsd_triage 2005-10-06 21:56:52 UTC
State Changed
From-To: open->feedback

Ask for maintainer approval.
Comment 3 Emanuel Haupt freebsd_committer freebsd_triage 2005-10-23 18:17:58 UTC
State Changed
From-To: feedback->closed

I was not able to reproduce this problem. 

See: http://people.freebsd.org/~ehaupt/buildlogs/
Comment 4 mhjacks 2005-10-23 21:59:11 UTC
ehaupt,

With all due respect, did you look at the pkg contents?  When I built 
the package on one machine, and installed it on a different machine, the 
dbish file itself was missing; presumably because it was not listed in 
pkg-plist.  When you build the package locally, it will be installed, 
but it won't be listed in +CONTENTS.

Thus:

===>  Extracting for p5-DBI-Shell-11.93_1
=> Checksum OK for DBI-Shell-11.93.tar.gz.
===>   p5-DBI-Shell-11.93_1 depends on file: /usr/local/bin/perl5.8.7 - 
found
===>  Patching for p5-DBI-Shell-11.93_1
===>   p5-DBI-Shell-11.93_1 depends on file: /usr/local/bin/perl5.8.7 - 
found
===>   p5-DBI-Shell-11.93_1 depends on file: 
/usr/local/lib/perl5/site_perl/5.8.7/mach/DBI.pm - found
===>   p5-DBI-Shell-11.93_1 depends on file: /usr/local/bin/perl5.8.7 - 
found
===>  Configuring for p5-DBI-Shell-11.93_1
Checking if your kit is complete...
Looks good
Writing Makefile for DBI::Shell
===>  Building for p5-DBI-Shell-11.93_1
cp lib/DBI/Shell.pm blib/lib/DBI/Shell.pm
cp lib/DBI/Format.pm blib/lib/DBI/Format.pm
cp lib/DBI/Shell/Timing.pm blib/lib/DBI/Shell/Timing.pm
cp lib/DBI/Format/SQLMinus.pm blib/lib/DBI/Format/SQLMinus.pm
cp lib/DBI/Shell/SQLMinus.pm blib/lib/DBI/Shell/SQLMinus.pm
cp lib/DBI/Shell/FindSqlFile.pm blib/lib/DBI/Shell/FindSqlFile.pm
cp lib/DBI/Shell/Completion.pm blib/lib/DBI/Shell/Completion.pm
cp lib/DBI/Shell/Spool.pm blib/lib/DBI/Shell/Spool.pm
/usr/local/bin/perl5.8.7 "-Iblib/arch" "-Iblib/lib" dbish.PL dbish
Extracted dbish from dbish.PL with variable substitutions.
cp dbish blib/script/dbish
/usr/local/bin/perl5.8.7 "-MExtUtils::MY" -e "MY->fixin(shift)" 
blib/script/dbish
Manifying blib/man1/dbish.1
Manifying blib/man3/DBI::Shell.3
Manifying blib/man3/DBI::Format.3
Manifying blib/man3/DBI::Format::SQLMinus.3
===>  Installing for p5-DBI-Shell-11.93_1
===>   p5-DBI-Shell-11.93_1 depends on file: 
/usr/local/lib/perl5/site_perl/5.8.7/mach/DBI.pm - found
===>   p5-DBI-Shell-11.93_1 depends on file: 
/usr/local/lib/perl5/site_perl/5.8.7/Text/Reform.pm - found
===>   p5-DBI-Shell-11.93_1 depends on file: 
/usr/local/lib/perl5/site_perl/5.8.7/IO/Tee.pm - found
===>   p5-DBI-Shell-11.93_1 depends on file: /usr/local/bin/perl5.8.7 - 
found
===>   Generating temporary packing list
===>  Checking if databases/p5-DBI-Shell already installed
Installing /usr/local/lib/perl5/site_perl/5.8.7/DBI/Shell.pm
Installing /usr/local/lib/perl5/site_perl/5.8.7/DBI/Format.pm
Installing /usr/local/lib/perl5/site_perl/5.8.7/DBI/Shell/Timing.pm
Installing /usr/local/lib/perl5/site_perl/5.8.7/DBI/Shell/SQLMinus.pm
Installing /usr/local/lib/perl5/site_perl/5.8.7/DBI/Shell/FindSqlFile.pm
Installing /usr/local/lib/perl5/site_perl/5.8.7/DBI/Shell/Completion.pm
Installing /usr/local/lib/perl5/site_perl/5.8.7/DBI/Shell/Spool.pm
Installing /usr/local/lib/perl5/site_perl/5.8.7/DBI/Format/SQLMinus.pm
Installing /usr/local/man/man1/dbish.1
Installing /usr/local/lib/perl5/5.8.7/man/man3/DBI::Shell.3
Installing /usr/local/lib/perl5/5.8.7/man/man3/DBI::Format.3
Installing /usr/local/lib/perl5/5.8.7/man/man3/DBI::Format::SQLMinus.3
Installing /usr/local/bin/dbish
Writing /usr/local/lib/perl5/site_perl/5.8.7/mach/auto/DBI/Shell/.packlist
===>   Compressing manual pages for p5-DBI-Shell-11.93_1
===>   Registering installation for p5-DBI-Shell-11.93_1
===>  Building package for p5-DBI-Shell-11.93_1
Creating package /usr/ports/packages/All/p5-DBI-Shell-11.93_1.tbz
Registering depends: p5-DBI-1.48 p5-IO-Tee-0.64_1 p5-Text-Reform-1.11 
perl-threaded-5.8.7.
Creating bzip'd tar ball in 
'/usr/ports/packages/All/p5-DBI-Shell-11.93_1.tbz'

But, /usr/local/bin/dbish is not included in the file list:
Information for p5-DBI-Shell-11.93_1:

Files:
/usr/local/man/man1/dbish.1.gz
/usr/local/lib/perl5/5.8.7/man/man3/DBI::Format.3.gz
/usr/local/lib/perl5/5.8.7/man/man3/DBI::Format::SQLMinus.3.gz
/usr/local/lib/perl5/5.8.7/man/man3/DBI::Shell.3.gz
/usr/local/lib/perl5/site_perl/5.8.7/DBI/Format.pm
/usr/local/lib/perl5/site_perl/5.8.7/DBI/Shell/Completion.pm
/usr/local/lib/perl5/site_perl/5.8.7/DBI/Shell/SQLMinus.pm
/usr/local/lib/perl5/site_perl/5.8.7/DBI/Shell/Spool.pm
/usr/local/lib/perl5/site_perl/5.8.7/DBI/Shell/Timing.pm
/usr/local/lib/perl5/site_perl/5.8.7/DBI/Shell/FindSqlFile.pm
/usr/local/lib/perl5/site_perl/5.8.7/DBI/Format/SQLMinus.pm
/usr/local/lib/perl5/site_perl/5.8.7/DBI/Shell.pm

The file is installed, but not included in the package tarball.  This is 
what I filed the PR about.  Sorry for any confusion.

Thanks,
Marty
Comment 5 Edwin Groothuis freebsd_committer freebsd_triage 2005-10-23 23:40:15 UTC
State Changed
From-To: closed->open

Please check again. The pkg-plist doesn't support the packaging of 
bin/dbish, it only removes it afterwards if it exists. 



Comment 6 Edwin Groothuis freebsd_committer freebsd_triage 2005-10-23 23:40:15 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ehaupt

over to closer.
Comment 7 Emanuel Haupt freebsd_committer freebsd_triage 2005-10-24 09:28:41 UTC
State Changed
From-To: open->closed

Finally, committed. Sorry for the missunderstanding. Thanks for being 
persistent!