When upgrading the www/drupal port from 4.6.2 to 4.6.3 (for example using portupgrade), the Makefile runs commands such as this: ${CP} -R ${WRKSRC}/themes ${PREFIX}/${DRUPDIR} The effect is to delete all existing configuration files and changes made to the Drupal installation. Fix: A different approach is needed for the installation phase. The databases/phpmyadmin port does this: install-app: cd ${WRKSRC} ; \ for src in $$( ${FIND} . ! -name .cvsignore ) ; do \ dst=${PREFIX}/${MYADMDIR}$${src#.} ; \ if ${TEST} -d $$src ; then \ ${MKDIR} $$dst ; \ else \ ${INSTALL_DATA} $$src $$dst ; \ fi \ done The net effect is that existing configuration files and directories are not deleted. How-To-Repeat: Upgrade Drupal.
Maintainer of www/drupal, Please note that PR ports/88388 just has been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/88388 -- Edwin Groothuis edwin@FreeBSD.org
State Changed From-To: open->feedback Ask for maintainer fix.
State Changed From-To: feedback->open Maintainer was reset due to inactivity.
State Changed From-To: open->feedback You do store your configuration under themes/ dir? Why? If you modify one of the supplied theme, why about renaming it to a new name? Then port will not touch it on updates.
Fair enough, themes are not the problem. However, this file is: /usr/local/www/data/drupal/sites/default/settings.php We shouldn't be overwriting the default settings file each time Drupal is updated. Or at the least, the port should contain clear instructions that this file should be immediately copied and moved. Couldn't we just save the settings file to /usr/local/www/data/drupal/sites/default/settings.php-dist if one already exists...
> Fair enough, themes are not the problem. However, this file is: > > /usr/local/www/data/drupal/sites/default/settings.php > > We shouldn't be overwriting the default settings file each time > Drupal is updated. Or at the least, the port should contain clear > instructions that this file should be immediately copied and moved. > Couldn't we just save the settings file to > > /usr/local/www/data/drupal/sites/default/settings.php-dist > > if one already exists... Can you provide a committable patch to do that? -- Pav Lucistnik <pav@oook.cz> <pav@FreeBSD.org> Just because you're an angel doesn't mean you have to be a fool.
State Changed From-To: feedback->closed I implemented special handling of settings.php