Bug 88968 - [patch] comms/birda unexpire
Summary: [patch] comms/birda unexpire
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-14 03:00 UTC by mjl
Modified: 2005-11-24 06:44 UTC (History)
0 users

See Also:


Attachments
file.diff (1.62 KB, patch)
2005-11-14 03:00 UTC, mjl
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mjl 2005-11-14 03:00:30 UTC
PR 88049 marked comms/birda as deprecated because the old distfile is
no longer available on NetBSD's ftp server.  This is because they now
ship birda-1.1

This patch updates the port to 1.1, unbreaking birda.  I use this port
routinely and would hate to see it gone.

I would be happy to be maintainer of birda if current maintainer has no
interest maintaining it.

How-To-Repeat: N/A
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2005-11-14 03:03:14 UTC
Maintainer of comms/birda,

Please note that PR ports/88968 just has been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/88968

-- 
Edwin Groothuis
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2005-11-14 03:23:29 UTC
Maintainer of comms/birda,

Please note that PR ports/88968 just has been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/88968

-- 
Edwin Groothuis
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2005-11-14 03:24:18 UTC
Maintainer of comms/birda,

Please note that PR ports/88968 just has been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/88968

-- 
Edwin Groothuis
edwin@FreeBSD.org
Comment 4 Marcus Alves Grando freebsd_committer freebsd_triage 2005-11-14 04:33:30 UTC
State Changed
From-To: open->feedback

Ask for maintainer approval.
Comment 5 mjl 2005-11-14 19:23:24 UTC
two releases of birda were released overnight.  the first addressed
the use of log(), which gcc-3 complained about, and fixed the
use-after-free bug addressed by freebsd's patch-iassrv.c

the second release adds a driver for redlink-105

http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/comms/birda/Makefile

Please consider this patch instead of the one in the PR.

Finally, I am aware that the ftp.augustsson.net mirror is not very
quick, and that it was removed from the port in ports/47947; at
the moment, the new birda release has not made its way to NetBSD's
FTP service.

Thanks

Matthew

diff -uNr birda.orig/Makefile birda/Makefile
--- birda.orig/Makefile Fri Nov  4 17:07:14 2005
+++ birda/Makefile      Tue Nov 15 08:06:35 2005
@@ -6,16 +6,13 @@
 #
 
 PORTNAME=      birda
-PORTVERSION=   1.00
-PORTREVISION=  2
+PORTVERSION=   1.3
 CATEGORIES=    comms
-MASTER_SITES=  ftp://ftp.netbsd.org/pub/NetBSD/packages/distfiles/
+MASTER_SITES=  ftp://ftp.augustsson.net/pub/netbsd/ \
+               ftp://ftp.netbsd.org/pub/NetBSD/packages/distfiles/
 
 MAINTAINER=    allbery@ece.cmu.edu
 COMMENT=       Bohlin's IrDA utilities, ported from NetBSD's pkgsrc
-
-DEPRECATED=    "mastersite disappeared, no longer maintained by author"
-EXPIRATION_DATE=       2005-12-31
 
 MAN1=          ircomm.1 irobex.1 irs.1 \
                mkobexcard.1 mkobexdate.1 mkobexmemo.1 mkobexpdb.1 \
diff -uNr birda.orig/distinfo birda/distinfo
--- birda.orig/distinfo Fri Mar 19 06:59:56 2004
+++ birda/distinfo      Tue Nov 15 08:06:59 2005
@@ -1,2 +1,3 @@
-MD5 (birda-1.00.tar.gz) = 0f847c3bbeadb388bdb9bc438d2dcc6b
-SIZE (birda-1.00.tar.gz) = 56074
+MD5 (birda-1.3.tar.gz) = da9d3a9859fbcf41d3eece2ecdb68c3c
+SHA256 (birda-1.3.tar.gz) = 168ed16ad3acc3dce4b2e8743f7dfa6c4cf7203c18926e0931e
4b2614e89c833
+SIZE (birda-1.3.tar.gz) = 57848
diff -uNr birda.orig/files/patch-iassrv.c birda/files/patch-iassrv.c
--- birda.orig/files/patch-iassrv.c     Thu Jul 17 00:21:07 2003
+++ birda/files/patch-iassrv.c  Thu Jan  1 12:00:00 1970
@@ -1,22 +0,0 @@
---- src/iassrv.c.orig  Sun Dec 16 19:22:20 2001
-+++ src/iassrv.c       Wed Jul 16 14:08:55 2003
-@@ -281,6 +281,7 @@
- 
- static void status(Connection* con, int event, void* buf, int len)
- {
-+  int flags;
-   IASConnection* ic=(IASConnection*)con->handle;
- 
-   if(event==CONN_CLOSED) {
-@@ -300,9 +301,10 @@
- 
-     if(ic->outBuf) freeMem(ic->outBuf);
-     if(ic->inBuf) freeMem(ic->inBuf);
-+    flags = ic->ias->ias.debug&IAS_DEBUG_INFO;
-     freeMem(ic);
-     connClose(con);
--    if(ic->ias->ias.debug&IAS_DEBUG_INFO) log("ias closed\n");
-+    if(flags) log("ias closed\n");
-   }
- }
- 
diff -uNr birda.orig/files/patch-lib-Makefile birda/files/patch-lib-Makefile
--- birda.orig/files/patch-lib-Makefile Thu Jan  1 12:00:00 1970
+++ birda/files/patch-lib-Makefile      Mon Nov 14 10:47:33 2005
@@ -0,0 +1,9 @@
+--- lib/Makefile.orig  Mon Nov 14 10:43:07 2005
++++ lib/Makefile       Mon Nov 14 10:42:14 2005
+@@ -9,4 +9,6 @@
+ NOPIC=                yes
+ MKLINKLIB=    no
+ 
++install:
++
+ .include <bsd.lib.mk>
Comment 6 Edwin Groothuis freebsd_committer freebsd_triage 2005-11-24 06:44:00 UTC
State Changed
From-To: feedback->closed

Committed, thanks!