Bug 89010 - ports/devel/bazaar Makefile wrong quotes
Summary: ports/devel/bazaar Makefile wrong quotes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Simon Barner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-14 15:50 UTC by Andreas Schulz
Modified: 2005-11-28 18:40 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Schulz 2005-11-14 15:50:19 UTC
A make checksum fails in ports/devel/bazaar on a 4.11 System.
===> devel/bazaar
Syntax error: "(" unexpected
*** Error code 2

Fix: 

The Makefile need to be changed to:
.if ${OSVERSION} < 500000
IGNORE=         "does not compile (missing va_copy)"
.endif

The double quotes needs to be changed to single quotes.
Otherwise the shell will interpret the brackets.
How-To-Repeat: Try a make checksum on an old system :-).
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2005-11-14 20:57:05 UTC
Maintainer of devel/bazaar,

Please note that PR ports/89010 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/89010

-- 
Edwin Groothuis
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2005-11-14 21:10:24 UTC
State Changed
From-To: open->feedback
Comment 3 Simon Barner freebsd_committer freebsd_triage 2005-11-28 18:10:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->barner

I'll take it.
Comment 4 Simon Barner freebsd_committer freebsd_triage 2005-11-28 18:40:11 UTC
State Changed
From-To: feedback->closed

I entirely removed the quotes: IGNORE messages will expand to ${PKGNAME} 
${IGNORE}. So using quotes makes no sense (and this is why the messages 
should start with a small letter and why they should not end with a full 
stop, which is printed by bsd.port.mk). But thanks for the report!