Bug 91154 - [patch] www/apache22: Add profile support, prevent reload/restart when httpd not running and various tweaks
Summary: [patch] www/apache22: Add profile support, prevent reload/restart when httpd ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Clement Laforet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-01 05:00 UTC by Jarrod Sayers
Modified: 2006-01-15 18:43 UTC (History)
1 user (show)

See Also:

Attachments
www-apache22-files-apache.sh.diff (6.06 KB, patch)
2006-01-01 05:00 UTC, Jarrod Sayers 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jarrod Sayers 2006-01-01 05:00:13 UTC 
Various suggested changes to ports/www/apache22/files/apache.sh, including:
- Rearranging and tidy up of apache.sh descriptions, including minor alterations
  to terminology and formatting to make it a little easier to read.
- Add configtest to extra_commands to allow testing of configs.  Handy command
  especially when used in conjunction with profiles as apachectl does not support
  the overriding of a file to test (must use 'httpd -f ... -t' instead).
- Add support for apache22 profiles (inspired by www/apache20).
- Add apache22_requirepidfile function to check for running process.
- Prevent reload/restart when httpd process not running.  Required as script
  execution with reload/restart without running processes actually starts
  them, without any additional options (like -DNOHTTPACCEPT or profile info).
- Force apache22_checkconfig when start issued (config not currently tested on
  start's, only used on reload and restart).

Fix: Diff obtainable from:
http://www.netleader.com.au/~jarrod/freebsd/www-apache22-files-apache.sh.diff
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-01-01 05:05:55 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->clement

Over to maintainer
Comment 2 Jarrod Sayers 2006-01-01 05:54:24 UTC 
Diff located at URL listed in original PR should be used instead of  
one attached.  A slight modification to the handling of the restart  
command when profiles are used prevents the script from failing when  
etc/apache22/httpd.conf doesn't exist.

Jarrod.
Comment 3 Jarrod Sayers 2006-01-01 06:01:04 UTC 
Diff located at URL listed in original PR should be used instead of  
one attached.  A slight modification to the handling of the restart  
command when profiles are used prevents the script from failing when  
etc/apache22/httpd.conf doesn't exist.

Jarrod.
Comment 4 Clement Laforet freebsd_committer freebsd_triage 2006-01-15 18:43:00 UTC 
State Changed
From-To: open->closed

Committed, thanks.