Bug 91325 - [Maintainer Update] change PORTNAME to kde-*-* (several ports)
Summary: [Maintainer Update] change PORTNAME to kde-*-* (several ports)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-04 23:50 UTC by Shane Bell
Modified: 2006-01-05 05:10 UTC (History)
0 users

See Also:


Attachments
file.diff (5.51 KB, patch)
2006-01-04 23:50 UTC, Shane Bell
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shane Bell 2006-01-04 23:50:02 UTC
- Change the PORTNAME to kde-*-* for consistancy with other theme ports.
- A couple of small tidy-ups
Comment 1 edwin 2006-01-05 00:09:35 UTC
On Wed, Jan 04, 2006 at 11:46:20PM +0000, decept wrote:
> -PORTNAME=	comix
> +PORTNAME=	kde-style-comix
>  PORTVERSION=	1.3.6
> +PORTREVISION=   1
>  CATEGORIES=	x11-themes kde
>  MASTER_SITES=	http://www.kde-look.org/content/files/
> -DISTNAME=	16028-${PORTNAME}-${PORTVERSION}
> +DISTNAME=	16028-comix-${PORTVERSION}
>  
>  MAINTAINER=	decept0@gmail.com
>  COMMENT=	Flat KDE style and window decoration
> @@ -18,6 +19,6 @@
>  USE_GMAKE=	yes
>  USE_KDEBASE_VER=3
>  GNU_CONFIGURE=	yes
> -WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
> +WRKSRC=		${WRKDIR}/comix-${PORTVERSION}
[..]

don't you think that "PKGNAMEPREFIX=kde-style-" is a better approach
here?

Ewdin
-- 
Edwin Groothuis      |            Personal website: http://www.mavetju.org
edwin@mavetju.org    |          Weblog: http://weblog.barnet.com.au/edwin/
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2006-01-05 03:13:07 UTC
State Changed
From-To: open->feedback

Question aksed.
Comment 3 Shane Bell 2006-01-05 03:17:50 UTC
On Thu, 05 Jan 2006 13:09, Edwin Groothuis wrote:
> On Wed, Jan 04, 2006 at 11:46:20PM +0000, decept wrote:
> > -PORTNAME=	comix
> > +PORTNAME=	kde-style-comix
> >  PORTVERSION=	1.3.6
> > +PORTREVISION=   1
> >  CATEGORIES=	x11-themes kde
> >  MASTER_SITES=	http://www.kde-look.org/content/files/
> > -DISTNAME=	16028-${PORTNAME}-${PORTVERSION}
> > +DISTNAME=	16028-comix-${PORTVERSION}
> >
> >  MAINTAINER=	decept0@gmail.com
> >  COMMENT=	Flat KDE style and window decoration
> > @@ -18,6 +19,6 @@
> >  USE_GMAKE=	yes
> >  USE_KDEBASE_VER=3
> >  GNU_CONFIGURE=	yes
> > -WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
> > +WRKSRC=		${WRKDIR}/comix-${PORTVERSION}
>
> [..]
>
> don't you think that "PKGNAMEPREFIX=kde-style-" is a better approach
> here?
>
> Ewdin

Yes, yes it would so here is a new diff.

Cheers,
Shane

--diff begins here--

diff -ruN /usr/ports/x11-themes/kde-style-comix/Makefile 
kde-style-comix/Makefile
--- /usr/ports/x11-themes/kde-style-comix/Makefile	Thu Dec  8 11:54:48 2005
+++ kde-style-comix/Makefile	Thu Jan  5 15:15:51 2006
@@ -7,9 +7,11 @@
 
 PORTNAME=	comix
 PORTVERSION=	1.3.6
+PORTREVISION=   1
 CATEGORIES=	x11-themes kde
 MASTER_SITES=	http://www.kde-look.org/content/files/
-DISTNAME=	16028-${PORTNAME}-${PORTVERSION}
+PKGNAMEPREFIX=	kde-style-
+DISTNAME=	16028-comix-${PORTVERSION}
 
 MAINTAINER=	decept0@gmail.com
 COMMENT=	Flat KDE style and window decoration
diff -ruN /usr/ports/x11-themes/kde-windeco-knifty/Makefile 
kde-windeco-knifty/Makefile
--- /usr/ports/x11-themes/kde-windeco-knifty/Makefile	Sat Nov 12 15:39:43 2005
+++ kde-windeco-knifty/Makefile	Thu Jan  5 15:45:24 2006
@@ -7,24 +7,19 @@
 
 PORTNAME=	knifty
 PORTVERSION=	0.4.2
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	x11-themes kde
 MASTER_SITES=	http://kde-look.org/content/files/
-DISTNAME=	8841-${PORTNAME}-${PORTVERSION}
+PKGNAMEPREFIX=	kde-windeco-
+DISTNAME=	8841-knifty-${PORTVERSION}
 
 MAINTAINER=	decept0@gmail.com
 COMMENT=	Lightweight KDE window decoration
 
 USE_BZIP2=	yes
 USE_KDEBASE_VER=3
-USE_REINPLACE=	yes
+CONFIGURE_ENV+= LDFLAGS=${PTHREAD_LIBS}
 GNU_CONFIGURE=	yes
 WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
-
-post-patch:
-	@${REINPLACE_CMD} -e 's|-lkdeui|-lkdeui ${PTHREAD_LIBS}|g' \
-		${WRKSRC}/${CONFIGURE_SCRIPT}
-	@${REINPLACE_CMD} -e 's|-lkdecore|-lkdecore ${PTHREAD_LIBS}|g' \
-		${WRKSRC}/client/Makefile.in
 
 .include <bsd.port.mk>
diff -ruN /usr/ports/x11-themes/kde-style-lipstik/Makefile 
kde-style-lipstik/Makefile
--- /usr/ports/x11-themes/kde-style-lipstik/Makefile	Wed Dec 14 19:06:53 2005
+++ kde-style-lipstik/Makefile	Thu Jan  5 15:20:00 2006
@@ -7,24 +7,19 @@
 
 PORTNAME=	lipstik
 PORTVERSION=	2.1
+PORTREVISION=	1
 CATEGORIES=	x11-themes kde
 MASTER_SITES=	http://www.kde-look.org/content/files/
-DISTNAME=	18223-${PORTNAME}-${PORTVERSION}
+PKGNAMEPREFIX=	kde-style-
+DISTNAME=	18223-lipstik-${PORTVERSION}
 
 MAINTAINER=	decept0@gmail.com
 COMMENT=	Modified Plastik KDE style
 
 USE_BZIP2=	yes
 USE_KDEBASE_VER=3
-USE_REINPLACE=	yes
+CONFIGURE_ENV+= LDFLAGS=${PTHREAD_LIBS}
 GNU_CONFIGURE=	yes
 WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
-
-post-patch:
-	@${REINPLACE_CMD} -e 's|-lkdefx|-lkdefx ${PTHREAD_LIBS}|g' \
-		${WRKSRC}/style/Makefile.in
-post-configure:
-	@${REINPLACE_CMD} -e 's|-ljpeg|-ljpeg ${PTHREAD_LIBS}|g' \
-		${WRKSRC}/style/config/Makefile
 
 .include <bsd.port.mk>
diff -ruN /usr/ports/x11-themes/kde-windeco-neos/Makefile 
kde-windeco-neos/Makefile
--- /usr/ports/x11-themes/kde-windeco-neos/Makefile	Sat Nov 12 15:39:43 2005
+++ kde-windeco-neos/Makefile	Thu Jan  5 15:54:33 2006
@@ -7,10 +7,11 @@
 
 PORTNAME=	neos
 PORTVERSION=	0.2b
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	x11-themes kde
 MASTER_SITES=	http://perso.wanadoo.fr/chamayou/
-DISTNAME=	kwin-${PORTNAME}-${PORTVERSION}
+PKGNAMEPREFIX=	kde-windeco-
+DISTNAME=	kwin-neos-${PORTVERSION}
 
 MAINTAINER=	decept0@gmail.com
 COMMENT=	KDE window decoration
@@ -18,6 +19,5 @@
 USE_BZIP2=      yes
 USE_KDEBASE_VER=3
 GNU_CONFIGURE=	yes
-WRKSRC=		${WRKDIR}/kwin-${PORTNAME}-${PORTVERSION}
 
 .include <bsd.port.mk>
diff -ruN /usr/ports/x11-themes/kde-windeco-smoothblend/Makefile 
kde-windeco-smoothblend/Makefile
--- /usr/ports/x11-themes/kde-windeco-smoothblend/Makefile	Sat Nov 12 15:39:43 
2005
+++ kde-windeco-smoothblend/Makefile	Thu Jan  5 15:58:52 2006
@@ -7,9 +7,10 @@
 
 PORTNAME=	smoothblend
 PORTVERSION=	1.2
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	x11-themes kde
 MASTER_SITES=	http://www.p0z3r.org/downloads/
+PKGNAMEPREFIX=	kde-windeco-
 DISTNAME=	smooth-blend-${PORTVERSION}
 
 MAINTAINER=	decept0@gmail.com
@@ -19,6 +20,5 @@
 USE_GMAKE=	yes
 USE_KDEBASE_VER=3
 GNU_CONFIGURE=	yes
-WRKSRC=		${WRKDIR}/smooth-blend-${PORTVERSION}
 
 .include <bsd.port.mk>
diff -ruN /usr/ports/x11-themes/kde-style-tiblit/Makefile 
kde-style-tiblit/Makefile
--- /usr/ports/x11-themes/kde-style-tiblit/Makefile	Sat Nov 12 15:39:43 2005
+++ kde-style-tiblit/Makefile	Thu Jan  5 15:43:20 2006
@@ -7,22 +7,19 @@
 
 PORTNAME=	tiblit
 PORTVERSION=	1.2
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	x11-themes
 MASTER_SITES=	http://www.kde-look.org/content/files/
-DISTNAME=	20798-${PORTNAME}-${PORTVERSION}
+PKGNAMEPREFIX=	kde-style-
+DISTNAME=	20798-tiblit-${PORTVERSION}
 
 MAINTAINER=	decept0@gmail.com
 COMMENT=	KDE style focused on customization
 
 USE_BZIP2=	yes
 USE_KDEBASE_VER=3
-USE_REINPLACE=	yes
+CONFIGURE_ENV+= LDFLAGS=${PTHREAD_LIBS}
 GNU_CONFIGURE=	yes
 WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
-
-post-patch:
-	@${REINPLACE_CMD} -e 's|-lkdefx|-lkdefx ${PTHREAD_LIBS}|g' \
-		${WRKSRC}/widget-engine/Makefile.in
 
 .include <bsd.port.mk>
Comment 4 Edwin Groothuis freebsd_committer freebsd_triage 2006-01-05 05:10:47 UTC
State Changed
From-To: feedback->closed

Committed, thanks!