Bug 91962 - [patch] Fix missing dependancy in www/cadaver
Summary: [patch] Fix missing dependancy in www/cadaver
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Vasil Dimov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-18 16:10 UTC by Josh Paetzel
Modified: 2006-02-07 17:23 UTC (History)
0 users

See Also:


Attachments
Makefile.diff (291 bytes, patch)
2006-01-26 15:59 UTC, Josh Paetzel <josh@tcbug.org>
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Josh Paetzel 2006-01-18 16:10:07 UTC

www/cadaver/Makefile is missing the gettext dependancy...installing cadaver without having devel/gettext installed previously fails.

Fix: Apply the following patch to www/cadaver/Makefile

$ cat Makefile.diff


USE_GPG?=      yes
+USE_GETTEXT=   yes
 SIG_FILES=     ${DISTNAME}${EXTRACT_SUFX}.asc
 USE_GETOPT_LONG=       yes
 GNU_CONFIGURE= yes--Oae7QRUidP621X5TNNskb0ncft5nyGRr0sxUiOBZ3XwVYVLm
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile.old        Wed Jan 18 09:46:56 2006
+++ Makefile    Wed Jan 18 09:47:10 2006
@@ -19,6 +19,7 @@
 LIB_DEPENDS=   neon.25:${PORTSDIR}/www/neon
How-To-Repeat: 

Make sure deve/gettext isn't installed and try installing www/cadaver
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-01-18 21:44:02 UTC
Class Changed
From-To: maintainer-update->change-request

Fix category (submitter is not maintainer)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2006-01-18 21:44:10 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 3 Josh Paetzel <josh@tcbug.org> 2006-01-19 03:11:44 UTC
On Wednesday 18 January 2006 15:44, Edwin Groothuis wrote:
> Maintainer of www/cadaver,
>
> Please note that PR ports/91962 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the
> patch and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/91962

Yes, I agree to this patch (I'm the one who submitted it)

>Class-Changed-From-To: maintainer-update->change-request 
>Class-Changed-By: edwin 
>Class-Changed-When: Wed Jan 18 21:44:02 UTC 2006 
>Class-Changed-Why:  
>Fix category (submitter is not maintainer) 

I am the maintainer.

-- 
Thanks,

Josh Paetzel
Comment 4 Edwin Groothuis freebsd_committer freebsd_triage 2006-01-19 05:49:53 UTC
State Changed
From-To: feedback->open

Submitter is maintainer (please use correct email address next time 
to speed up the process) 


Comment 5 Edwin Groothuis freebsd_committer freebsd_triage 2006-01-19 05:49:53 UTC
Class Changed
From-To: change-request->maintainer-update

Comment 6 Edwin Groothuis freebsd_committer freebsd_triage 2006-01-19 11:27:26 UTC
State Changed
From-To: open->feedback

Leftover files: 

-r--r--r-- 1 root  wheel  13745 Jan 19 11:25 usr/local/share/locale/es/LC_MESSAGES/cadaver.mo 
-r--r--r-- 1 root  wheel  13885 Jan 19 11:25 usr/local/share/locale/it/LC_MESSAGES/cadaver.mo 
-r--r--r-- 1 root  wheel  26663 Jan 19 11:25 usr/local/share/locale/en@quot/LC_MESSAGES/cadaver.mo 

Are you sure that en@quot is a proper line?
Comment 7 Josh Paetzel <josh@tcbug.org> 2006-01-20 02:20:28 UTC
On Thursday 19 January 2006 05:28, you wrote:
> Synopsis: [patch]  Fix missing dependancy in www/cadaver
>
> State-Changed-From-To: open->feedback
> State-Changed-By: edwin
> State-Changed-When: Thu Jan 19 11:27:26 UTC 2006
> State-Changed-Why:
> Leftover files:
>
> -r--r--r-- 1 root  wheel  13745 Jan 19 11:25
> usr/local/share/locale/es/LC_MESSAGES/cadaver.mo -r--r--r-- 1 root 
> wheel  13885 Jan 19 11:25
> usr/local/share/locale/it/LC_MESSAGES/cadaver.mo -r--r--r-- 1 root 
> wheel  26663 Jan 19 11:25
> usr/local/share/locale/en@quot/LC_MESSAGES/cadaver.mo
>
> Are you sure that en@quot is a proper line?
>
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=91962

I think I'm a tad confused.  If I reply to the mail you sent me it 
goes to  freebsd-ports-bugs@FreeBSD.org

If I submit a followup to the PR it points to bug-followup@freebsd.org

Which of the two would be appropriate?

In the meantime kris@ has marked the port as broken.  (Yes, I've taken 
took much time to deal with this)  Should I modify the patch to 
remove the BROKEN tag or is that worthy of a different PR?  Thanks 
for your patience and help, I'm slowly but surely getting up to speed 
on this port maintainer thing. :)

-- 
Thanks,

Josh Paetzel
Comment 8 edwin 2006-01-20 02:30:30 UTC
On Thu, Jan 19, 2006 at 08:20:28PM -0600, Josh Paetzel wrote:
> Which of the two would be appropriate?

ports-bugs-followup it more appropriate.

> In the meantime kris@ has marked the port as broken.  (Yes, I've taken 
> took much time to deal with this)  Should I modify the patch to 
> remove the BROKEN tag or is that worthy of a different PR?  Thanks 
> for your patience and help, I'm slowly but surely getting up to speed 
> on this port maintainer thing. :)

If you say that the file directory "en@quote" is correct then I'll
submit the fixes, and remove the BROKEN line.

Edwin
-- 
Edwin Groothuis      |            Personal website: http://www.mavetju.org
edwin@mavetju.org    |          Weblog: http://weblog.barnet.com.au/edwin/
Comment 9 Josh Paetzel <josh@tcbug.org> 2006-01-26 15:59:21 UTC
On Thursday 19 January 2006 05:28, you wrote:
> Synopsis: [patch]  Fix missing dependancy in www/cadaver
>
> State-Changed-From-To: open->feedback
> State-Changed-By: edwin
> State-Changed-When: Thu Jan 19 11:27:26 UTC 2006
> State-Changed-Why:
> Leftover files:
>
> -r--r--r-- 1 root  wheel  13745 Jan 19 11:25
> usr/local/share/locale/es/LC_MESSAGES/cadaver.mo -r--r--r-- 1 root 
> wheel  13885 Jan 19 11:25
> usr/local/share/locale/it/LC_MESSAGES/cadaver.mo -r--r--r-- 1 root 
> wheel  26663 Jan 19 11:25
> usr/local/share/locale/en@quot/LC_MESSAGES/cadaver.mo
>
> Are you sure that en@quot is a proper line?
>
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=91962

Here's the patch that will get cadaver working again.  

-- 
Thanks,

Josh Paetzel
Comment 10 Vasil Dimov freebsd_committer freebsd_triage 2006-02-07 15:19:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->vd

I will take it
Comment 11 Vasil Dimov freebsd_committer freebsd_triage 2006-02-07 17:16:45 UTC
State Changed
From-To: feedback->closed

Patch in ports/91756 which includes these changes has been committed, thanks!