package maintainers changed arch directory naming, adding system version number. How-To-Repeat: Try to install latest release.
Responsible Changed From-To: freebsd-ports-bugs->garga I'll take it.
Since i'm here, i propose you the following patch, that pacify portlint(1) using EXAMPLESDIR macro, unquoting RESTRICTED/BROKEN, s/env${SETENV}/ Please take a look and tell me if you approve this. --------------------------------------------------- Index: Makefile =================================================================== RCS file: /home/pcvs/ports/shells/ksh93/Makefile,v retrieving revision 1.42 diff -u -r1.42 Makefile --- Makefile 31 Jan 2006 15:07:06 -0000 1.42 +++ Makefile 3 Feb 2006 14:29:04 -0000 @@ -7,7 +7,6 @@ PORTNAME= ksh93 PORTVERSION= ${VERSION:S/-//g} CATEGORIES= shells -FETCH_ENV= HTTP_AUTH='basic:*:I accept www.opensource.org/licenses/cpl:.' MASTER_SITES= http://www.research.att.com/~gsf/download/tgz/ DISTNAME= ${PORTNAME}-${VERSION} DISTFILES= INIT.${VERSION}.tgz ast-ksh.${VERSION}.tgz @@ -17,8 +16,9 @@ COMMENT= Official AT&T release of KornShell 93 VERSION= 2006-01-24 -RESTRICTED= "Source recipient must acknowledge license" +RESTRICTED= Source recipient must acknowledge license +FETCH_ENV= HTTP_AUTH='basic:*:I accept www.opensource.org/licenses/cpl:.' FETCH_CMD= /usr/bin/fetch -Rr # see bin/76134 NO_WRKSUBDIR= yes MAKE_ENV= CCFLAGS="${CFLAGS}" SHELL="${SH}" @@ -27,16 +27,16 @@ .endif MAN1= ksh93.1 -INSTALLROOT= ${WRKSRC}/arch/freebsd.${ARCH} +INSTALLROOT= ${WRKSRC}/arch/freebsd${OSREL:R}.${ARCH} .include <bsd.port.pre.mk> .if ${ARCH} == "sparc64" -BROKEN= "Does not compile on sparc64" +BROKEN= Does not compile on sparc64 .endif do-build: - @cd ${WRKSRC} && env -i ${MAKE_ENV} ${SH} bin/package make + @cd ${WRKSRC} && ${SETENV} -i ${MAKE_ENV} ${SH} bin/package make do-install: ${INSTALL_PROGRAM} ${INSTALLROOT}/bin/ksh ${PREFIX}/bin/ksh93 Index: pkg-plist =================================================================== RCS file: /home/pcvs/ports/shells/ksh93/pkg-plist,v retrieving revision 1.7 diff -u -r1.7 pkg-plist --- pkg-plist 18 Mar 2004 01:51:29 -0000 1.7 +++ pkg-plist 3 Feb 2006 14:29:04 -0000 @@ -2,7 +2,7 @@ bin/ksh93 @exec echo "updating /etc/shells"; cp /etc/shells /etc/shells.bak; (grep -v %D/%F /etc/shells.bak; echo %D/%F) >/etc/shells; rm -f /etc/shells.bak @unexec echo "updating /etc/shells"; cp /etc/shells /etc/shells.bak; (grep -v %D/%F /etc/shells.bak) >/etc/shells; rm -f /etc/shells.bak -share/examples/ksh93/dirs -share/examples/ksh93/popd -share/examples/ksh93/pushd -@dirrm share/examples/ksh93 +%%EXAMPLESDIR%%/dirs +%%EXAMPLESDIR%%/popd +%%EXAMPLESDIR%%/pushd +@dirrm %%EXAMPLESDIR%% ---------------------------------------------------
State Changed From-To: open->feedback Ask for maintainer approval.
Dear maintainer, I got an error: install -s -o root -g wheel -m 555 /work/a/ports/shells/ksh93/work/arch/freebsd6.i386/bin/ksh /usr/local/bin/ksh93 install: /work/a/ports/shells/ksh93/work/arch/freebsd6.i386/bin/ksh: No such file or directory *** Error code 71 It happened because the dir created is freebsd.i386 and not freebsd6.i386, so, the change that you propose seems to be not necessary. Could you investigate please? -- Renato Botelho <garga @ FreeBSD.org> <freebsd @ galle.com.br> GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc
On Fri, 2006-02-03 at 13:54 -0200, Renato Botelho wrote: > Dear maintainer, > > I got an error: > > install -s -o root -g wheel -m 555 > /work/a/ports/shells/ksh93/work/arch/freebsd6.i386/bin/ksh > /usr/local/bin/ksh93 > install: /work/a/ports/shells/ksh93/work/arch/freebsd6.i386/bin/ksh: > No such file or directory > *** Error code 71 > > It happened because the dir created is freebsd.i386 and not > freebsd6.i386, so, the change that you propose seems to be not > necessary. > > Could you investigate please? I submitted a bug report to Glenn Fowler. He added the OSREL stuff to his package script because of problems in version 5, but he didn't account for later versions. I have a proposed change from him that I either need to manually add to package or wait for him to rerelease it. I'll let you know some time next week. Before that, you could put a test in the Makefile to check for OSREL < 6.0 and use the numbered arch directory there and no number for OSREL >= 6. What a mess, but I should have a more permanent fix within a couple of days. Your other proposed changes seem fine. /Joe
Glenn Fowler has promised a fix for this sometime next week. For now, just mark OSREL >= 6.0 as broken and we will get a fix "real soon now". /Joe
Sorry, I tested this port on i386, RELENG_4, RELENG_5, RELENG_6 and on amd64-current and it always created arch/freebsd.(i386|amd64) without OSREL, so, there is no problem on the port. Could I commit just the changes that I proposed and you approved? Thanks -- Renato Botelho <garga @ FreeBSD.org> <freebsd @ galle.com.br> GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc
On Thu, 2006-02-09 at 16:16 -0200, Renato Botelho wrote: > Sorry, I tested this port on i386, RELENG_4, RELENG_5, RELENG_6 and > on amd64-current and it always created arch/freebsd.(i386|amd64) > without OSREL, so, there is no problem on the port. > > Could I commit just the changes that I proposed and you approved? If the version you tested does not set freebsd4.i386 or freebsd5.i386 as the arch directory when building, then you are testing with incorrect *.tgz files. As released, the port might build on 6 or 7 but will not install. Glenn Fowler says that he expects a release early next week. You can release any version of the Makefile that you choose to release. If the version you release causes trouble, I have already stated why it cannot work until the rerelease of the source. /Joe
Em 10/2/2006 03:06 Joe Kelsey escreveu: > If the version you tested does not set freebsd4.i386 or freebsd5.i386 as > the arch directory when building, then you are testing with incorrect > *.tgz files. I cleaned all my environment and tested it again on FreeBSD 4, 5 and 6. I download these 2 tgz files: http://www.research.att.com/~gsf/download/tgz/INIT.2006-01-24.tgz http://www.research.att.com/~gsf/download/tgz/ast-ksh.2006-01-24.tgz and built fine on 3 FreeBSD versions creating arch/freebsd.i386 dir. You can see all buildlogs on: http://srvmix.galle.com.br/tb/logs/4-STABLE/ksh93-20060124.log http://srvmix.galle.com.br/tb/logs/5-STABLE/ksh93-20060124.log http://srvmix.galle.com.br/tb/logs/6-STABLE/ksh93-20060124.log Sorry, but i'm trying hard to reproduce this problem but I cannot, should you build it and send me the buildlog, with more information like FreeBSD version, arch and everything you can? Thanks a lot -- Renato Botelho <garga @ FreeBSD.org> <freebsd @ galle.com.br> GnuPG Key: http://www.FreeBSD.org/~garga/pubkey.asc
State Changed From-To: feedback->closed Committed. With a minor change, i add a .if to add OSREL just for freebsd >= 6.x. Thanks!