Bug 93191 - [PATCH] fix audacity build errors on amd64/possibly others
Summary: [PATCH] fix audacity build errors on amd64/possibly others
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-11 17:10 UTC by Dan Ponte
Modified: 2006-04-15 21:10 UTC (History)
1 user (show)

See Also:


Attachments
tonegen.diff (542 bytes, patch)
2006-02-11 17:10 UTC, Dan Ponte
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Ponte 2006-02-11 17:10:03 UTC
	Supposedly, audacity is broken on platforms other than i386. I don't see how this problem is related to this, but applying the included patch lets me build and use audacity on my amd64 machine.

Fix: Apply this patch (from audacity 1.3 CVS audacity/audacity-src/effects/ToneGen.cpp revision 1.22)
How-To-Repeat: 	Try to build audacity with the above system.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-02-11 20:05:16 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Craig Boston 2006-02-11 23:33:12 UTC
Thanks for taking the time to track this down, I don't have any 64-bit
architectures here to test with.  I'm not sure what is different about
the compiler on amd64 and sparc64 that cause it to be an issue there
(AFAICT the other constructor for wxChoice shouldn't be a canditate in
the first place as it doesn't provide the default value).

If this is the only problem preventing builds on 64-bit arch, then
please commit away and remove BROKEN.

Thanks!
Craig
Comment 3 Ruben de Groot 2006-03-19 21:01:39 UTC
I can confirm that this patch lets me build and use audacity on my amd64.

Please commit

regards,
Ruben de Groot

-- 
"Windows' job is to prevent you from shooting yourself in the foot. With
UNIX, the idea is to make damn sure that there is a hole in your foot
with the greatest possible efficiency."
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2006-03-20 05:17:20 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 Tilman Keskinoz freebsd_committer freebsd_triage 2006-04-15 21:10:13 UTC
State Changed
From-To: open->closed

committed, thanks