fixing build on 4.x Always use USE_GETOPT_LONG to check for GNU getopt Set port revision to '2'
Class Changed From-To: maintainer-update->change-request Fix category (submitter is not maintainer)
State Changed From-To: open->feedback Awaiting maintainers feedback
yes, I approve the patch. --vk On Feb 11, 2006, at 10:04 PM, Edwin Groothuis wrote: > Maintainer of security/fwbuilder, > > Please note that PR ports/93225 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/93225 > > -- > Edwin Groothuis > edwin@FreeBSD.org > > > !DSPAM:43eecff7320601053114657! >
State Changed From-To: feedback->open Maintainer approved.
State Changed From-To: open->feedback Your patch removes the SHA256 checksum and replaces the MD5 checksum in distinfo. Please send an updated patch with SHA256 as well. Why did the MD5 checksum change? If the distfile was changed please compare the old and new distfiles and summarise the changes so we can be sure nothing nasty has been inserted. Do these changes affect the function or contents of the built package? If it is just a build fix for 4.x, there is no need to bump PORTREVISION.
Responsible Changed From-To: freebsd-ports-bugs->lawrance Track
the MD5 has changed because all the files were autogenerated as part of automatic build. You are right, there is no need to change the source tar.gz and hence MD5 in the distfile should not change either. I've fixed that, and returned PORTREVISION back to 1. New diff is attached. thanks --vk
State Changed From-To: feedback->closed Committed, thanks! There was no need for a PORTREVISION bump.