portlint mistakes something in USE_RC_SUBR check and gives a fatal error. How-To-Repeat: itetcu@it> /home/itetcu/tmp/CVS/ports/mail/dspam-devel [11:59:23] 0 > portlint -C [ ... ] FATAL: ${PORTNAME}${RC_SUFX} listed in USE_RC_SUBR, but files/${PORTNAME}${RC_SUFX}.in is missing. 1 fatal errors and 13 warnings found. itetcu@it> /home/itetcu/tmp/CVS/ports/mail/dspam-devel [11:59:28] 1 > make -V PORTNAME -V RC_SUFX dspam-devel .sh itetcu@it> /home/itetcu/tmp/CVS/ports/mail/dspam-devel [11:59:41] 0 > ls files/dspam-devel.sh.in files/dspam-devel.sh.in If the Makefile is changed to: itetcu@it> /home/itetcu/tmp/CVS/ports/mail/dspam-devel [12:08:37] 0 > grep RC_S Makefile #RC_SUFX= .sh #USE_RC_SUBR= ${PORTNAME}${RC_SUFX} USE_RC_SUBR= ${PORTNAME} and the file exists: itetcu@it> /home/itetcu/tmp/CVS/ports/mail/dspam-devel [12:08:44] 0 > ls files/dspam-devel.in files/dspam-devel.in the error is still there: itetcu@it> /home/itetcu/tmp/CVS/ports/mail/dspam-devel [12:11:00] 0 > portlint -C [ ... ] FATAL: ${PORTNAME} listed in USE_RC_SUBR, but files/${PORTNAME}.in is missing.
Responsible Changed From-To: freebsd-ports-bugs->marcus Over to maintainer
Adding the suffix as you have in this port is not necessary, or desirable. There is already code in bsd.port.mk to handle this correctly. (Also, see http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/93265). If you simply remove the RC_SUFX stuff from you port, it will do the right thing for you. hope this helps, Doug -- If you're never wrong, you're not trying hard enough
On Mon, 13 Feb 2006 11:46:47 -0800 Doug Barton <dougb@dougbarton.us> wrote: > Adding the suffix as you have in this port is not necessary, or > desirable. There is already code in bsd.port.mk to handle this > correctly. (Also, see > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/93265). Yes, Pav filled that PR after a lenghty disscution with me and you, as you probably remember ;) > If you simply remove the RC_SUFX stuff from you port, it will do the > right thing for you. Yes, however portlint still compains. Actually the problem is that portlint to check USE_RC_SUBR looks after the literal value (what's on the right-hand of the =): USE_RC_SUBR= ${PORTNAME} ---> 'files/${PORTNAME}' USE_RC_SUBR= dsapm-devel ---> 'files/dspm-devel' which IMO is wrong, since there's no reason not to use the var (${PORTNAME}) instead of writing the VAR's value by hand. -- IOnut Unregistered ;) FreeBSD "user"
Ion-Mihai Tetcu wrote: > On Mon, 13 Feb 2006 11:46:47 -0800 > Doug Barton <dougb@dougbarton.us> wrote: > >> Adding the suffix as you have in this port is not necessary, or >> desirable. There is already code in bsd.port.mk to handle this >> correctly. (Also, see >> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/93265). > > Yes, Pav filled that PR after a lenghty disscution with me and you, as > you probably remember ;) Actually I filed that particular one last night, but if Pav already has one in, so much the better. >> If you simply remove the RC_SUFX stuff from you port, it will do the >> right thing for you. > > Yes, however portlint still compains. It _should_ complain about the RC_SUFX stuff, but ... > Actually the problem is that portlint to check USE_RC_SUBR looks after > the literal value (what's on the right-hand of the =): > USE_RC_SUBR= ${PORTNAME} ---> 'files/${PORTNAME}' > USE_RC_SUBR= dsapm-devel ---> 'files/dspm-devel' > which IMO is wrong, since there's no reason not to use the var > (${PORTNAME}) instead of writing the VAR's value by hand. You're right about that. I'll try to look at the portlint code and see if there is a way to dereference the variable to get that value. Doug -- If you're never wrong, you're not trying hard enough
State Changed From-To: open->closed Fixed in 2.8.5.
On Mon, 13 Feb 2006 12:45:50 -0800 Doug Barton <dougb@dougbarton.us> wrote: > Ion-Mihai Tetcu wrote: > > On Mon, 13 Feb 2006 11:46:47 -0800 > > Doug Barton <dougb@dougbarton.us> wrote: > > > >> Adding the suffix as you have in this port is not necessary, or > >> desirable. There is already code in bsd.port.mk to handle this > >> correctly. (Also, see > >> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/93265). > > > > Yes, Pav filled that PR after a lenghty disscution with me and you, > > as you probably remember ;) > > Actually I filed that particular one last night, but if Pav already > has one in, so much the better. :) sorry. It's very close to the one I remember and I looked at the content. > >> If you simply remove the RC_SUFX stuff from you port, it will do > >> the right thing for you. > > > > Yes, however portlint still compains. > > It _should_ complain about the RC_SUFX stuff, but ... > > > Actually the problem is that portlint to check USE_RC_SUBR looks > > after the literal value (what's on the right-hand of the =): > > USE_RC_SUBR= ${PORTNAME} ---> 'files/${PORTNAME}' > > USE_RC_SUBR= dsapm-devel ---> 'files/dspm-devel' > > which IMO is wrong, since there's no reason not to use the var > > (${PORTNAME}) instead of writing the VAR's value by hand. > > You're right about that. I'll try to look at the portlint code and > see if there is a way to dereference the variable to get that value. I see it's fixed in 2.8.5. My thanks to you and marcus@ -- IOnut Unregistered ;) FreeBSD "user"