Bug 94812 - Update port: security/base to 1.2.4 and add hooks for MySQL/PGSQL
Summary: Update port: security/base to 1.2.4 and add hooks for MySQL/PGSQL
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ion-Mihai "IOnut" Tetcu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-21 22:00 UTC by Linh Pham
Modified: 2006-05-16 13:10 UTC (History)
1 user (show)

See Also:

Attachments
base-1.2.4.diff (3.50 KB, patch)
2006-03-21 22:00 UTC, Linh Pham 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Linh Pham 2006-03-21 22:00:33 UTC 
Update security/base to 1.2.4; this PR supercedes ports/94085.

base r1.2.4 includes many, many bugfixes and changes which PDF library it uses.

I added hooks to the Makefile to allow the user to choose which database
to use, as well as the option to include support for PDF via print/fpdf.

Updated ./files/pkg-message.in to include mention of FPDF path, since it does
not use the standard PHP sub-ports or standard PHP class paths.

Any feedback on how I implemented how the the hooks are handled would be
appreciated.
Comment 1 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-05-09 11:55:38 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

I'll take it.
Comment 2 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-05-09 11:58:14 UTC 
> +.if defined(WITH_MYSQL)
> +USE_PHP+=	mysql
> +.endif
> +
> +.if defined(WITH_PGSQL)
> +USE_PHP+=	pgsql
> +.endif
> +
> +.if defined(WITH_PDF)
> +USE_PHP+=	zlib
> +RUN_DEPENDS+=	${LOCALBASE}/share/fpdf/fpdf.php:${PORTSDIR}/print/fpdf
> +.endif


Could you please convert this port to OPTIONS and send a new patch
please ?


-- 
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"

BOFH excuse #328:
Fiber optics caused gas main leak
Comment 3 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-05-09 22:36:52 UTC 
State Changed
From-To: open->feedback

Ask for maintainer fix.
Comment 4 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-05-10 01:34:29 UTC 
State Changed
From-To: feedback->open

Feedback recevied, converting to options will come later.
Comment 5 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-05-14 00:08:23 UTC 
State Changed
From-To: open->feedback

It looks like the Makefile could use a few variables from bsd.tcl.mk. Could you 
please check this and, if true, either submit a new diff ?
Comment 6 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-05-14 00:10:39 UTC 
State Changed
From-To: feedback->open

Wrong PR :)
Comment 7 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-05-14 00:11:19 UTC 
State Changed
From-To: open->feedback

Please tell where  WANT_PHP_PEAR= yes comes from, I've been unable to find any 
reference to it.
Comment 8 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-05-16 12:07:09 UTC 
State Changed
From-To: feedback->open

new patch received
Comment 9 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-05-16 13:10:56 UTC 
State Changed
From-To: open->closed

Committed. Thanks!