Bug 95588 - [patch] lang/dylan generates broken platforms.descr
Summary: [patch] lang/dylan generates broken platforms.descr
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-10 15:00 UTC by Martin Kaeske
Modified: 2006-04-24 13:09 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Kaeske 2006-04-10 15:00:31 UTC
The "pre-patch" target tries to replace every occurrence of 'libtool' in platforms.descr with '${LIBTOOL_LIBEXECDIR}/libtool'. Since $LIBTOOL_LIBEXECDIR isn't defined 'libtool' got replaced with '/libtool' (note the slash). $LIBTOOL_LIBEXECDIR isn't defined because bsd.autotools.mk isn't included and even if that would be the case $LIBTOOL_LIBEXECDIR would contain the wrong directory.

Fix: 

Remove the "pre-patch" target from the Makefile. There is only one libtool port and this port installs its files to /usr/local/bin so i guess there is no need to change platforms.descr at all.
How-To-Repeat: Install the port and generate a simple program using 'make-dylan-app'. Now try to compile this program using 'make'.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-04-10 15:08:11 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 housel 2006-04-12 03:23:00 UTC
On Mon, 2006-04-10 at 14:08 +0000, Edwin Groothuis wrote:
> Maintainer of lang/dylan,
> 
> Please note that PR ports/95588 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/95588
> 

I approve this fix.
-- 
Peter S. Housel <housel@acm.org>
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2006-04-13 08:22:36 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 4 Volker Stolz freebsd_committer freebsd_triage 2006-04-24 13:09:30 UTC
State Changed
From-To: open->closed

Committed, thanks!