Bug 95619 - japanese manpage of pdumpfs is wrong
Summary: japanese manpage of pdumpfs is wrong
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Tetsurou Okazaki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-11 12:20 UTC by TsurutaniNaoki
Modified: 2006-05-19 10:13 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description TsurutaniNaoki 2006-04-11 12:20:17 UTC 
	japanese manpage of sysutils/pdumpfs is wrong. no word is readable.

Fix: 

original character set of the man page seems to be JIS code.
	convert into euc-jp code before use.
	here is a patch to Makefile:
	--- Makefile.orig	Fri Nov 18 04:31:57 2005
	+++ Makefile	Tue Apr 11 20:04:04 2006
	@@ -19,13 +19,20 @@
	 ALL_TARGET=	pdumpfs
	 DOCS=		ChangeLog README doc/*

	+.if defined(WITH_JPMAN)
	+BUILD_DEPENDS= ${LOCALBASE}/bin/nkf:${PORTSDIR}/japanese/nkf
	 MANLANG=	"" ja
	+.endif
	 MAN8=		 pdumpfs.8

	 do-install:
	 	${INSTALL_SCRIPT} ${WRKSRC}/pdumpfs ${PREFIX}/sbin/
	 	${INSTALL_MAN} ${WRKSRC}/man/man8/pdumpfs.8 ${PREFIX}/man/man8/
	+.if defined(WITH_JPMAN)
	+	${MV} ${WRKSRC}/man/ja/man8/pdumpfs.8 ${WRKSRC}/man/ja/man8/pdumpfs.8j
	+	${LOCALBASE}/bin/nkf -e ${WRKSRC}/man/ja/man8/pdumpfs.8j > ${WRKSRC}/man/ja/man8/pdumpfs.8
	 	${INSTALL_MAN} ${WRKSRC}/man/ja/man8/pdumpfs.8 ${PREFIX}/man/ja/man8/
	+.endif
	 .if !defined(NOPORTDOCS)
	 	${MKDIR} ${DOCSDIR}
	 .for f in ${DOCS}
How-To-Repeat: 	after installation of japanese/man,
	% jman pdumpfs
	will print meaningless characters...
Comment 1 Volker Stolz freebsd_committer freebsd_triage 2006-04-15 14:18:56 UTC 
State Changed
From-To: open->feedback

Sorry, can you do without introducing the new variable WITH_JPMAN? 
I couldn't find any other reference to this.
Comment 2 TsurutaniNaoki 2006-05-02 05:08:43 UTC 
Here is a new patch:

--- sysutils/pdumpfs/Makefile.orig	Fri Nov 18 04:31:57 2005
+++ sysutils/pdumpfs/Makefile	Tue May  2 12:57:12 2006
@@ -25,6 +25,7 @@
 do-install:
 	${INSTALL_SCRIPT} ${WRKSRC}/pdumpfs ${PREFIX}/sbin/
 	${INSTALL_MAN} ${WRKSRC}/man/man8/pdumpfs.8 ${PREFIX}/man/man8/
+	${RUBY} -ni -r nkf -e 'puts NKF.nkf("-e",$$_)' ${WRKSRC}/man/ja/man8/pdumpfs.8
 	${INSTALL_MAN} ${WRKSRC}/man/ja/man8/pdumpfs.8 ${PREFIX}/man/ja/man8/
 .if !defined(NOPORTDOCS)
 	${MKDIR} ${DOCSDIR}

New fix does not depend on any other new ports nor use any new variable.
Comment 3 Tetsurou Okazaki freebsd_committer freebsd_triage 2006-05-02 07:48:35 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->okazaki

I will handle this.
Comment 4 TsurutaniNaoki 2006-05-17 06:06:41 UTC 
Thank you.  It works well.
Comment 5 Tetsurou Okazaki freebsd_committer freebsd_triage 2006-05-19 10:12:31 UTC 
State Changed
From-To: feedback->closed

Committed, thanks!
Comment 6 Tetsurou Okazaki freebsd_committer freebsd_triage 2006-05-19 10:12:31 UTC 
Class Changed
From-To: doc-bug->update

port update request