Bug 97196 - x11-wm/sawfish2 patches needed for amd64
Summary: x11-wm/sawfish2 patches needed for amd64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-13 09:50 UTC by kasahara
Modified: 2006-05-13 18:43 UTC (History)
0 users

See Also:


Attachments
file.diff (470 bytes, patch)
2006-05-13 09:50 UTC, kasahara
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description kasahara 2006-05-13 09:50:19 UTC
x11-wm/sawfish2 needs a couple of patches for amd64 platform.

One is already in CVS repository of sawfish which fixes window decoration.
Without this patch, sawfish continuously emits error messages and it doesn't
draw window frames collectly.

Another one fixes the return values of (window-frame-offset).
I submitted the patch to sawfish-list ML, but no response so far.
Without this patch, (warp-cursor-to-window) doesn't work collectly.
Actually window-frame-offset has negative values, so it should be int instead 
of u_int.
There is no such problem on i386 platform despite of the wrong declaration.
I don't know why.

Fix: Apply these patches in sawfish-1.3/src directory.

--- functions.c 3 Nov 2002 21:00:36 -0000       1.98
+++ functions.c 30 Oct 2003 05:35:18 -0000      1.99
@@ -704,8 +704,10 @@
            repv name;
            if (type == XA_ATOM && (name = x_atom_symbol (l_data[i])) != Qnil)
                rep_VECTI(ret_data, i) = name;
+           else if (type == XA_INTEGER)
+               rep_VECTI(ret_data, i) = rep_make_long_int((long) l_data[i]);
            else
-               rep_VECTI(ret_data, i) = rep_make_long_uint(l_data[i]);
+               rep_VECTI(ret_data, i) = rep_make_long_uint(l_data[i] & 0xffffffffUL);
        }
        break;
     }

How-To-Repeat: Install x11-wm/sawfish2 from ports and run as usual on amd64 platform.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-05-13 09:52:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gnome

Over to maintainer
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2006-05-13 18:43:09 UTC
State Changed
From-To: open->closed

Committed, thanks!