Bug 98166 - [PATCH] x11/rxvt-unicode: imlocale fix for freebsd
Summary: [PATCH] x11/rxvt-unicode: imlocale fix for freebsd
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-30 20:10 UTC by kcwu
Modified: 2006-06-04 20:33 UTC (History)
1 user (show)

See Also:


Attachments
rxvt-unicode-7.7_1.patch (4.26 KB, patch)
2006-05-30 20:10 UTC, kcwu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description kcwu 2006-05-30 20:10:12 UTC
rxvt-unicode assume wchar_t is unicode, but it's not true for freebsd.

This patch converts the IM input charater to unicode.

It requires additional patch dependancy and enlarge excutable size, 
so I provide a knob to disable. (2.5mb if WITH_ENCODING=all)


Added file(s):
- files/extra-patch-imlocale

Port maintainer (thierry@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-05-30 20:16:18 UTC
Responsible Changed
From-To: freebsd-ports-bugs->thierry

Over to maintainer
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2006-06-02 23:09:36 UTC
State Changed
From-To: open->feedback

From misfiled PR ports/98404: 

Date: Fri, 2 Jun 2006 23:35:05 +0200 
Comment 3 kcwu 2006-06-03 05:31:35 UTC
On Fri, Jun 02, 2006 at 10:10:01PM +0000, Mark Linimon wrote:
> From: Thierry Thomas <thierry@FreeBSD.org>
>  
>  Thanks for your patch! Could you please explain me how to test it?
>  
1. run IM server on locale other than utf8, for example,
	# cd /usr/ports/chinese/xcin25; make install
	$ LANG=zh_TW.Big5 xcin2.5&

2. run rxvt-unicode on any utf8 locale, and specify imlocale
	# cd /usr/ports/x11/rxvt-unicode; make WITH_ENCODING=zh install
	$ LANG=zh_TW.UTF-8 XMODIFIERS=@im=xcin urxvt -imlocale zh_TW.Big5

3. (assume xcin default config) press [ctrl]-[space], xcin window will
   change to "cj" mode, then type some words via input method, for example 
	type "a" [space] "1"
   xcin will send composed chinese word to urxvt
   ([ctrl]-[space] again back to normal english mode)

4. that chinese word is U+65E5 in utf8, or 0xA4E9 in big5 encoding
   with the patch, you could see correct U+65E5 in urxvt window
   without the patch, urxvt will get U+A4E9
Comment 4 Thierry Thomas freebsd_committer freebsd_triage 2006-06-03 22:34:31 UTC
On Sat  3 jui 06 at 6:31:35 +0200, Kuang-che Wu <kcwu@csie.org>
 wrote:
> >  Thanks for your patch! Could you please explain me how to test it?
> >  
> 1. run IM server on locale other than utf8, for example,
> 	# cd /usr/ports/chinese/xcin25; make install
> 	$ LANG=zh_TW.Big5 xcin2.5&

Thanks for your quick answer.

I encounter some problem with this server:

LANG=zh_TW.Big5 xcin2.5&
[1] 3037

XCIN (Chinese XIM server) version 2.5.3-pre2.
(module ver: 20010918, syscin ver: 20000210).
(use "-h" option for help)

xcin: locale "zh_TW.Big5" encoding "big5"
xcin: ĵ§i: invalid font BIG5-0.
xcin: ¿ù»~: fontset setting error.

[1]  + exit 255   LANG=zh_TW.Big5 xcin2.5

Note: to be clean, I have installed zh-xcin-2.5.3.p2_5 and its
dependences from packages, and I have unset my environment variables
LANG and LC_ALL.

Do I need something else?

Regards,
-- 
Th. Thomas.
Comment 5 Thierry Thomas freebsd_committer freebsd_triage 2006-06-04 20:31:22 UTC
State Changed
From-To: feedback->closed


Committed, thanks! 

Remark: it would be fine to submit this patch to the author, so it could 
be handled upstream.